Pieter Vander Vennet pietervdvn · he/him
  • Joined on 2024-11-25
875 contributions in the last 12 months
MayJunJulAugSepOctNovDecJanFebMarAprMonWedFri
Less
More
pietervdvn commented on issue MapComplete/MapComplete#2384 2025-04-22 03:16:21 +02:00
Too many requests to Panoramax APIs

Should be fixed in 549129671a747877ce4b74c1e5ffd90ec47b2cc9, I'll close once validated

pietervdvn commented on issue MapComplete/MapComplete#2386 2025-04-22 02:00:05 +02:00
Unable to login through openstreetmap.

I had a similar report (via chat) earlier today, but cannot reproduce on my own machine. This might have been a temporary problem, would you mind checking again?

pietervdvn commented on pull request MapComplete/MapComplete#2382 2025-04-22 01:30:13 +02:00
add sauna theme

I've created a new way to reuse tagRenderings where you can set a prefix. It can be used as following:

{
  "builtin": "sauna.*",
  "override": {
    "condition":{"and"+: "sauna=yes"}
pietervdvn commented on pull request MapComplete/MapComplete#2382 2025-04-22 01:26:40 +02:00
add sauna theme

As far as i see, the sentences are not specific for defibrillators.

The dutch (nl) one is ;) In any case, it is a bad habit of reusing this tagrendering from an unrelated layer. I propose…

pietervdvn pushed to develop at MapComplete/MapComplete 2025-04-21 04:11:15 +02:00
3bc8eae6b1 Themes: add toilet information in food and shops
92eca242ec Themes: simplify toilets theme by using the new prefix functionality
01680f236c Themes: allow to easily import tagrenderings and add a prefix key to all tags
4d9bdaf877 Docs: improve error message
dd2a28b259 Tests: fix tests
Compare 8 commits »
pietervdvn commented on pull request MapComplete/MapComplete#2382 2025-04-20 01:49:00 +02:00
add sauna theme

Another small issue (which causes the build to block) is that sauna_at_leisure should be in its own directory in layers/sauna_at_leisure

pietervdvn deleted branch Robin-patch-1 from MapComplete/MapComplete 2025-04-20 01:40:14 +02:00
pietervdvn pushed to develop at MapComplete/MapComplete 2025-04-20 01:40:14 +02:00
6aaafe8ea4 Merge pull request 'Some patches' () from Robin-patch-1 into develop
45e20dadee Themes(waste): Include excrement bag dispensers ()
f072b82fc3 Themes(mobility_hub): noname and network options
217d206a06 Merge branch 'develop' into Robin-patch-1
369c2e6ee8 Themes(mobility_hub): Add condition to marker question
Compare 5 commits »
pietervdvn merged pull request MapComplete/MapComplete#2383 2025-04-20 01:40:12 +02:00
Some patches
pietervdvn commented on pull request MapComplete/MapComplete#2382 2025-04-20 01:38:29 +02:00
add sauna theme

It's a very rare case, but I want to cover leisure=water_park;sauna for example.

There were 5 leisure=water_park;sauna in OSM, I did retag them all. It happens that, when I make a theme, I…

pietervdvn commented on pull request MapComplete/MapComplete#2383 2025-04-20 01:32:48 +02:00
Some patches

Congratulations! This PR been successfully built and has been deployed. It is (temporarily) available on https://builds.mapcomplete.org/2383

pietervdvn approved MapComplete/MapComplete#2383 2025-04-20 01:10:34 +02:00
Some patches
pietervdvn commented on pull request MapComplete/MapComplete#2382 2025-04-18 15:40:31 +02:00
add sauna theme

I will review the 'sauna-at-amenity'-layer on, but might, in the meantime, also work on some code to make this type of question reuse easier (i.e. to automatically 'prefix' every key)

pietervdvn commented on pull request MapComplete/MapComplete#2382 2025-04-18 14:43:32 +02:00
add sauna theme

You are reusing the 'fixme' for 'defibrillators'. This results in a question 'are there any other things you want to say about this defibrillator ?'. That is pretty confusing as this is about sauna's...

pietervdvn commented on pull request MapComplete/MapComplete#2382 2025-04-18 14:43:08 +02:00
add sauna theme

Please, also add an allowMove block. These aren't added by default in Studio, but it is required for official themes. It is also what caused the build to fail.

pietervdvn commented on pull request MapComplete/MapComplete#2382 2025-04-18 14:41:58 +02:00
add sauna theme

The 'source' is a bit weird. First of all, leisure~.*sauna.* will give all items which have a substring sauna in the leisure key.

pietervdvn commented on pull request MapComplete/MapComplete#2382 2025-04-18 14:36:12 +02:00
add sauna theme

Wow, you are using a 'rewrite'-block. That is pretty neat

pietervdvn synced commits to master at pietervdvn/list_how_openstreetmap_can_be_... from mirror 2025-04-18 13:17:10 +02:00
ce1844befe more useful log, closer to intended deployable code
388d9a3333 crowning part of matching on missing names
c6727b19fb explain better
7362c1aff8 remove mismatch root cause
b447d1b501 drop dead code
Compare 10 commits »
pietervdvn closed issue MapComplete/MapComplete#2376 2025-04-18 00:29:03 +02:00
sauna theme
pietervdvn commented on issue MapComplete/MapComplete#2376 2025-04-18 00:29:02 +02:00
sauna theme

I'm gonna close this issue as your question is answered, I'll follow up in the pull request when it arrives.