Should be fixed in 549129671a747877ce4b74c1e5ffd90ec47b2cc9, I'll close once validated
I had a similar report (via chat) earlier today, but cannot reproduce on my own machine. This might have been a temporary problem, would you mind checking again?
I've created a new way to reuse tagRenderings where you can set a prefix. It can be used as following:
{
"builtin": "sauna.*",
"override": {
"condition":{"and"+: "sauna=yes"}…
As far as i see, the sentences are not specific for defibrillators.
The dutch (nl
) one is ;)
In any case, it is a bad habit of reusing this tagrendering from an unrelated layer. I propose…
Another small issue (which causes the build to block) is that sauna_at_leisure
should be in its own directory in layers/sauna_at_leisure
It's a very rare case, but I want to cover leisure=water_park;sauna for example.
There were 5 leisure=water_park;sauna
in OSM, I did retag them all. It happens that, when I make a theme, I…
Congratulations! This PR been successfully built and has been deployed. It is (temporarily) available on https://builds.mapcomplete.org/2383
I will review the 'sauna-at-amenity'-layer on, but might, in the meantime, also work on some code to make this type of question reuse easier (i.e. to automatically 'prefix' every key)
You are reusing the 'fixme' for 'defibrillators'. This results in a question 'are there any other things you want to say about this defibrillator ?'. That is pretty confusing as this is about sauna's...
Please, also add an allowMove
block. These aren't added by default in Studio, but it is required for official themes. It is also what caused the build to fail.
The 'source' is a bit weird. First of all, leisure~.*sauna.*
will give all items which have a substring sauna
in the leisure key.
I'm gonna close this issue as your question is answered, I'll follow up in the pull request when it arrives.