Pieter Vander Vennet pietervdvn · he/him
1 follower · 0 following
  • Joined on 2024-11-25
Repositories Projects Packages Public activity Starred repositories
pietervdvn pushed to develop at MapComplete/MapComplete 2024-12-11 02:12:31 +01:00
acb651b96f Typing: use 'strict' for GeoOperations.ts module
pietervdvn pushed to develop at MapComplete/MapComplete 2024-12-11 01:14:20 +01:00
95c1ef28e9 Merge remote-tracking branch 'source/develop' into develop
2a135f9eef Themes(climbing): Recognize leisure=sports_hall
9b8235e51f Themes(climbing): Add auto belay tags
12f0ec98fb Themes(climbing): Clarify questions about gear rental
a4243986ea Themes(climbing): Change conditions for gear rental questions
Compare 6 commits »
pietervdvn pushed to develop at MapComplete/MapComplete 2024-12-11 01:13:33 +01:00
9ab8d99e56 Fix: fix #2306 by using a cutof of 150m
pietervdvn deleted branch climbing-improvements from midgard/MapComplete 2024-12-10 16:52:00 +01:00
pietervdvn pushed to develop at MapComplete/MapComplete 2024-12-10 16:51:59 +01:00
a79e454309 Merge pull request 'Climbing theme improvements' (#2284) from midgard/MapComplete:climbing-improvements into develop
f35bf01abb Themes(climbing): Recognize leisure=sports_hall
026825aa3d Themes(climbing): Add auto belay tags
c54060e4ab Themes(climbing): Clarify questions about gear rental
6bcdb6d9a0 Themes(climbing): Change conditions for gear rental questions
Compare 5 commits »
pietervdvn merged pull request MapComplete/MapComplete#2284 2024-12-10 16:51:58 +01:00
Climbing theme improvements
pietervdvn commented on pull request MapComplete/MapComplete#2284 2024-12-10 16:51:49 +01:00
Climbing theme improvements

Excellent! The build also passed: https://hosted.mapcomplete.org/2284/climbing.html?

pietervdvn approved MapComplete/MapComplete#2284 2024-12-10 16:50:39 +01:00
Climbing theme improvements
pietervdvn pushed to develop at MapComplete/MapComplete 2024-12-10 02:38:08 +01:00
0a001d3c7d Fix: fix #2304
b615c34879 Themes(cyclofix): don't count shops in overview
30125d35ce Chore(runner): remove obsolete files
Compare 3 commits »
pietervdvn pushed to develop at MapComplete/MapComplete 2024-12-10 00:27:25 +01:00
53e9c9b22f Chore(runner): remove obsolete step
52b4505c63 Chore(runner): rename build step
Compare 2 commits »
pietervdvn suggested changes for MapComplete/MapComplete#2284 2024-12-09 22:53:10 +01:00
Climbing theme improvements

There are still a few bugs - see the comments I left.

pietervdvn commented on pull request MapComplete/MapComplete#2284 2024-12-09 22:52:41 +01:00
Climbing theme improvements

Looks like some very valuable fixes!

However, there are still a few technical nitpicks to solve, which'll remove this error message: ./assets/layers/climbing_gym/climbing_gym.json.tagRenderings.…

pietervdvn commented on pull request MapComplete/MapComplete#2284 2024-12-09 22:50:52 +01:00
Climbing theme improvements

Same as above

pietervdvn commented on pull request MapComplete/MapComplete#2284 2024-12-09 22:50:31 +01:00
Climbing theme improvements

If one sets a freeform with key, you should use render as fallback option:

pietervdvn commented on pull request MapComplete/MapComplete#2284 2024-12-09 22:49:00 +01:00
Climbing theme improvements

Use "questionHint" for extra remarks, such as excluding those for speed

pietervdvn pushed to develop at MapComplete/MapComplete 2024-12-09 22:45:14 +01:00
cfccec2a88 Chore(runner): split build step into multiple steps
pietervdvn pushed to develop at MapComplete/MapComplete 2024-12-09 22:21:10 +01:00
057a32aedd Chore(runner): fixes to labels
pietervdvn pushed to develop at MapComplete/MapComplete 2024-12-09 22:19:12 +01:00
8141f77076 Chore(runner): fixes to zipped upload
fe0f6d1cbf Chore(runner): add 'hetzner-access' label as needed
Compare 2 commits »
pietervdvn commented on issue MapComplete/MapComplete#2282 2024-12-09 21:36:58 +01:00
Clean up unused strings

No, only a script to remove a translation from the relevant files, not to find them.

pietervdvn pushed to develop at MapComplete/MapComplete 2024-12-09 21:31:28 +01:00
eb248a3edc Chore(runner): zip files before sending them of