add buildin 'free' filter #2507

Merged

pietervdvn merged 2 commits from Osmwithspace/MapComplete:filter-free into develop

2025-08-25 12:23:57 +00:00

Osmwithspace commented

2025-08-20 07:43:30 +00:00

Collaborator

No description provided.

Osmwithspace added 1 commit 2025-08-20 07:43:31 +00:00

add buildin 'free' filter

/ deploy_on_hosted (pull_request) Failing after 1m39s

Details

bf354e70c6

pietervdvn commented

2025-08-20 10:46:47 +00:00

Owner

Could it be that you moved the filter to filters.json but forgot to commit filters.json? That file is not marked as changed...

Could it be that you moved the filter to `filters.json` but forgot to commit `filters.json`? That file is not marked as changed...

pietervdvn requested changes 2025-08-20 10:47:11 +00:00

pietervdvn left a comment

Owner

Does not build, did you forget to commit filters.json?

Osmwithspace commented

2025-08-21 07:21:39 +00:00

Author

Collaborator

No, I did not change the filters.json. The free filter is already in there:

     {
       "id": "free",
       "options": [
         {
           "question": {
             "en": "Free to use",
             "ca": "Ús gratuït",
             "cs": "Použití zdarma",
             "da": "Gratis at bruge",
             "de": "Nutzung kostenlos",
             "es": "De uso gratuito",
             "fr": "Utilisation gratuite",
             "it": "Utilizzo gratuito",
             "nl": "Gratis toegankelijk",
             "uk": "Безкоштовне використання"
           },
           "osmTags": {
             "or": [
               "fee=no",
               "fee=0",
               "charge=0"
             ]
           }
         }
       ]
     },

No, I did not change the `filters.json`. The `free` filter is already in there: https://source.mapcomplete.org/MapComplete/MapComplete/src/commit/5b7a117af3f2ff5edce8b730b72fe925cafd8637/assets/layers/filters/filters.json#L272-L297

pietervdvn added 1 commit 2025-08-25 11:11:19 +00:00