MapComplete/MapComplete
MapComplete/MapComplete
3
5
Fork 6
Code Issues 172 Pull requests 2 Activity Actions

WIP: New theme: public notice boards [v2] #2357

Draft
midgard wants to merge 1 commit from midgard/MapComplete:public_notice_boards2 into develop
pull from: midgard/MapComplete:public_notice_boards2
merge into: MapComplete:develop
Conversation 1 Commits 1 Files changed 6 +471 -224
midgard commented 2025-03-13 21:56:10 +01:00
Contributor
Copy link

Follow-up from #2280 which got stale. I've been looking into this today.

The question selection I made for public notice boards is quite different from advertising.

So what I'm having in mind now, is to:

  • still create a public_notice_boards layer, but reference the overlapping questions with "builtin",
  • exclude advertising=board access=yes from the advertising layer, and
  • include public_notice_boards in the advertising theme.

Does that sound good?

I pushed some code already but haven't had the opportunity to test it yet.

This theme is about boards where the public can freely add posters for for example local events. Wikipedia page (fr). Info page about the boards in Ghent (nl). This theme was created in response to a question by someone from a cultural organization who is interested in mapping and seeing all the public notice boards in Ghent. There is overlap with the existing advertising theme, but this theme has a very different focus.

The tags of interest are advertising=board and access=yes. A particular subtag is message=*, this theme only shows showbiz, non_profit, opinion, religion, since other values are seldom or never applicable for public notice boards.

Since many public notice boards are still mapped without access=yes, at high zoom the theme shows all advertising=boards, using the override technique described in Making_Your_Own_Theme.md section "Don't: use a layer to filter".

  • The codebase is GPL-licensed. By opening a pull request, the new theme will be GPL too
  • All images are included in the pull request and no images are loaded from an external service (e.g. Wikipedia)
  • The guidelines on how to make your own theme
    are read and followed
Follow-up from #2280 which got stale. I've been looking into this today. The question selection I made for public notice boards is quite different from advertising. So what I'm having in mind now, is to: - still create a `public_notice_boards` layer, but reference the overlapping questions with "builtin", - exclude `advertising=board` `access=yes` from the `advertising` layer, and - include `public_notice_boards` in the `advertising` theme. Does that sound good? I pushed some code already but haven't had the opportunity to test it yet. --- This theme is about boards where the public can freely add posters for for example local events. [Wikipedia page (fr)](https://fr.wikipedia.org/wiki/Affichage_libre?useskin=vector). [Info page about the boards in Ghent (nl)](https://stad.gent/nl/student-in-gent/studenten-vrije-tijd/fuiven-en-evenementen-organiseren/affiches-plakken). This theme was created in response to a question by someone from a cultural organization who is interested in mapping and seeing all the public notice boards in Ghent. There is overlap with the existing advertising theme, but this theme has a very different focus. The tags of interest are [`advertising=board`](https://wiki.openstreetmap.org/wiki/Tag%3Aadvertising%3Dboard) and `access=yes`. A particular subtag is [`message=*`](https://wiki.openstreetmap.org/wiki/Key:message), this theme only shows `showbiz`, `non_profit`, `opinion`, `religion`, since other values are seldom or never applicable for public notice boards. Since many public notice boards are still mapped without `access=yes`, at high zoom the theme shows all `advertising=board`s, using the override technique described in Making_Your_Own_Theme.md section "Don't: use a layer to filter". - [x] The codebase is GPL-licensed. By opening a pull request, the new theme will be GPL too - [x] All images are included in the pull request and no images are loaded from an external service (e.g. Wikipedia) - [x] The [guidelines on how to make your own theme](https://github.com/pietervdvn/MapComplete/blob/master/Docs/Making_Your_Own_Theme.md) are read and followed
midgard commented 2025-03-13 22:11:09 +01:00
Author
Contributor
Copy link

I tried to test but got a fatal error. I rebased locally on top of the latest release commit and tried again, but still the error, even after npm run generate:translations:

Error while initializing:  TypeError: (intermediate value).t.general.attribution.openStatistics is undefined
    create_if_block_5 MenuDrawer.svelte:1718
    create_default_slot_8 MenuDrawer.svelte:239
    create_slot index.mjs:71
    create_fragment SidebarUnit.svelte:27
    init index.mjs:2180
    SidebarUnit SidebarUnit.svelte:109
    createProxiedComponent svelte-hooks.js:341
    ProxyComponent proxy.js:242
    Proxy<SidebarUnit> proxy.js:349
    create_if_block_4 MenuDrawer.svelte:1175
    create_fragment MenuDrawer.svelte:199
    init index.mjs:2180
    MenuDrawer MenuDrawer.svelte:4001
    createProxiedComponent svelte-hooks.js:341
    ProxyComponent proxy.js:242
    Proxy<MenuDrawer> proxy.js:349
    create_fragment ThemeViewGUI.svelte:2694
    init index.mjs:2180
    ThemeViewGUI ThemeViewGUI.svelte:3739
    createProxiedComponent svelte-hooks.js:341
    ProxyComponent proxy.js:242
    Proxy<ThemeViewGUI> proxy.js:349
    create_else_block SingleThemeGui.svelte:38
    create_fragment SingleThemeGui.svelte:124
    init index.mjs:2180
    SingleThemeGui SingleThemeGui.svelte:259
    createProxiedComponent svelte-hooks.js:341
    ProxyComponent proxy.js:242
    Proxy<SingleThemeGui> proxy.js:349
    main index.ts:15
I tried to test but got a fatal error. I rebased locally on top of the latest release commit and tried again, but still the error, even after `npm run generate:translations`: ``` Error while initializing: TypeError: (intermediate value).t.general.attribution.openStatistics is undefined create_if_block_5 MenuDrawer.svelte:1718 create_default_slot_8 MenuDrawer.svelte:239 create_slot index.mjs:71 create_fragment SidebarUnit.svelte:27 init index.mjs:2180 SidebarUnit SidebarUnit.svelte:109 createProxiedComponent svelte-hooks.js:341 ProxyComponent proxy.js:242 Proxy<SidebarUnit> proxy.js:349 create_if_block_4 MenuDrawer.svelte:1175 create_fragment MenuDrawer.svelte:199 init index.mjs:2180 MenuDrawer MenuDrawer.svelte:4001 createProxiedComponent svelte-hooks.js:341 ProxyComponent proxy.js:242 Proxy<MenuDrawer> proxy.js:349 create_fragment ThemeViewGUI.svelte:2694 init index.mjs:2180 ThemeViewGUI ThemeViewGUI.svelte:3739 createProxiedComponent svelte-hooks.js:341 ProxyComponent proxy.js:242 Proxy<ThemeViewGUI> proxy.js:349 create_else_block SingleThemeGui.svelte:38 create_fragment SingleThemeGui.svelte:124 init index.mjs:2180 SingleThemeGui SingleThemeGui.svelte:259 createProxiedComponent svelte-hooks.js:341 ProxyComponent proxy.js:242 Proxy<SingleThemeGui> proxy.js:349 main index.ts:15 ```
midgard force-pushed public_notice_boards2 from 7f0a127075 to 606a7f53ae 2025-03-14 09:49:11 +01:00 Compare
Some checks failed
/ deploy_on_hosted (pull_request) Failing after 43m3s
Details
This pull request has changes conflicting with the target branch.
  • assets/layers/advertising/advertising.json
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u public_notice_boards2:midgard-public_notice_boards2
git checkout midgard-public_notice_boards2

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git checkout develop
git merge --no-ff midgard-public_notice_boards2
git checkout midgard-public_notice_boards2
git rebase develop
git checkout develop
git merge --ff-only midgard-public_notice_boards2
git checkout midgard-public_notice_boards2
git rebase develop
git checkout develop
git merge --no-ff midgard-public_notice_boards2
git checkout develop
git merge --squash midgard-public_notice_boards2
git checkout develop
git merge --ff-only midgard-public_notice_boards2
git checkout develop
git merge midgard-public_notice_boards2
git push origin develop
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Android-shell

Label for issues related to the android shell

  
awaiting feedback

We are waiting for the OP to get back to us, e.g. with an example

  
awaiting fix confirmation

We are waiting for OP to confirm that the fix worked for them (or will close when they don't reply)

  
bug

Something isn't working

  
enhancement

New feature or request

  
Help Wanted

Extra attention is needed

  
high-priority

It's urgent!

  
huge

A huge task, preferably to do with funding

  
low-priority

Might be fixed one day... or not

  
Meta

Something that cannot be fixed by code

  
NLNet

Will be developed, funded by NLNet

  
OSOC21:Cycling-OVL

A feature specific for this project

  
Performance

Make things faster or leaner

  
question

Further information is requested

  
search-ui-enhancement

Related to the search functionality

  
Studio

Graphical user interface to create or edit themes and layers

  
Tailwind

Something related to the CSS-framework

  
Themes

A new theme idea or improvement to an already existing theme

  
UI

Related to the user interface

  
upstream-issue

An issue that should be fixed in an upstram library

  
usertest

Issues surfaced during usertests

No labels
Android-shell
awaiting feedback
awaiting fix confirmation
bug
enhancement
Help Wanted
high-priority
huge
low-priority
Meta
NLNet
OSOC21:Cycling-OVL
Performance
question
search-ui-enhancement
Studio
Tailwind
Themes
UI
upstream-issue
usertest
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: MapComplete/MapComplete#2357
No description provided.
Delete branch "midgard/MapComplete:public_notice_boards2"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?