MapComplete/MapComplete

Fork 2

WIP: AED theme usability improvements #2290

Draft

midgard wants to merge 5 commits from midgard/MapComplete:defibrillators into develop

midgard commented

2024-12-18 03:05:53 +01:00

Contributor

Inaccessible AEDs really should not look the same on the AED map. Especially for dispatchers who need to direct people to a close-by accessible AED…

This WIP PR introduces new generic filters public_access and wheelchair_accessible and adds them to the defibrillators layer.

It also differentiates the marker colour and size based on access=* and opening_hours=*, but I'm going to play with that some more, especially when iconSize works again.

The PR also does away with debrillator=manual which is a garbage tag that isn't being used correctly even once. (Not even an exaggeration, I checked :D ) I removed it from the wiki too.

Lastly, I changed the authorship information of the defibrillator SVGs. Coincidentally it was me who had done the tracing of the 22 May 2019 revision! But I hadn't changed authorship information on Wikimedia Commons yet. This is now fixed.

Blocked by

#2289 iconSize mapping broken

Inaccessible AEDs *really* should not look the same on the AED map. Especially for dispatchers who need to direct people to a close-by accessible AED… This WIP PR introduces new generic filters `public_access` and `wheelchair_accessible` and adds them to the defibrillators layer. It also differentiates the marker colour and size based on `access=*` and `opening_hours=*`, but I'm going to play with that some more, especially when iconSize works again. The PR also does away with `debrillator=manual` which is a garbage tag that isn't being used correctly even once. (Not even an exaggeration, I checked :D ) I [removed] it from the wiki too. Lastly, I changed the authorship information of the defibrillator SVGs. Coincidentally it was me who had done the tracing of the 22 May 2019 revision! But I hadn't changed authorship information on Wikimedia Commons yet. This is now [fixed]. [removed]: https://wiki.openstreetmap.org/wiki/Talk:Tag:emergency%3Ddefibrillator#Deprecating_defibrillator=manual [fixed]: https://commons.wikimedia.org/w/index.php?title=File%3AISO_7010_E010.svg&diff=prev&oldid=971637934 **Blocked by** - [x] #2289 iconSize mapping broken

midgard added 4 commits 2024-12-18 03:05:54 +01:00

Themes(aed): remove defibrillator=manual 626f614ecb

See https://wiki.openstreetmap.org/wiki/Talk:Tag:emergency%3Ddefibrillator#Deprecating_defibrillator=manual:
used 29 times, of which 29 times incorrectly. Manual defibrillators are
not something that we can map.

Themes(aed): correct license information for the defibrillator SVGs 670939cb63

Actually it was me who traced these files. I changed this on Wikimedia
Commons too now, see
https://commons.wikimedia.org/wiki/File:ISO_7010_E010.svg
revision of 22 May 2019.

And clean up SVG source.

Themes(aed): add more filters 1ee0e5f462

Themes(aed): change marker size and colour based on access and opening hours

Deploy develop on dev.mapcomplete.org / deploy_on_hosted (pull_request) Successful in 30m13s

Details

1709ccf403

midgard force-pushed defibrillators from 1709ccf403 to c1008dc617

2024-12-18 21:37:12 +01:00

Compare

midgard force-pushed defibrillators from c1008dc617 to 65d1fb1647

2024-12-18 22:06:25 +01:00

Compare

midgard commented

2024-12-18 22:26:27 +01:00

Author

Contributor

Currently it looks like this. Perhaps I should remove the wheelchair icons.

mapcomplete-defibrillators-wip-2024-12-18.png

371 KiB

pietervdvn commented

2024-12-26 17:44:30 +01:00

Owner

I'm not really fond of this approach. Especially the multiple sizes/colours are quite unclear.

Maybe we should use a 'lock'-icon, similar to the toilets?

And, TBH, if someone is available in the "locked" venue, they'll probably lend it.

I'm not really fond of this approach. Especially the multiple sizes/colours are quite unclear. Maybe we should use a 'lock'-icon, similar to the toilets? And, TBH, if someone is available in the "locked" venue, they'll probably lend it.

midgard changed title from ~~WIP: AED theme usability improvements~~ to AED theme usability improvements

2024-12-26 19:03:38 +01:00

midgard commented

2024-12-26 19:19:34 +01:00

Author

Contributor

I'm not really fond of this approach. Especially the multiple sizes/colours are quite unclear.

I can imagine. It would need a legend. Tbh I also find it kind of messy like this.

Maybe we should use a 'lock'-icon, similar to the toilets?

Perhaps a lock icon as well as using a grey icon for fast reference?

And, TBH, if someone is available in the "locked" venue, they'll probably lend it.

True. But you first have to find someone and ask, which takes time. And if there isn't anyone around near the entrance, you can't even get access to it. When you need an AED, you just don't have time to waste looking for inaccessible AEDs.

If it's your only option, you may have a shot at an AED of unknown accessibility. But I hold that it should be visible on the map. Take for instance a secondary school in Blankenberge: its AED: is visible from the street, but the nearby entrance is never open and there's no front desk there. Around the corner in the Kerkstraat there's a 24/7 AED in an outdoor cabinet, and also nearby there's an AED intended for public use in a pub (though with unknown opening hours).

> I'm not really fond of this approach. Especially the multiple sizes/colours are quite unclear. I can imagine. It would need a legend. Tbh I also find it kind of messy like this. > Maybe we should use a 'lock'-icon, similar to the toilets? Perhaps a lock icon as well as using a grey icon for fast reference? > And, TBH, if someone is available in the "locked" venue, they'll probably lend it. True. But you first have to find someone and ask, which takes time. And if there isn't anyone around near the entrance, you can't even get access to it. When you need an AED, you just don't have time to waste looking for inaccessible AEDs. If it's your only option, you may have a shot at an AED of unknown accessibility. But I hold that it should be visible on the map. Take for instance a secondary school in Blankenberge: [its AED](https://mapcomplete.org/aed.html?z=16&lat=51.314121&lon=3.128649#node/3200411326): is visible from the street, but the nearby entrance is never open and there's no front desk there. Around the corner in the Kerkstraat there's a 24/7 AED in an outdoor cabinet, and also nearby there's an AED intended for public use in a pub (though with unknown opening hours).

midgard changed title from ~~AED theme usability improvements~~ to WIP: AED theme usability improvements

2024-12-26 19:19:49 +01:00

Deploy develop on dev.mapcomplete.org / deploy_on_hosted (pull_request) Successful in 30m5s

Details

This pull request has changes conflicting with the target branch.

langs/layers/ko.json

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u defibrillators:midgard-defibrillators

git checkout midgard-defibrillators

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git checkout develop

git merge --no-ff midgard-defibrillators

git checkout midgard-defibrillators

git rebase develop

git checkout develop

git merge --ff-only midgard-defibrillators

git checkout midgard-defibrillators

git rebase develop

git checkout develop

git merge --no-ff midgard-defibrillators

git checkout develop

git merge --squash midgard-defibrillators