MapComplete/MapComplete
MapComplete/MapComplete
4
7
Fork 9
Code Issues 199 Pull requests 3 Releases Activity Actions 1

AED theme usability improvements #2290

Closed
midgard wants to merge 6 commits from midgard/MapComplete:defibrillators into develop
pull from: midgard/MapComplete:defibrillators
merge into: MapComplete:develop
Conversation 6 Commits 6 Files changed 21 +174 -364
midgard commented 2024-12-18 02:05:53 +00:00
Contributor
Copy link

Inaccessible AEDs really should not look the same on the AED map. Especially for dispatchers who need to direct people to a close-by accessible AED…

This WIP PR introduces new generic filters public_access and wheelchair_accessible and adds them to the defibrillators layer.

It also differentiates the marker colour and size based on access=* and opening_hours=*, but I'm going to play with that some more, especially when iconSize works again.

The PR also does away with debrillator=manual which is a garbage tag that isn't being used correctly even once. (Not even an exaggeration, I checked :D ) I removed it from the wiki too.

Lastly, I changed the authorship information of the defibrillator SVGs. Coincidentally it was me who had done the tracing of the 22 May 2019 revision! But I hadn't changed authorship information on Wikimedia Commons yet. This is now fixed.

Blocked by

  • #2289 iconSize mapping broken
Inaccessible AEDs *really* should not look the same on the AED map. Especially for dispatchers who need to direct people to a close-by accessible AED… This WIP PR introduces new generic filters `public_access` and `wheelchair_accessible` and adds them to the defibrillators layer. It also differentiates the marker colour and size based on `access=*` and `opening_hours=*`, but I'm going to play with that some more, especially when iconSize works again. The PR also does away with `debrillator=manual` which is a garbage tag that isn't being used correctly even once. (Not even an exaggeration, I checked :D ) I [removed] it from the wiki too. Lastly, I changed the authorship information of the defibrillator SVGs. Coincidentally it was me who had done the tracing of the 22 May 2019 revision! But I hadn't changed authorship information on Wikimedia Commons yet. This is now [fixed]. [removed]: https://wiki.openstreetmap.org/wiki/Talk:Tag:emergency%3Ddefibrillator#Deprecating_defibrillator=manual [fixed]: https://commons.wikimedia.org/w/index.php?title=File%3AISO_7010_E010.svg&diff=prev&oldid=971637934 **Blocked by** - [x] #2289 iconSize mapping broken
midgard added 3 commits 2024-12-18 02:05:54 +00:00 
See https://wiki.openstreetmap.org/wiki/Talk:Tag:emergency%3Ddefibrillator#Deprecating_defibrillator=manual:
used 29 times, of which 29 times incorrectly. Manual defibrillators are
not something that we can map.
Actually it was me who traced these files. I changed this on Wikimedia
Commons too now, see
https://commons.wikimedia.org/wiki/File:ISO_7010_E010.svg
revision of 22 May 2019.

And clean up SVG source.
midgard force-pushed defibrillators from 1709ccf403 to c1008dc617 2024-12-18 20:37:12 +00:00 Compare
midgard force-pushed defibrillators from c1008dc617 to 65d1fb1647 2024-12-18 21:06:25 +00:00 Compare
midgard commented 2024-12-18 21:26:27 +00:00
Author
Contributor
Copy link

Currently it looks like this. Perhaps I should remove the wheelchair icons.

Currently it looks like this. Perhaps I should remove the wheelchair icons.
mapcomplete-defibrillators-wip-2024-12-18.png
371 KiB
mapcomplete-defibrillators-wip-2024-12-18.png
pietervdvn commented 2024-12-26 16:44:30 +00:00
Owner
Copy link

I'm not really fond of this approach. Especially the multiple sizes/colours are quite unclear.

Maybe we should use a 'lock'-icon, similar to the toilets?

And, TBH, if someone is available in the "locked" venue, they'll probably lend it.

I'm not really fond of this approach. Especially the multiple sizes/colours are quite unclear. Maybe we should use a 'lock'-icon, similar to the toilets? And, TBH, if someone is available in the "locked" venue, they'll probably lend it.
midgard changed title from WIP: AED theme usability improvements to AED theme usability improvements 2024-12-26 18:03:38 +00:00
midgard commented 2024-12-26 18:19:34 +00:00
Author
Contributor
Copy link

I'm not really fond of this approach. Especially the multiple sizes/colours are quite unclear.

I can imagine. It would need a legend. Tbh I also find it kind of messy like this.

Maybe we should use a 'lock'-icon, similar to the toilets?

Perhaps a lock icon as well as using a grey icon for fast reference?

And, TBH, if someone is available in the "locked" venue, they'll probably lend it.

True. But you first have to find someone and ask, which takes time. And if there isn't anyone around near the entrance, you can't even get access to it. When you need an AED, you just don't have time to waste looking for inaccessible AEDs.

If it's your only option, you may have a shot at an AED of unknown accessibility. But I hold that it should be visible on the map. Take for instance a secondary school in Blankenberge: its AED: is visible from the street, but the nearby entrance is never open and there's no front desk there. Around the corner in the Kerkstraat there's a 24/7 AED in an outdoor cabinet, and also nearby there's an AED intended for public use in a pub (though with unknown opening hours).

> I'm not really fond of this approach. Especially the multiple sizes/colours are quite unclear. I can imagine. It would need a legend. Tbh I also find it kind of messy like this. > Maybe we should use a 'lock'-icon, similar to the toilets? Perhaps a lock icon as well as using a grey icon for fast reference? > And, TBH, if someone is available in the "locked" venue, they'll probably lend it. True. But you first have to find someone and ask, which takes time. And if there isn't anyone around near the entrance, you can't even get access to it. When you need an AED, you just don't have time to waste looking for inaccessible AEDs. If it's your only option, you may have a shot at an AED of unknown accessibility. But I hold that it should be visible on the map. Take for instance a secondary school in Blankenberge: [its AED](https://mapcomplete.org/aed.html?z=16&lat=51.314121&lon=3.128649#node/3200411326): is visible from the street, but the nearby entrance is never open and there's no front desk there. Around the corner in the Kerkstraat there's a 24/7 AED in an outdoor cabinet, and also nearby there's an AED intended for public use in a pub (though with unknown opening hours).
midgard changed title from AED theme usability improvements to WIP: AED theme usability improvements 2024-12-26 18:19:49 +00:00
midgard added 1 commit 2025-02-19 21:17:43 +00:00
Themes(aed): un-differentiate icons, revise badges
All checks were successful
Deploy develop on dev.mapcomplete.org / deploy_on_hosted (pull_request) Successful in 34m32s
Details
ad221f35d1 
After brainstorming with Pieter
midgard commented 2025-02-19 21:18:30 +00:00
Author
Contributor
Copy link

Voilà, filters need a little bit more testing but then WIP can be removed and this can be merged

Voilà, filters need a little bit more testing but then WIP can be removed and this can be merged
pietervdvn approved these changes 2025-02-19 23:41:31 +00:00
pietervdvn changed title from WIP: AED theme usability improvements to AED theme usability improvements 2025-02-19 23:41:54 +00:00
pietervdvn commented 2025-02-20 10:09:32 +00:00
Owner
Copy link

Your changes are merged in via a rebase! Thank you for your contribution!

Your changes are merged in via a rebase! Thank you for your contribution!
pietervdvn closed this pull request 2025-02-20 10:09:33 +00:00
All checks were successful
Deploy develop on dev.mapcomplete.org / deploy_on_hosted (pull_request) Successful in 34m32s
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
pietervdvn
Labels
Clear labels   
Android-shell

Label for issues related to the android shell

  
awaiting feedback

We are waiting for the OP to get back to us, e.g. with an example

  
awaiting fix confirmation

We are waiting for OP to confirm that the fix worked for them (or will close when they don't reply)

  
bug

Something isn't working

  
enhancement

New feature or request

  
Help Wanted

Extra attention is needed

  
high-priority

It's urgent!

  
huge

A huge task, preferably to do with funding

  
low-priority

Might be fixed one day... or not

  
Meta

Something that cannot be fixed by code

  
NLNet

Will be developed, funded by NLNet

  
OSOC21:Cycling-OVL

A feature specific for this project

  
Performance

Make things faster or leaner

  
question

Further information is requested

  
search-ui-enhancement

Related to the search functionality

  
Studio

Graphical user interface to create or edit themes and layers

  
Tailwind

Something related to the CSS-framework

  
Themes

A new theme idea or improvement to an already existing theme

  
UI

Related to the user interface

  
upstream-issue

An issue that should be fixed in an upstram library

  
usertest

Issues surfaced during usertests

No labels
Android-shell
awaiting feedback
awaiting fix confirmation
bug
enhancement
Help Wanted
high-priority
huge
low-priority
Meta
NLNet
OSOC21:Cycling-OVL
Performance
question
search-ui-enhancement
Studio
Tailwind
Themes
UI
upstream-issue
usertest
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: MapComplete/MapComplete#2290
No description provided.
Delete branch "midgard/MapComplete:defibrillators"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?