Robin-van-der-Linde/MapComplete
1
0
Fork 0
forked from MapComplete/MapComplete
Code Pull requests Activity

Studio: fix failing detection, add error message after reddit post

Browse source
This commit is contained in:
Pieter Vander Vennet 2024-11-05 13:52:23 +01:00
parent 7677788a02
commit bd58adc373
2 changed files with 6 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/Logic/Tags/Tag.ts
View file

@ -170,8 +170,12 @@ export class Tag extends TagsFilter {
return <any>this
}
/**
* new Tag("panoramax", "").isNegative() // => true
* new Tag("x","y").isNegative() // => false
*/
isNegative(): boolean {
return false
return this.value === ""
}
visit(f: (tagsFilter: TagsFilter) => void) {

2
src/Models/ThemeConfig/Conversion/PrevalidateLayer.ts
View file

@ -69,7 +69,7 @@ export class PrevalidateLayer extends DesugaringStep<LayerConfigJson> {
context
.enters("source", "osmTags")
.err(
"The source states tags which give a very wide selection: it only uses negative expressions, which will result in too much and unexpected data. Add at least one required tag. The tags are:\n\t" +
"The tags that will be used to load data from OpenStreetMap are all negative - this means that they all match something that _doesn't_ have a certain tag. For example, `key=` means anything without `key`. Did you perhaps mean to use `key~*`, meaning anything _with_ this key set? The tags are:\n\t" +
osmTags.asHumanString(false, false, {})
)
}