AED theme - French translation #98

Merged

nlehuby merged 1 commit from aed_i18n into master

2020-08-24 20:26:16 +02:00

nlehuby commented

2020-08-24 19:29:27 +02:00

(Migrated from github.com)

I've tried to add the 🇫🇷 translation for the AED theme. Please let me know if it's the right way to do this.

I've tried to add the :fr: translation for the AED theme. Please let me know if it's the right way to do this.

pietervdvn commented

2020-08-24 20:26:38 +02:00

(Migrated from github.com)

Yes, it is!

Thanks a lot, this is awesome!
I really appreciate this :)

Yes, it is! Thanks a lot, this is awesome! I really appreciate this :)

pietervdvn commented

2020-08-24 20:33:09 +02:00

(Migrated from github.com)

I've deployed it as well, you can select your language now in the AED-map.

❤️ 1

nlehuby commented

2020-08-24 21:08:37 +02:00

(Migrated from github.com)

Thanks, that's so cool 👍

BTW, you may need to update the doc, I spent lots of times looking at this file looking for the strings to translate for the AED theme 😄
I also did not manage to test my changes locally: when I follow the instructions from the readme, I think it loads the bookcase theme only 🤔

Thanks, that's so cool :+1: BTW, you may need to update [the doc](https://github.com/pietervdvn/MapComplete#translating-mapcomplete), I spent lots of times looking at [this file](https://github.com/pietervdvn/MapComplete/blob/master/UI/i18n/Translations.ts) looking for the strings to translate for the AED theme :smile: I also did not manage to test my changes locally: when I follow the instructions from the [readme](https://github.com/pietervdvn/MapComplete#dev), I think it loads the bookcase theme only :thinking:

pietervdvn commented

2020-08-24 21:33:06 +02:00

(Migrated from github.com)

Yeah, the docs should be improved. The new preset-system based on JSON-files is brand-new (like a week old), that is why.

No reviewers

No labels

Rows
Columns