MapComplete/MapComplete
MapComplete/MapComplete
5
11
Fork 6
Code Issues 200 Pull requests 3 Releases Activity Actions

Etymology and Wikidata: remove street-type prefix from Italian addresses #2616

Merged
pietervdvn merged 2 commits from AlessioMela/MapComplete:develop into develop 2026-01-03 00:39:55 +00:00
Conversation 4 Commits 2 Files changed 1 +30
AlessioMela commented 2026-01-02 22:11:21 +00:00
Contributor
Copy link

This pull request adds a dictionary used to remove street-type prefixes (e.g. Via, Piazza, Viale) from Italian addresses in the Etymology layer for the Wikidata reconciliation suggester.
Thank you for your work on this project, this is my first contribution to this repository. Please let me know if there is anything else I should do.

This pull request adds a dictionary used to remove street-type prefixes (e.g. Via, Piazza, Viale) from Italian addresses in the Etymology layer for the Wikidata reconciliation suggester. Thank you for your work on this project, this is my first contribution to this repository. Please let me know if there is anything else I should do.
added prefix to be removed in Italian
Some checks failed
/ deploy_on_hosted (pull_request) Failing after 1m48s
Details
ea3f8248fa
pietervdvn reviewed 2026-01-03 00:06:43 +00:00
assets/layers/etymology/etymology.json Outdated
@ -202,2 +202,4 @@
"stade (des |de la |de l'|de |du |d')?",
"villa (des |de la |de l'|de |du |d')?"
],
it : [
pietervdvn commented 2026-01-03 00:06:43 +00:00
Owner
Copy link

There should be " around the it as well for this to be valid JSON.

There should be `"` around the `it` as well for this to be valid JSON.
pietervdvn requested changes 2026-01-03 00:07:29 +00:00
pietervdvn left a comment
Owner
Copy link

Looks great, except for a small syntax error. There should be a " around the it as well for this to be a valid JSON file, but that is the only thing that is wrong with it.

Looks great, except for a small syntax error. There should be a `"` around the `it` as well for this to be a valid JSON file, but that is the only thing that is wrong with it.
Fix syntax error
All checks were successful
/ deploy_on_hosted (pull_request) Successful in 27m3s
Details
9bce30e31e
pietervdvn commented 2026-01-03 00:08:24 +00:00
Owner
Copy link

Nvm, I've fixed it myself as that'll be faster

Nvm, I've fixed it myself as that'll be faster
❤️ 1
pietervdvn changed title from WIP: Etymology and Wikidata: remove street-type prefix from Italian addresses to Etymology and Wikidata: remove street-type prefix from Italian addresses 2026-01-03 00:08:26 +00:00
forgejo-actions commented 2026-01-03 00:34:57 +00:00
Copy link

Congratulations! This PR been successfully built and has been deployed. It is (temporarily) available on https://builds.mapcomplete.org/2616

Congratulations! This PR been successfully built and has been deployed. It is (temporarily) available on https://builds.mapcomplete.org/2616
pietervdvn merged commit 0975ba24e0 into develop 2026-01-03 00:39:55 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
pietervdvn
Labels
Clear labels   
Android-shell

Label for issues related to the android shell

  
awaiting feedback

We are waiting for the OP to get back to us, e.g. with an example

  
awaiting fix confirmation

We are waiting for OP to confirm that the fix worked for them (or will close when they don't reply)

  
bug

Something isn't working

  
enhancement

New feature or request

  
Help Wanted

Extra attention is needed

  
high-priority

It's urgent!

  
huge

A huge task, preferably to do with funding

  
low-priority

Might be fixed one day... or not

  
Meta

Something that cannot be fixed by code

  
NLNet

Will be developed, funded by NLNet

  
OSOC21:Cycling-OVL

A feature specific for this project

  
Performance

Make things faster or leaner

  
question

Further information is requested

  
search-ui-enhancement

Related to the search functionality

  
Studio

Graphical user interface to create or edit themes and layers

  
Tailwind

Something related to the CSS-framework

  
Themes

A new theme idea or improvement to an already existing theme

  
UI

Related to the user interface

  
upstream-issue

An issue that should be fixed in an upstram library

  
usertest

Issues surfaced during usertests

No labels
Android-shell
awaiting feedback
awaiting fix confirmation
bug
enhancement
Help Wanted
high-priority
huge
low-priority
Meta
NLNet
OSOC21:Cycling-OVL
Performance
question
search-ui-enhancement
Studio
Tailwind
Themes
UI
upstream-issue
usertest
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
MapComplete/MapComplete!2616
No description provided.