Uploading picture does not show neither success nor failure #2407
Labels
No labels
Android-shell
awaiting feedback
awaiting fix confirmation
bug
enhancement
Help Wanted
high-priority
huge
low-priority
Meta
NLNet
OSOC21:Cycling-OVL
Performance
question
search-ui-enhancement
Studio
Tailwind
Themes
UI
upstream-issue
usertest
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: MapComplete/MapComplete#2407
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
..and the picture does not show when image is closed and reopened -- but it still might be uploaded in some cases.
(ignore the fact that clicking on
Take a photoopen image picker instead, that is tracked in #2406; this issue happens with Firefox on desktop too)Video:
Possibly related to: #2342, #2404
It leads to duplicated pictures, e.g. https://www.openstreetmap.org/changeset/165588902 with https://www.openstreetmap.org/node/7700056749/history
Suggested resolution: MapComplete should always return whether the image taking and upload was successful (in green) or if it failed or didn't complete for some reason. It used to do that before IIRC (at least for success, see the image in #2342)?
note that it failure to display picture only happens randomly; i.e. few minutes after that one didn't show uploaded pictures, this one displayed it:
Note however that both the one that showed the picture, and the one that didn't show it didn't have that green "Your picture was successfully uploaded! Thank you!" which was present before.
This might have been a side-effect of #2404, I noticed the missing indicator too a few times (but didn't get around fixing it). A build fixing this is on the way (both prod/dev)
I will (probably) be field testing tomorrow, I'll get back to you then.
I think this should be fixed, would you mind confirming @mnalis ?
When an upload fails, it is still reported as "uploading"
Hm, it still seems to not be visible sometimes (but sometimes that uploading is visible normally), see e.g. in video below - no upload progress is shown at all after I upload a picture, not even when I answer several radio-button answers. Only when I closed the element fully, did I see that there were apparently hidden windows "below" the visible one, showing progress.
And sometimes I see the uploading progress normally as soon as I take a picture; so it only seems to happen sometimes
Hypothesis:
Image is uploaded and linked against "node/-1". In the meantime, "node/-1" is uploaded and the id changes into "node/123456". The image will then not be linked and the "uploading" bar will not show up. So, the progress bar which sometimes doesn't show up is a symptom of this same bug.