manifest broken

thibaultmol commented

2023-02-04 18:35:52 +01:00

(Migrated from github.com)

because of the vite change probably

thibaultmol commented

2023-02-09 18:24:59 +01:00

(Migrated from github.com)

Just fyi, adding develop as pwa still doesn't show favicon from the manifest

![Screenshot_20230209_182412_One UI Home](https://user-images.githubusercontent.com/1010226/217890489-528bcf0e-3af9-4529-9f3f-8e7ea9f6c61e.jpg) Just fyi, adding develop as pwa still doesn't show favicon from the manifest

pietervdvn commented

2023-02-09 23:46:49 +01:00

(Migrated from github.com)

Can you do a few refreshes? It should work now

thibaultmol commented

2023-02-10 07:25:29 +01:00

(Migrated from github.com)

I have done many

thibaultmol commented

2023-02-16 20:23:38 +01:00

(Migrated from github.com)

@pietervdvn fyi, I'm still having this issue

pietervdvn commented

2023-02-26 17:43:45 +01:00

(Migrated from github.com)

As it turns out, the service-worker was broken as well. The service worker aggressively caches a certain version of MapComplete. As it was broken, it would effectively serve an old version, hence the earlier fix would not be applied on your phone.

I'm now merging the develop branch onto master. Would you mind to validate that it works (might need at most 2 refreshes) and close the issue if it works now?

As it turns out, the service-worker was broken as well. The service worker aggressively caches a certain version of MapComplete. As it was broken, it would effectively serve an old version, hence the earlier fix would not be applied on your phone. I'm now merging the develop branch onto master. Would you mind to validate that it works (might need at most 2 refreshes) and close the issue if it works now?

thibaultmol commented

2023-03-04 10:29:30 +01:00

(Migrated from github.com)

When going to mapcomplete.osm.be. The prompt to install the pwa does come up. Installs correctly.

GitHub.io version doesn't seem to show the prompt and if you install it, doesn't actually install as a pwa. Just a bookmark

(Retyped this comment. Cause previous one I typed half asleep it seemed XD)

When going to mapcomplete.osm.be. The prompt to install the pwa does come up. Installs correctly. GitHub.io version doesn't seem to show the prompt and if you install it, doesn't actually install as a pwa. Just a bookmark (Retyped this comment. Cause previous one I typed half asleep it seemed XD)

thibaultmol commented

2023-03-04 10:30:24 +01:00

(Migrated from github.com)

NEVER MIND, I'm not sure what I did differently. But it didn't work 5 minutes ago and now it does. Issue solved

thibaultmol commented

2023-03-04 10:31:45 +01:00

(Migrated from github.com)

One question though: should the develop version maybe say (develop) in the app title to separate it from the osm.be hosted one?

If that's even possible

One question though: should the develop version maybe say (develop) in the app title to separate it from the osm.be hosted one? If that's even possible

pietervdvn commented

2023-03-04 12:21:46 +01:00

(Migrated from github.com)

NEVER MIND, I'm not sure what I did differently. But it didn't work 5 minutes ago and now it does. Issue solved

As the servixe workers caches aggressively, you probably had the old version while the SW updated in the background.

One question though: should the develop version maybe say (develop) in the app title to separate it from the osm.be hosted one?

That's something I did consider, just didn't get implemented yet.

> NEVER MIND, I'm not sure what I did differently. But it didn't work 5 minutes ago and now it does. Issue solved As the servixe workers caches aggressively, you probably had the old version while the SW updated in the background. > One question though: should the develop version maybe say (develop) in the app title to separate it from the osm.be hosted one? That's something I did consider, just didn't get implemented yet.

Rows
Columns

manifest broken #1293