midgard/MapComplete
1
0
Fork 0
forked from MapComplete/MapComplete
Code Pull requests Activity

Fix various small issues to the teams, add some more validation

Browse source
This commit is contained in:
Pieter Vander Vennet 2022-07-20 22:57:39 +02:00
parent a4b51b63ca
commit f63f62922e
14 changed files with 65 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

9
Models/ThemeConfig/Conversion/Validation.ts
View file

@ -521,8 +521,13 @@ export class ValidateLayer extends DesugaringStep<LayerConfigJson> {
}
}
if(json.title === undefined && json.tagRenderings !== undefined){
warnings.push(context + ": this layer does not have a title defined but it does have tagRenderings. Not having a title will disable the popups, resulting in an unclickable element.")
if(json.tagRenderings !== undefined && json.tagRenderings.length > 0){
if(json.title === undefined){
errors.push(context + ": this layer does not have a title defined but it does have tagRenderings. Not having a title will disable the popups, resulting in an unclickable element. Please add a title. If not having a popup is intended and the tagrenderings need to be kept (e.g. in a library layer), set `title: null` to disable this error.")
}
if(json.title === null){
information.push(context + ": title is `null`. This results in an element that cannot be clicked - even though tagRenderings is set.")
}
}
if (json["builtin"] !== undefined) {