midgard/MapComplete
1
0
Fork 0
forked from MapComplete/MapComplete
Code Pull requests Activity

Fix last untranslated strings, make these errors again

Browse source
This commit is contained in:
Pieter Vander Vennet 2022-02-16 22:18:58 +01:00
parent 07823087e1
commit b9ff8667a9
5 changed files with 33 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

7
Models/ThemeConfig/Conversion/Validation.ts
View file

@ -30,7 +30,7 @@ class ValidateLanguageCompleteness extends DesugaringStep<any> {
translations
.filter(t => t.tr.translations[neededLanguage] === undefined && t.tr.translations["*"] === undefined)
.forEach(missing => {
errors.push(context + "A theme should be translation-complete for " + neededLanguage + ", but it lacks a translation for " + missing.context + ".\n\tThe english translation is " + missing.tr.textFor('en'))
errors.push(context + "A theme should be translation-complete for " + neededLanguage + ", but it lacks a translation for " + missing.context + ".\n\tThe known translation is " + missing.tr.textFor('en'))
})
}
@ -138,10 +138,11 @@ class ValidateTheme extends DesugaringStep<LayoutConfigJson> {
.convert(theme, theme.id)
errors.push(...checked.errors)
}
if(!json.hideFromOverview){
if(!json.hideFromOverview && theme.id !== "personal"){
// Official, public themes must have a full english translation
const checked = new ValidateLanguageCompleteness("en")
.convert(theme, theme.id)
warnings.push(...checked.errors)
errors.push(...checked.errors)
}
} catch (e) {