Refactoring: improve special components

This commit is contained in:
Pieter Vander Vennet 2023-04-24 03:36:02 +02:00
parent fcc49766d4
commit 94635337e6
4 changed files with 16 additions and 23 deletions

View file

@ -76,7 +76,7 @@ export default class InputHelpers {
mapProperties = { ...mapProperties, location }
}
let zoom = 17
if (properties.args[0]) {
if (properties?.args?.[0] !== undefined) {
zoom = Number(properties.args[0])
if (isNaN(zoom)) {
throw "Invalid zoom level for argument at 'length'-input"

View file

@ -10,7 +10,7 @@
export let value: UIEventSource<string>;
// Internal state, only copied to 'value' so that no invalid values leak outside
let _value = new UIEventSource(value.data ?? "");
onDestroy(value.addCallbackAndRun(v => _value.setData(v ?? "")));
onDestroy(value.addCallbackAndRunD(v => _value.setData(v ?? "")));
export let type: ValidatorType;
let validator = Validators.get(type);
export let feedback: UIEventSource<Translation> | undefined = undefined;
@ -34,12 +34,8 @@
let dispatch = createEventDispatcher<{ selected }>();
$: {
console.log(htmlElem);
if (htmlElem !== undefined) {
htmlElem.onfocus = () => {
console.log("Dispatching selected event");
return dispatch("selected");
};
htmlElem.onfocus = () => dispatch("selected");
}
}
</script>

View file

@ -10,6 +10,11 @@ export default class DateValidator extends Validator {
}
reformat(str: string) {
console.log("Reformatting", str)
if (!this.isValid(str)) {
// The date is invalid - we return the string as is
return str
}
const d = new Date(str)
let month = "" + (d.getMonth() + 1)
let day = "" + d.getDate()