Fix opening of various views when set by url-parameters, small styling tweaks in the popups

Logic/Actors/SelectedFeatureHandler.ts

@@ -10,7 +10,7 @@ import LayoutConfig from "../../Models/ThemeConfig/LayoutConfig";
  * Makes sure the hash shows the selected element and vice-versa.
  */
 export default class SelectedFeatureHandler {
-    private static readonly _no_trigger_on = new Set(["welcome", "copyright", "layers", "new", "", undefined])
+    private static readonly _no_trigger_on = new Set(["welcome", "copyright", "layers", "new", "filter","", undefined])
     private readonly hash: UIEventSource<string>;
     private readonly state: {
         selectedElement: UIEventSource<any>,
@@ -70,7 +70,7 @@ export default class SelectedFeatureHandler {
         this.initialLoad()
 
     }
-    
+
 
     /**
      * On startup: check if the hash is loaded and eventually zoom to it
@@ -85,6 +85,11 @@ export default class SelectedFeatureHandler {
             return;
         }
 
+        if (!(hash.startsWith("node") || hash.startsWith("way") || hash.startsWith("relation"))) {
+            return;
+        }
+     
+
         OsmObject.DownloadObjectAsync(hash).then(obj => {
 
             try {
@@ -129,26 +134,25 @@ export default class SelectedFeatureHandler {
 
     // If a feature is selected via the hash, zoom there
     private zoomToSelectedFeature() {
-        
+
         const selected = this.state.selectedElement.data
-        if(selected === undefined){
+        if (selected === undefined) {
             return
         }
-        
-        const centerpoint= GeoOperations.centerpointCoordinates(selected)
+
+        const centerpoint = GeoOperations.centerpointCoordinates(selected)
         const location = this.state.locationControl;
         location.data.lon = centerpoint[0]
         location.data.lat = centerpoint[1]
-        
+
         const minZoom = Math.max(14, ...(this.state.layoutToUse?.layers?.map(l => l.minzoomVisible) ?? []))
-        if(location.data.zoom < minZoom  ){
+        if (location.data.zoom < minZoom) {
             location.data.zoom = minZoom
         }
-        
+
         location.ping();
-        
-        
-  
+
+
     }
 
 }

Logic/State/FeatureSwitchState.ts

@@ -144,31 +144,20 @@ export default class FeatureSwitchState {
         }
 
 
-        this.featureSwitchIsTesting = QueryParameters.GetQueryParameter(
+        this.featureSwitchIsTesting = QueryParameters.GetBooleanQueryParameter(
             "test",
             ""+testingDefaultValue,
             "If true, 'dryrun' mode is activated. The app will behave as normal, except that changes to OSM will be printed onto the console instead of actually uploaded to osm.org"
-        ).map(
-            (str) => str === "true",
-            [],
-            (b) => "" + b
-        );
+        )
 
-        this.featureSwitchIsDebugging = QueryParameters.GetQueryParameter(
+        this.featureSwitchIsDebugging = QueryParameters.GetBooleanQueryParameter(
             "debug",
             "false",
             "If true, shows some extra debugging help such as all the available tags on every object"
-        ).map(
-            (str) => str === "true",
-            [],
-            (b) => "" + b
-        );
+        )
 
-        this.featureSwitchFakeUser = QueryParameters.GetQueryParameter("fake-user", "false",
+        this.featureSwitchFakeUser = QueryParameters.GetBooleanQueryParameter("fake-user", "false",
             "If true, 'dryrun' mode is activated and a fake user account is loaded")
-            .map(str => str === "true", [], b => "" + b);
-
-
       
 
         this.overpassUrl = QueryParameters.GetQueryParameter("overpassUrl",

Logic/State/MapState.ts

@@ -119,7 +119,7 @@ export default class MapState extends UserRelatedState {
 
         this.overlayToggles = this.layoutToUse.tileLayerSources.filter(c => c.name !== undefined).map(c => ({
             config: c,
-            isDisplayed: QueryParameters.GetQueryParameter("overlay-" + c.id, "" + c.defaultState, "Wether or not the overlay " + c.id + " is shown").map(str => str === "true", [], b => "" + b)
+            isDisplayed: QueryParameters.GetBooleanQueryParameter("overlay-" + c.id, "" + c.defaultState, "Wether or not the overlay " + c.id + " is shown")
         }))
         this.filteredLayers = this.InitializeFilteredLayers()
 
@@ -170,17 +170,12 @@ export default class MapState extends UserRelatedState {
                     .map(value => value === "yes", [], enabled => {
                         return enabled ? "yes" : "";
                     })
-                isDisplayed.addCallbackAndRun(d => console.log("IsDisplayed for layer", layer.id, "is currently", d))
             } else {
-                isDisplayed = QueryParameters.GetQueryParameter(
+                isDisplayed = QueryParameters.GetBooleanQueryParameter(
                     "layer-" + layer.id,
                     "true",
                     "Wether or not layer " + layer.id + " is shown"
-                ).map<boolean>(
-                    (str) => str !== "false",
-                    [],
-                    (b) => b.toString()
-                );
+                )
             }
             const flayer = {
                 isDisplayed: isDisplayed,

Logic/Web/QueryParameters.ts

@@ -55,6 +55,10 @@ export class QueryParameters {
         return source;
     }
 
+    public static GetBooleanQueryParameter(key: string, deflt: string, documentation?: string): UIEventSource<boolean>{
+        return QueryParameters.GetQueryParameter(key, deflt, documentation).map(str => str === "true", [], b => ""+b)
+    }
+
     public static GenerateQueryParameterDocs(): string {
         const docs = [QueryParameters.QueryParamDocsIntro];
         for (const key in QueryParameters.documentation) {