More refactoring, stabilizing rotation and direction_gradient

UI/Popup/EditableTagRendering.ts

@@ -9,8 +9,8 @@ import State from "../../State";
 import Svg from "../../Svg";
 
 export default class EditableTagRendering extends UIElement {
-    private _tags: UIEventSource<any>;
-    private _configuration: TagRenderingConfig;
+    private readonly _tags: UIEventSource<any>;
+    private readonly _configuration: TagRenderingConfig;
 
     private _editMode: UIEventSource<boolean> = new UIEventSource<boolean>(false);
     private _editButton: UIElement;

UI/Popup/FeatureInfoBox.ts

@@ -8,14 +8,14 @@ import TagRenderingAnswer from "./TagRenderingAnswer";
 import State from "../../State";
 import {FixedUiElement} from "../Base/FixedUiElement";
 
-export class FeatureInfoBox extends UIElement {
+export default class FeatureInfoBox extends UIElement {
     private _tags: UIEventSource<any>;
     private _layerConfig: LayerConfig;
 
-    private _title : UIElement;
+    private _title: UIElement;
     private _titleIcons: UIElement;
     private _renderings: UIElement[];
-    private _questionBox : UIElement;
+    private _questionBox: UIElement;
 
     constructor(
         tags: UIEventSource<any>,
@@ -35,15 +35,15 @@ export class FeatureInfoBox extends UIElement {
         this._titleIcons = new Combine(
             layerConfig.titleIcons.map(icon => new TagRenderingAnswer(tags, icon)))
             .SetClass("featureinfobox-icons");
-        
-        let questionBox : UIElement = undefined;
+
+        let questionBox: UIElement = undefined;
         if (State.state.featureSwitchUserbadge.data) {
             questionBox = new QuestionBox(tags, layerConfig.tagRenderings);
         }
-        
+
         let questionBoxIsUsed = false;
         this._renderings = layerConfig.tagRenderings.map(tr => {
-            if(tr.question === null){
+            if (tr.question === null) {
                 questionBoxIsUsed = true;
                 // This is the question box!
                 return questionBox;
@@ -51,9 +51,9 @@ export class FeatureInfoBox extends UIElement {
             return new EditableTagRendering(tags, tr);
         });
         this._renderings[0]?.SetClass("first-rendering");
-       if(!questionBoxIsUsed){
-           this._renderings.push(questionBox);
-       }
+        if (!questionBoxIsUsed) {
+            this._renderings.push(questionBox);
+        }
     }
 
     InnerRender(): string {

UI/Popup/QuestionBox.ts

@@ -9,9 +9,9 @@ import Translations from "../i18n/Translations";
  * Generates all the questions, one by one
  */
 export default class QuestionBox extends UIElement {
-    private _tags: UIEventSource<any>;
+    private readonly _tags: UIEventSource<any>;
 
-    private _tagRenderings: TagRenderingConfig[];
+    private readonly _tagRenderings: TagRenderingConfig[];
     private _tagRenderingQuestions: UIElement[];
 
     private _skippedQuestions: UIEventSource<number[]> = new UIEventSource<number[]>([])

UI/Popup/SaveButton.ts

@@ -1,7 +1,7 @@
 import {UIEventSource} from "../../Logic/UIEventSource";
 import {UIElement} from "../UIElement";
 import Translations from "../i18n/Translations";
-import {OsmConnection, UserDetails} from "../../Logic/Osm/OsmConnection";
+import UserDetails, {OsmConnection} from "../../Logic/Osm/OsmConnection";
 
 export class SaveButton extends UIElement {
 

UI/Popup/TagRenderingAnswer.ts

@@ -7,7 +7,7 @@ import {SubstitutedTranslation} from "../SpecialVisualizations";
  * Displays the correct value for a known tagrendering
  */
 export default class TagRenderingAnswer extends UIElement {
-    private _tags: UIEventSource<any>;
+    private readonly _tags: UIEventSource<any>;
     private _configuration: TagRenderingConfig;
     private _content: UIElement;
 

UI/Popup/TagRenderingQuestion.ts

@@ -25,7 +25,7 @@ import Constants from "../../Models/Constants";
  * Note that the value _migh_ already be known, e.g. when selected or when changing the value
  */
 export default class TagRenderingQuestion extends UIElement {
-    private _tags: UIEventSource<any>;
+    private readonly _tags: UIEventSource<any>;
     private _configuration: TagRenderingConfig;
 
     private _saveButton: UIElement;