midgard/MapComplete
1
0
Fork 0
forked from MapComplete/MapComplete
Code Pull requests Activity

Fix bug where metatagging would not fully calculate in some cases

Browse source
This commit is contained in:
Pieter Vander Vennet 2021-10-04 00:18:08 +02:00
parent 27a43fdbe0
commit 65470cbac5
8 changed files with 34 additions and 20 deletions
Download patch file Download diff file Expand all files Collapse all files

10
Logic/MetaTagging.ts
View file

@ -61,7 +61,15 @@ export default class MetaTagging {
// All keys are already defined, we probably already ran this one
continue
}
somethingChanged = somethingChanged || metatag.applyMetaTagsOnFeature(feature, freshness)
const newValueAdded = metatag.applyMetaTagsOnFeature(feature, freshness)
/* Note that the expression:
* `somethingChanged = newValueAdded || metatag.applyMetaTagsOnFeature(feature, freshness)`
* Is WRONG
*
* IF something changed is `true` due to an earlier run, it will short-circuit and _not_ evaluate the right hand of the OR,
* thus not running an update!
*/
somethingChanged = newValueAdded || somethingChanged
} catch (e) {
console.error("Could not calculate metatag for ", metatag.keys.join(","), ":", e, e.stack)
}