Chore: fix warnings

Logic/Actors/BackgroundLayerResetter.ts

@@ -1,10 +1,6 @@
-import { Store, UIEventSource } from "../UIEventSource"
-import { Utils } from "../../Utils"
-import {
-    AvailableRasterLayers,
-    RasterLayerPolygon,
-    RasterLayerUtils,
-} from "../../Models/RasterLayers"
+import {Store, UIEventSource} from "../UIEventSource"
+import {Utils} from "../../Utils"
+import {RasterLayerPolygon, RasterLayerUtils,} from "../../Models/RasterLayers"
 
 /**
  * When a user pans around on the map, they might pan out of the range of the current background raster layer.

Logic/FeatureSource/Actors/FeaturePropertiesStore.ts

@@ -1,5 +1,5 @@
-import { FeatureSource, IndexedFeatureSource } from "../FeatureSource"
-import { UIEventSource } from "../../UIEventSource"
+import {FeatureSource} from "../FeatureSource"
+import {UIEventSource} from "../../UIEventSource"
 
 /**
  * Constructs a UIEventStore for the properties of every Feature, indexed by id

Logic/FeatureSource/FeatureSource.ts

@@ -1,6 +1,5 @@
 import { Store, UIEventSource } from "../UIEventSource"
 import FilteredLayer from "../../Models/FilteredLayer"
-import { BBox } from "../BBox"
 import { Feature } from "geojson"
 
 export interface FeatureSource<T extends Feature = Feature> {

Logic/ImageProviders/WikidataImageProvider.ts

@@ -12,8 +12,8 @@ export class WikidataImageProvider extends ImageProvider {
         super()
     }
 
-    public SourceIcon(backlinkSource?: string): BaseUIElement {
-        throw Svg.wikidata_svg()
+    public SourceIcon(_?: string): BaseUIElement {
+        return Svg.wikidata_svg()
     }
 
     public async ExtractUrls(key: string, value: string): Promise<Promise<ProvidedImage>[]> {
@@ -48,7 +48,7 @@ export class WikidataImageProvider extends ImageProvider {
         return allImages
     }
 
-    public DownloadAttribution(url: string): Promise<any> {
+    public DownloadAttribution(_: string): Promise<any> {
         throw new Error("Method not implemented; shouldn't be needed!")
     }
 }

Logic/ImageProviders/WikimediaImageProvider.ts

@@ -80,7 +80,6 @@ export class WikimediaImageProvider extends ImageProvider {
     }
 
     public PrepUrl(value: string): ProvidedImage {
-        const hasCommonsPrefix = WikimediaImageProvider.startsWithCommonsPrefix(value)
         value = WikimediaImageProvider.removeCommonsPrefix(value)
 
         if (value.startsWith("File:")) {

Logic/Osm/Actions/ChangeLocationAction.ts

@@ -1,6 +1,5 @@
 import { ChangeDescription } from "./ChangeDescription"
 import OsmChangeAction from "./OsmChangeAction"
-import { Changes } from "../Changes"
 
 export default class ChangeLocationAction extends OsmChangeAction {
     private readonly _id: number

Logic/Osm/Actions/ChangeTagAction.ts

@@ -1,5 +1,4 @@
 import OsmChangeAction from "./OsmChangeAction"
-import { Changes } from "../Changes"
 import { ChangeDescription } from "./ChangeDescription"
 import { TagsFilter } from "../../Tags/TagsFilter"
 import { OsmTags } from "../../../Models/OsmFeature"

Logic/Osm/Actions/CreateNewWayAction.ts

@@ -1,9 +1,9 @@
-import { ChangeDescription } from "./ChangeDescription"
-import {OsmCreateAction, PreviewableAction} from "./OsmChangeAction"
-import { Changes } from "../Changes"
-import { Tag } from "../../Tags/Tag"
+import {ChangeDescription} from "./ChangeDescription"
+import {OsmCreateAction} from "./OsmChangeAction"
+import {Changes} from "../Changes"
+import {Tag} from "../../Tags/Tag"
 import CreateNewNodeAction from "./CreateNewNodeAction"
-import { And } from "../../Tags/And"
+import {And} from "../../Tags/And"
 
 export default class CreateNewWayAction extends OsmCreateAction {
     public newElementId: string = undefined

Logic/Osm/Actions/SplitAction.ts

@@ -1,10 +1,10 @@
-import { OsmObject, OsmWay } from "../OsmObject"
-import { Changes } from "../Changes"
-import { GeoOperations } from "../../GeoOperations"
+import {OsmWay} from "../OsmObject"
+import {Changes} from "../Changes"
+import {GeoOperations} from "../../GeoOperations"
 import OsmChangeAction from "./OsmChangeAction"
-import { ChangeDescription } from "./ChangeDescription"
+import {ChangeDescription} from "./ChangeDescription"
 import RelationSplitHandler from "./RelationSplitHandler"
-import { Feature, LineString } from "geojson"
+import {Feature, LineString} from "geojson"
 import OsmObjectDownloader from "../OsmObjectDownloader"
 
 interface SplitInfo {

Logic/Osm/OsmConnection.ts

@@ -2,7 +2,6 @@ import osmAuth from "osm-auth"
 import { Store, Stores, UIEventSource } from "../UIEventSource"
 import { OsmPreferences } from "./OsmPreferences"
 import { Utils } from "../../Utils"
-import { OsmObject } from "./OsmObject"
 
 export default class UserDetails {
     public loggedIn = false

Logic/SimpleMetaTagger.ts

@@ -10,7 +10,6 @@ import { CountryCoder } from "latlon2country"
 import Constants from "../Models/Constants"
 import { TagUtils } from "./Tags/TagUtils"
 import { Feature, LineString } from "geojson"
-import { OsmObject } from "./Osm/OsmObject"
 import { OsmTags } from "../Models/OsmFeature"
 import { UIEventSource } from "./UIEventSource"
 import LayoutConfig from "../Models/ThemeConfig/LayoutConfig"

Logic/UIEventSource.ts

@@ -264,10 +264,8 @@ export abstract class Store<T> implements Readable<T> {
 
     /**
      * Same as 'addCallbackAndRun', added to be compatible with Svelte
-     * @param run
-     * @param invalidate
      */
-    public subscribe(run: Subscriber<T> & ((value: T) => void), invalidate?): Unsubscriber {
+    public subscribe(run: Subscriber<T> & ((value: T) => void), _?): Unsubscriber {
         // We don't need to do anything with 'invalidate', see
         // https://github.com/sveltejs/svelte/issues/3859
 
@@ -288,7 +286,7 @@ export class ImmutableStore<T> extends Store<T> {
         this.data = data
     }
 
-    addCallback(callback: (data: T) => void): () => void {
+    addCallback(_: (data: T) => void): () => void {
         // pass: data will never change
         return ImmutableStore.pass
     }
@@ -307,7 +305,7 @@ export class ImmutableStore<T> extends Store<T> {
         return ImmutableStore.pass
     }
 
-    addCallbackD(callback: (data: T) => void): () => void {
+    addCallbackD(_: (data: T) => void): () => void {
         // pass: data will never change
         return ImmutableStore.pass
     }