refactoring: fix basic flow to add a new point

Logic/Osm/Actions/CreateMultiPolygonWithPointReuseAction.ts

@@ -7,7 +7,7 @@ import CreateWayWithPointReuseAction, { MergePointConfig } from "./CreateWayWith
 import { And } from "../../Tags/And"
 import { TagUtils } from "../../Tags/TagUtils"
 import { SpecialVisualizationState } from "../../../UI/SpecialVisualization"
-import FeatureSource from "../../FeatureSource/FeatureSource"
+import { FeatureSource } from "../../FeatureSource/FeatureSource"
 
 /**
  * More or less the same as 'CreateNewWay', except that it'll try to reuse already existing points

Logic/Osm/Actions/CreateNewNodeAction.ts

@@ -104,9 +104,13 @@ export default class CreateNewNodeAction extends OsmCreateAction {
         // Project the point onto the way
         console.log("Snapping a node onto an existing way...")
         const geojson = this._snapOnto.asGeoJson()
-        const projected = GeoOperations.nearestPoint(geojson, [this._lon, this._lat])
+        const projected = GeoOperations.nearestPoint(GeoOperations.outerRing(geojson), [
+            this._lon,
+            this._lat,
+        ])
         const projectedCoor = <[number, number]>projected.geometry.coordinates
         const index = projected.properties.index
+        console.log("Attempting to snap:", { geojson, projected, projectedCoor, index })
         // We check that it isn't close to an already existing point
         let reusedPointId = undefined
         let outerring: [number, number][]

Logic/Osm/Actions/CreateWayWithPointReuseAction.ts

@@ -5,7 +5,7 @@ import { ChangeDescription } from "./ChangeDescription"
 import { BBox } from "../../BBox"
 import { TagsFilter } from "../../Tags/TagsFilter"
 import { GeoOperations } from "../../GeoOperations"
-import FeatureSource from "../../FeatureSource/FeatureSource"
+import { FeatureSource } from "../../FeatureSource/FeatureSource"
 import StaticFeatureSource from "../../FeatureSource/Sources/StaticFeatureSource"
 import CreateNewNodeAction from "./CreateNewNodeAction"
 import CreateNewWayAction from "./CreateNewWayAction"

Logic/Osm/Actions/ReplaceGeometryAction.ts

@@ -2,7 +2,7 @@ import OsmChangeAction from "./OsmChangeAction"
 import { Changes } from "../Changes"
 import { ChangeDescription } from "./ChangeDescription"
 import { Tag } from "../../Tags/Tag"
-import FeatureSource from "../../FeatureSource/FeatureSource"
+import { FeatureSource } from "../../FeatureSource/FeatureSource"
 import { OsmNode, OsmObject, OsmWay } from "../OsmObject"
 import { GeoOperations } from "../../GeoOperations"
 import StaticFeatureSource from "../../FeatureSource/Sources/StaticFeatureSource"

Logic/Osm/Changes.ts

@@ -6,7 +6,7 @@ import { ChangeDescription, ChangeDescriptionTools } from "./Actions/ChangeDescr
 import { Utils } from "../../Utils"
 import { LocalStorageSource } from "../Web/LocalStorageSource"
 import SimpleMetaTagger from "../SimpleMetaTagger"
-import FeatureSource, { IndexedFeatureSource } from "../FeatureSource/FeatureSource"
+import {FeatureSource, IndexedFeatureSource } from "../FeatureSource/FeatureSource"
 import { GeoLocationPointProperties } from "../State/GeoLocationState"
 import { GeoOperations } from "../GeoOperations"
 import { ChangesetHandler, ChangesetTag } from "./ChangesetHandler"

Logic/Osm/OsmConnection.ts

@@ -368,7 +368,7 @@ export class OsmConnection {
             "Content-Type": "application/json",
         })
         const parsed = JSON.parse(response)
-        const id = parsed.properties.id
+        const id = parsed.properties
         console.log("OPENED NOTE", id)
         return id
     }

Logic/Osm/OsmObject.ts

@@ -73,7 +73,8 @@ export abstract class OsmObject {
         if (rawData["error"] !== undefined && rawData["statuscode"] === 410) {
             return "deleted"
         }
-        return rawData["content"].elements[0].tags
+        // Tags is undefined if the element does not have any tags
+        return rawData["content"].elements[0].tags ?? {}
     }
 
     static async DownloadObjectAsync(