forked from MapComplete/MapComplete
		
	Merge develop
This commit is contained in:
		
						commit
						f0823f4c4d
					
				
					 524 changed files with 18747 additions and 8546 deletions
				
			
		|  | @ -9,12 +9,17 @@ import { | |||
|     DoesImageExist, | ||||
|     PrevalidateTheme, | ||||
|     ValidateLayer, | ||||
|     ValidateThemeAndLayers, ValidateThemeEnsemble, | ||||
|     ValidateThemeAndLayers, | ||||
|     ValidateThemeEnsemble, | ||||
| } from "../src/Models/ThemeConfig/Conversion/Validation" | ||||
| import { Translation } from "../src/UI/i18n/Translation" | ||||
| import { PrepareLayer } from "../src/Models/ThemeConfig/Conversion/PrepareLayer" | ||||
| import { PrepareTheme } from "../src/Models/ThemeConfig/Conversion/PrepareTheme" | ||||
| import { Conversion, DesugaringContext, DesugaringStep } from "../src/Models/ThemeConfig/Conversion/Conversion" | ||||
| import { | ||||
|     Conversion, | ||||
|     DesugaringContext, | ||||
|     DesugaringStep, | ||||
| } from "../src/Models/ThemeConfig/Conversion/Conversion" | ||||
| import { Utils } from "../src/Utils" | ||||
| import Script from "./Script" | ||||
| import { AllSharedLayers } from "../src/Customizations/AllSharedLayers" | ||||
|  | @ -49,7 +54,7 @@ class ParseLayer extends Conversion< | |||
| 
 | ||||
|     convert( | ||||
|         path: string, | ||||
|         context: ConversionContext, | ||||
|         context: ConversionContext | ||||
|     ): { | ||||
|         parsed: LayerConfig | ||||
|         raw: LayerConfigJson | ||||
|  | @ -65,7 +70,7 @@ class ParseLayer extends Conversion< | |||
|         try { | ||||
|             parsed = JSON.parse(fileContents) | ||||
|         } catch (e) { | ||||
|             context.err("Could not parse file as JSON") | ||||
|             context.err("Could not parse file as JSON: " + e) | ||||
|             return undefined | ||||
|         } | ||||
|         if (parsed === undefined) { | ||||
|  | @ -104,7 +109,7 @@ class AddIconSummary extends DesugaringStep<{ raw: LayerConfigJson; parsed: Laye | |||
|         const fixed = json.raw | ||||
|         const layerConfig = json.parsed | ||||
|         const pointRendering: PointRenderingConfig = layerConfig.mapRendering.find((pr) => | ||||
|             pr.location.has("point"), | ||||
|             pr.location.has("point") | ||||
|         ) | ||||
|         const defaultTags = layerConfig.GetBaseTags() | ||||
|         fixed["_layerIcon"] = Utils.NoNull( | ||||
|  | @ -119,13 +124,12 @@ class AddIconSummary extends DesugaringStep<{ raw: LayerConfigJson; parsed: Laye | |||
|                     result["color"] = c | ||||
|                 } | ||||
|                 return result | ||||
|             }), | ||||
|             }) | ||||
|         ) | ||||
|         return { raw: fixed, parsed: layerConfig } | ||||
|     } | ||||
| } | ||||
| 
 | ||||
| 
 | ||||
| class LayerOverviewUtils extends Script { | ||||
|     public static readonly layerPath = "./src/assets/generated/layers/" | ||||
|     public static readonly themePath = "./src/assets/generated/themes/" | ||||
|  | @ -142,7 +146,7 @@ class LayerOverviewUtils extends Script { | |||
| 
 | ||||
|     private static extractLayerIdsFrom( | ||||
|         themeFile: LayoutConfigJson, | ||||
|         includeInlineLayers = true, | ||||
|         includeInlineLayers = true | ||||
|     ): string[] { | ||||
|         const publicLayerIds = [] | ||||
|         if (!Array.isArray(themeFile.layers)) { | ||||
|  | @ -205,10 +209,10 @@ class LayerOverviewUtils extends Script { | |||
|                 | LayerConfigJson | ||||
|                 | string | ||||
|                 | { | ||||
|                 builtin | ||||
|             } | ||||
|                 )[] | ||||
|         }[], | ||||
|                       builtin | ||||
|                   } | ||||
|             )[] | ||||
|         }[] | ||||
|     ) { | ||||
|         const perId = new Map<string, any>() | ||||
|         for (const theme of themes) { | ||||
|  | @ -249,7 +253,7 @@ class LayerOverviewUtils extends Script { | |||
|         writeFileSync( | ||||
|             "./src/assets/generated/theme_overview.json", | ||||
|             JSON.stringify(sorted, null, "  "), | ||||
|             { encoding: "utf8" }, | ||||
|             { encoding: "utf8" } | ||||
|         ) | ||||
|     } | ||||
| 
 | ||||
|  | @ -261,7 +265,7 @@ class LayerOverviewUtils extends Script { | |||
|         writeFileSync( | ||||
|             `${LayerOverviewUtils.themePath}${theme.id}.json`, | ||||
|             JSON.stringify(theme, null, "  "), | ||||
|             { encoding: "utf8" }, | ||||
|             { encoding: "utf8" } | ||||
|         ) | ||||
|     } | ||||
| 
 | ||||
|  | @ -272,13 +276,13 @@ class LayerOverviewUtils extends Script { | |||
|         writeFileSync( | ||||
|             `${LayerOverviewUtils.layerPath}${layer.id}.json`, | ||||
|             JSON.stringify(layer, null, "  "), | ||||
|             { encoding: "utf8" }, | ||||
|             { encoding: "utf8" } | ||||
|         ) | ||||
|     } | ||||
| 
 | ||||
|     getSharedTagRenderings( | ||||
|         doesImageExist: DoesImageExist, | ||||
|         bootstrapTagRenderings: Map<string, QuestionableTagRenderingConfigJson> = null, | ||||
|         bootstrapTagRenderings: Map<string, QuestionableTagRenderingConfigJson> = null | ||||
|     ): Map<string, QuestionableTagRenderingConfigJson> { | ||||
|         const prepareLayer = new PrepareLayer({ | ||||
|             tagRenderings: bootstrapTagRenderings, | ||||
|  | @ -339,8 +343,8 @@ class LayerOverviewUtils extends Script { | |||
|             if (contents.indexOf("<text") > 0) { | ||||
|                 console.warn( | ||||
|                     "The SVG at " + | ||||
|                     path + | ||||
|                     " contains a `text`-tag. This is highly discouraged. Every machine viewing your theme has their own font libary, and the font you choose might not be present, resulting in a different font being rendered. Solution: open your .svg in inkscape (or another program), select the text and convert it to a path", | ||||
|                         path + | ||||
|                         " contains a `text`-tag. This is highly discouraged. Every machine viewing your theme has their own font libary, and the font you choose might not be present, resulting in a different font being rendered. Solution: open your .svg in inkscape (or another program), select the text and convert it to a path" | ||||
|                 ) | ||||
|                 errCount++ | ||||
|             } | ||||
|  | @ -352,11 +356,19 @@ class LayerOverviewUtils extends Script { | |||
| 
 | ||||
|     async main(args: string[]) { | ||||
|         console.log("Generating layer overview...") | ||||
|         const themeWhitelist = new Set(args.find(a => a.startsWith("--themes=")) | ||||
|             ?.substring("--themes=".length)?.split(",") ?? []) | ||||
|         const themeWhitelist = new Set( | ||||
|             args | ||||
|                 .find((a) => a.startsWith("--themes=")) | ||||
|                 ?.substring("--themes=".length) | ||||
|                 ?.split(",") ?? [] | ||||
|         ) | ||||
| 
 | ||||
|         const layerWhitelist = new Set(args.find(a => a.startsWith("--layers=")) | ||||
|             ?.substring("--layers=".length)?.split(",") ?? []) | ||||
|         const layerWhitelist = new Set( | ||||
|             args | ||||
|                 .find((a) => a.startsWith("--layers=")) | ||||
|                 ?.substring("--layers=".length) | ||||
|                 ?.split(",") ?? [] | ||||
|         ) | ||||
| 
 | ||||
|         const forceReload = args.some((a) => a == "--force") | ||||
| 
 | ||||
|  | @ -384,19 +396,19 @@ class LayerOverviewUtils extends Script { | |||
|             sharedLayers, | ||||
|             recompiledThemes, | ||||
|             forceReload, | ||||
|             themeWhitelist, | ||||
|             themeWhitelist | ||||
|         ) | ||||
| 
 | ||||
|         new ValidateThemeEnsemble().convertStrict( | ||||
|             Array.from(sharedThemes.values()).map(th => new LayoutConfig(th, true))) | ||||
| 
 | ||||
|             Array.from(sharedThemes.values()).map((th) => new LayoutConfig(th, true)) | ||||
|         ) | ||||
| 
 | ||||
|         if (recompiledThemes.length > 0) { | ||||
|             writeFileSync( | ||||
|                 "./src/assets/generated/known_layers.json", | ||||
|                 JSON.stringify({ | ||||
|                     layers: Array.from(sharedLayers.values()).filter((l) => l.id !== "favourite"), | ||||
|                 }), | ||||
|                 }) | ||||
|             ) | ||||
|         } | ||||
| 
 | ||||
|  | @ -417,7 +429,7 @@ class LayerOverviewUtils extends Script { | |||
|             const proto: LayoutConfigJson = JSON.parse( | ||||
|                 readFileSync("./assets/themes/mapcomplete-changes/mapcomplete-changes.proto.json", { | ||||
|                     encoding: "utf8", | ||||
|                 }), | ||||
|                 }) | ||||
|             ) | ||||
|             const protolayer = <LayerConfigJson>( | ||||
|                 proto.layers.filter((l) => l["id"] === "mapcomplete-changes")[0] | ||||
|  | @ -434,12 +446,12 @@ class LayerOverviewUtils extends Script { | |||
|                 layers: ScriptUtils.getLayerFiles().map((f) => f.parsed), | ||||
|                 themes: ScriptUtils.getThemeFiles().map((f) => f.parsed), | ||||
|             }, | ||||
|             ConversionContext.construct([], []), | ||||
|             ConversionContext.construct([], []) | ||||
|         ) | ||||
| 
 | ||||
|         for (const [_, theme] of sharedThemes) { | ||||
|             theme.layers = theme.layers.filter( | ||||
|                 (l) => Constants.added_by_default.indexOf(l["id"]) < 0, | ||||
|                 (l) => Constants.added_by_default.indexOf(l["id"]) < 0 | ||||
|             ) | ||||
|         } | ||||
| 
 | ||||
|  | @ -448,21 +460,19 @@ class LayerOverviewUtils extends Script { | |||
|                 "./src/assets/generated/known_themes.json", | ||||
|                 JSON.stringify({ | ||||
|                     themes: Array.from(sharedThemes.values()), | ||||
|                 }), | ||||
|                 }) | ||||
|             ) | ||||
|         } | ||||
| 
 | ||||
|         if (AllSharedLayers.getSharedLayersConfigs().size == 0) { | ||||
|             console.error( | ||||
|                 "This was a bootstrapping-run. Run generate layeroverview again!" | ||||
|             ) | ||||
|             console.error("This was a bootstrapping-run. Run generate layeroverview again!") | ||||
|         } | ||||
|     } | ||||
| 
 | ||||
|     private parseLayer( | ||||
|         doesImageExist: DoesImageExist, | ||||
|         prepLayer: PrepareLayer, | ||||
|         sharedLayerPath: string, | ||||
|         sharedLayerPath: string | ||||
|     ): { | ||||
|         raw: LayerConfigJson | ||||
|         parsed: LayerConfig | ||||
|  | @ -473,7 +483,7 @@ class LayerOverviewUtils extends Script { | |||
|         const parsed = parser.convertStrict(sharedLayerPath, context) | ||||
|         const result = AddIconSummary.singleton.convertStrict( | ||||
|             parsed, | ||||
|             context.inOperation("AddIconSummary"), | ||||
|             context.inOperation("AddIconSummary") | ||||
|         ) | ||||
|         return { ...result, context } | ||||
|     } | ||||
|  | @ -481,7 +491,7 @@ class LayerOverviewUtils extends Script { | |||
|     private buildLayerIndex( | ||||
|         doesImageExist: DoesImageExist, | ||||
|         forceReload: boolean, | ||||
|         whitelist: Set<string>, | ||||
|         whitelist: Set<string> | ||||
|     ): Map<string, LayerConfigJson> { | ||||
|         // First, we expand and validate all builtin layers. These are written to src/assets/generated/layers
 | ||||
|         // At the same time, an index of available layers is built.
 | ||||
|  | @ -501,7 +511,10 @@ class LayerOverviewUtils extends Script { | |||
|         for (const sharedLayerPath of ScriptUtils.getLayerPaths()) { | ||||
|             if (whitelist.size > 0) { | ||||
|                 const idByPath = sharedLayerPath.split("/").at(-1).split(".")[0] | ||||
|                 if (Constants.priviliged_layers.indexOf(<any>idByPath) < 0 && !whitelist.has(idByPath)) { | ||||
|                 if ( | ||||
|                     Constants.priviliged_layers.indexOf(<any>idByPath) < 0 && | ||||
|                     !whitelist.has(idByPath) | ||||
|                 ) { | ||||
|                     continue | ||||
|                 } | ||||
|             } | ||||
|  | @ -533,17 +546,17 @@ class LayerOverviewUtils extends Script { | |||
| 
 | ||||
|         console.log( | ||||
|             "Recompiled layers " + | ||||
|             recompiledLayers.join(", ") + | ||||
|             " and skipped " + | ||||
|             skippedLayers.length + | ||||
|             " layers. Detected " + | ||||
|             warningCount + | ||||
|             " warnings", | ||||
|                 recompiledLayers.join(", ") + | ||||
|                 " and skipped " + | ||||
|                 skippedLayers.length + | ||||
|                 " layers. Detected " + | ||||
|                 warningCount + | ||||
|                 " warnings" | ||||
|         ) | ||||
|         // We always need the calculated tags of 'usersettings', so we export them separately
 | ||||
|         this.extractJavascriptCodeForLayer( | ||||
|             state.sharedLayers.get("usersettings"), | ||||
|             "./src/Logic/State/UserSettingsMetaTagging.ts", | ||||
|             "./src/Logic/State/UserSettingsMetaTagging.ts" | ||||
|         ) | ||||
| 
 | ||||
|         return sharedLayers | ||||
|  | @ -560,8 +573,8 @@ class LayerOverviewUtils extends Script { | |||
|     private extractJavascriptCode(themeFile: LayoutConfigJson) { | ||||
|         const allCode = [ | ||||
|             "import {Feature} from 'geojson'", | ||||
|             "import { ExtraFuncType } from \"../../../Logic/ExtraFunctions\";", | ||||
|             "import { Utils } from \"../../../Utils\"", | ||||
|             'import { ExtraFuncType } from "../../../Logic/ExtraFunctions";', | ||||
|             'import { Utils } from "../../../Utils"', | ||||
|             "export class ThemeMetaTagging {", | ||||
|             "   public static readonly themeName = " + JSON.stringify(themeFile.id), | ||||
|             "", | ||||
|  | @ -573,8 +586,8 @@ class LayerOverviewUtils extends Script { | |||
| 
 | ||||
|             allCode.push( | ||||
|                 "   public metaTaggging_for_" + | ||||
|                 id + | ||||
|                 "(feat: Feature, helperFunctions: Record<ExtraFuncType, (feature: Feature) => Function>) {", | ||||
|                     id + | ||||
|                     "(feat: Feature, helperFunctions: Record<ExtraFuncType, (feature: Feature) => Function>) {" | ||||
|             ) | ||||
|             allCode.push("      const {" + ExtraFunctions.types.join(", ") + "} = helperFunctions") | ||||
|             for (const line of code) { | ||||
|  | @ -585,10 +598,10 @@ class LayerOverviewUtils extends Script { | |||
|                 if (!isStrict) { | ||||
|                     allCode.push( | ||||
|                         "      Utils.AddLazyProperty(feat.properties, '" + | ||||
|                         attributeName + | ||||
|                         "', () => " + | ||||
|                         expression + | ||||
|                         " ) ", | ||||
|                             attributeName + | ||||
|                             "', () => " + | ||||
|                             expression + | ||||
|                             " ) " | ||||
|                     ) | ||||
|                 } else { | ||||
|                     attributeName = attributeName.substring(0, attributeName.length - 1).trim() | ||||
|  | @ -633,7 +646,7 @@ class LayerOverviewUtils extends Script { | |||
|         const code = l.calculatedTags ?? [] | ||||
| 
 | ||||
|         allCode.push( | ||||
|             "   public metaTaggging_for_" + l.id + "(feat: {properties: Record<string, string>}) {", | ||||
|             "   public metaTaggging_for_" + l.id + "(feat: {properties: Record<string, string>}) {" | ||||
|         ) | ||||
|         for (const line of code) { | ||||
|             const firstEq = line.indexOf("=") | ||||
|  | @ -643,10 +656,10 @@ class LayerOverviewUtils extends Script { | |||
|             if (!isStrict) { | ||||
|                 allCode.push( | ||||
|                     "      Utils.AddLazyProperty(feat.properties, '" + | ||||
|                     attributeName + | ||||
|                     "', () => " + | ||||
|                     expression + | ||||
|                     " ) ", | ||||
|                         attributeName + | ||||
|                         "', () => " + | ||||
|                         expression + | ||||
|                         " ) " | ||||
|                 ) | ||||
|             } else { | ||||
|                 attributeName = attributeName.substring(0, attributeName.length - 2).trim() | ||||
|  | @ -671,20 +684,20 @@ class LayerOverviewUtils extends Script { | |||
|         sharedLayers: Map<string, LayerConfigJson>, | ||||
|         recompiledThemes: string[], | ||||
|         forceReload: boolean, | ||||
|         whitelist: Set<string>, | ||||
|         whitelist: Set<string> | ||||
|     ): Map<string, LayoutConfigJson> { | ||||
|         console.log("   ---------- VALIDATING BUILTIN THEMES ---------") | ||||
|         const themeFiles = ScriptUtils.getThemeFiles() | ||||
|         const fixed = new Map<string, LayoutConfigJson>() | ||||
| 
 | ||||
|         const publicLayers = LayerOverviewUtils.publicLayerIdsFrom( | ||||
|             themeFiles.map((th) => th.parsed), | ||||
|             themeFiles.map((th) => th.parsed) | ||||
|         ) | ||||
| 
 | ||||
|         const convertState: DesugaringContext = { | ||||
|             sharedLayers, | ||||
|             tagRenderings: this.getSharedTagRenderings( | ||||
|                 new DoesImageExist(licensePaths, existsSync), | ||||
|                 new DoesImageExist(licensePaths, existsSync) | ||||
|             ), | ||||
|             publicLayers, | ||||
|         } | ||||
|  | @ -717,15 +730,15 @@ class LayerOverviewUtils extends Script { | |||
|                 LayerOverviewUtils.themePath + "/" + themePath.substring(themePath.lastIndexOf("/")) | ||||
| 
 | ||||
|             const usedLayers = Array.from( | ||||
|                 LayerOverviewUtils.extractLayerIdsFrom(themeFile, false), | ||||
|                 LayerOverviewUtils.extractLayerIdsFrom(themeFile, false) | ||||
|             ).map((id) => LayerOverviewUtils.layerPath + id + ".json") | ||||
| 
 | ||||
|             if (!forceReload && !this.shouldBeUpdated([themePath, ...usedLayers], targetPath)) { | ||||
|                 fixed.set( | ||||
|                     themeFile.id, | ||||
|                     JSON.parse( | ||||
|                         readFileSync(LayerOverviewUtils.themePath + themeFile.id + ".json", "utf8"), | ||||
|                     ), | ||||
|                         readFileSync(LayerOverviewUtils.themePath + themeFile.id + ".json", "utf8") | ||||
|                     ) | ||||
|                 ) | ||||
|                 ScriptUtils.erasableLog("Skipping", themeFile.id) | ||||
|                 skippedThemes.push(themeFile.id) | ||||
|  | @ -736,23 +749,23 @@ class LayerOverviewUtils extends Script { | |||
| 
 | ||||
|             new PrevalidateTheme().convertStrict( | ||||
|                 themeFile, | ||||
|                 ConversionContext.construct([themePath], ["PrepareLayer"]), | ||||
|                 ConversionContext.construct([themePath], ["PrepareLayer"]) | ||||
|             ) | ||||
|             try { | ||||
|                 themeFile = new PrepareTheme(convertState, { | ||||
|                     skipDefaultLayers: true, | ||||
|                 }).convertStrict( | ||||
|                     themeFile, | ||||
|                     ConversionContext.construct([themePath], ["PrepareLayer"]), | ||||
|                     ConversionContext.construct([themePath], ["PrepareLayer"]) | ||||
|                 ) | ||||
|                 new ValidateThemeAndLayers( | ||||
|                     new DoesImageExist(licensePaths, existsSync, knownTagRenderings), | ||||
|                     themePath, | ||||
|                     true, | ||||
|                     knownTagRenderings, | ||||
|                     knownTagRenderings | ||||
|                 ).convertStrict( | ||||
|                     themeFile, | ||||
|                     ConversionContext.construct([themePath], ["PrepareLayer"]), | ||||
|                     ConversionContext.construct([themePath], ["PrepareLayer"]) | ||||
|                 ) | ||||
| 
 | ||||
|                 if (themeFile.icon.endsWith(".svg")) { | ||||
|  | @ -807,16 +820,16 @@ class LayerOverviewUtils extends Script { | |||
|                                 .OnEveryLanguage((s) => parse_html(s).textContent).translations, | ||||
|                         mustHaveLanguage: t.mustHaveLanguage?.length > 0, | ||||
|                     } | ||||
|                 }), | ||||
|                 }) | ||||
|             ) | ||||
|         } | ||||
| 
 | ||||
|         console.log( | ||||
|             "Recompiled themes " + | ||||
|             recompiledThemes.join(", ") + | ||||
|             " and skipped " + | ||||
|             skippedThemes.length + | ||||
|             " themes", | ||||
|                 recompiledThemes.join(", ") + | ||||
|                 " and skipped " + | ||||
|                 skippedThemes.length + | ||||
|                 " themes" | ||||
|         ) | ||||
| 
 | ||||
|         return fixed | ||||
|  |  | |||
		Loading…
	
	Add table
		Add a link
		
	
		Reference in a new issue