Chore: remove all unused imports, port 'allTags' to proper svelte

src/UI/Popup/AddNewPoint/PresetList.svelte

@@ -9,9 +9,7 @@
   import { ImmutableStore } from "../../../Logic/UIEventSource"
   import { TagUtils } from "../../../Logic/Tags/TagUtils"
   import LayerConfig from "../../../Models/ThemeConfig/LayerConfig"
-  import FromHtml from "../../Base/FromHtml.svelte"
   import NextButton from "../../Base/NextButton.svelte"
-  import { UIElement } from "../../UIElement"
   import ToSvelte from "../../Base/ToSvelte.svelte"
   import BaseUIElement from "../../BaseUIElement"
 
@@ -37,7 +35,7 @@
           "Not showing presets for layer",
           flayer.layerDef.id,
           "as not displayed and featureSwitchFilter.data is set",
-          state.featureSwitches.featureSwitchFilter.data
+          state.featureSwitches.featureSwitchFilter.data,
         )
         // ...and we cannot enable the layer control -> we skip, as these presets can never be shown anyway
         continue
@@ -66,7 +64,7 @@
         tags,
         text: Translations.t.general.add.addNew.Subs(
           { category: preset.title },
-          preset.title["context"]
+          preset.title["context"],
         ),
       }
       presets.push(simplified)

src/UI/Popup/AllTagsPanel.svelte

@@ -1,67 +1,96 @@
 <script lang="ts">
-  import ToSvelte from "../Base/ToSvelte.svelte"
-  import Table from "../Base/Table"
-  import { UIEventSource } from "../../Logic/UIEventSource"
+  import { Store, UIEventSource } from "../../Logic/UIEventSource"
   import SimpleMetaTaggers from "../../Logic/SimpleMetaTagger"
-  import { FixedUiElement } from "../Base/FixedUiElement"
-  import { onDestroy } from "svelte"
-  import Toggle from "../Input/Toggle"
-  import Lazy from "../Base/Lazy"
-  import BaseUIElement from "../BaseUIElement"
-  import LayoutConfig from "../../Models/ThemeConfig/LayoutConfig"
-  import { VariableUiElement } from "../Base/VariableUIElement"
+  import LayerConfig from "../../Models/ThemeConfig/LayerConfig"
 
-  //Svelte props
-  export let tags: UIEventSource<any>
-  export let state: { layoutToUse: LayoutConfig } = undefined
+  export let tags: UIEventSource<Record<string, any>>
+  export let tagKeys = tags.map(tgs => Object.keys(tgs))
 
-  const calculatedTags = [].concat(
-    ...(state?.layoutToUse?.layers?.map((l) => l.calculatedTags?.map((c) => c[0]) ?? []) ?? [])
-  )
+  export let layer: LayerConfig
 
-  const allTags = tags.mapD((tags) => {
-    const parts: (string | BaseUIElement)[][] = []
-    for (const key in tags) {
-      let v = tags[key]
-      if (v === "") {
-        v = "<b>empty string</b>"
-      }
-      parts.push([key, v ?? "<b>undefined</b>"])
-    }
+  /**
+   * The names (keys) of the calculated tags. Each will normally start with an underscore (but in rare cases not)
+   */
+  let calculatedTags: string[] = []
+  for (const [name, _, __] of layer.calculatedTags ?? []) {
+    calculatedTags.push(name)
+  }
+  let knownValues: Store<string[]> = tags.map(tags => Object.keys(tags))
 
-    for (const key of calculatedTags) {
-      const value = tags[key]
-      if (value === undefined) {
-        continue
-      }
-      let type = ""
-      if (typeof value !== "string") {
-        type = " <i>" + typeof value + "</i>"
-      }
-      parts.push(["<i>" + key + "</i>", value])
-    }
+  const metaKeys: string[] = [].concat(...SimpleMetaTaggers.metatags.map(k => k.keys))
+  let allCalculatedTags = new Set<string>([...calculatedTags, ...metaKeys])
 
-    for (const metatag of SimpleMetaTaggers.metatags.filter((mt) => mt.isLazy)) {
-      const title = "<i>" + metatag.keys.join(";") + "</i> (lazy)"
-      const toggleState = new UIEventSource(false)
-      const toggle: BaseUIElement = new Toggle(
-        new Lazy(() => new FixedUiElement(metatag.keys.map((key) => tags[key]).join(";"))),
-        new FixedUiElement("Evaluate").onClick(() => toggleState.setData(true)),
-        toggleState
-      )
-      parts.push([title, toggle])
-    }
-
-    return parts
-  })
-
-  const tagsTable = new VariableUiElement(
-    allTags.mapD((_allTags) =>
-      new Table(["Key", "Value"], _allTags).SetClass("zebra-table break-all")
-    )
-  )
 </script>
 
 <section>
-  <ToSvelte construct={tagsTable} />
+  <table class="zebra-table break-all">
+    <tr>
+      <th>Key</th>
+      <th>Value</th>
+    </tr>
+    <tr>
+      <th colspan="2">Normal tags</th>
+    </tr>
+    {#each $tagKeys as key}
+      {#if !allCalculatedTags.has(key)}
+        <tr>
+          <td>{key}</td>
+          <td>
+            {#if $tags[key] === undefined}
+              <i>undefined</i>
+            {:else if $tags[key] === ""}
+              <i>Empty string</i>
+            {:else}
+              {$tags[key]}
+            {/if}
+          </td>
+        </tr>
+      {/if}
+    {/each}
+    <tr>
+      <th colspan="2">Calculated tags</th>
+    </tr>
+    {#if calculatedTags.length === 0}
+      <tr>
+        <td colspan="2"><i>This layer does not use calculated tags</i></td>
+      </tr>
+    {/if}
+    {#each calculatedTags as key}
+      <tr>
+        <td>{key}</td>
+        <td>
+          {#if $tags[key] === undefined}
+            <i>undefined</i>
+          {:else if $tags[key] === ""}
+            <i>Empty string</i>
+          {:else if $tags[key] !== "string"}
+            <span class="literal-code">{$tags[key]}</span>
+            <i>{typeof $tags[key]}</i>
+          {:else}
+            {$tags[key]}
+          {/if}
+        </td>
+      </tr>
+    {/each}
+
+    <tr>
+      <th colspan="2">Metatags tags</th>
+    </tr>
+    {#each metaKeys as key}
+      <tr>
+        <td>{key}</td>
+        <td>
+          {#if $knownValues.indexOf(key) < 0 }
+            <button class="small" on:click={_ => {console.log($tags[key])}}>Evaluate</button>
+          {:else if !$tags[key] === undefined}
+            <i>Undefined</i>
+          {:else if $tags[key] === ""}
+            <i>Empty string</i>
+          {:else}
+            {$tags[key]}
+          {/if}
+        </td>
+      </tr>
+    {/each}
+  </table>
 </section>

src/UI/Popup/DeleteFlow/DeleteWizard.svelte

@@ -11,7 +11,6 @@
   import { UIEventSource } from "../../../Logic/UIEventSource"
   import LayerConfig from "../../../Models/ThemeConfig/LayerConfig"
   import { TagsFilter } from "../../../Logic/Tags/TagsFilter"
-  import { XCircleIcon } from "@rgossiaux/svelte-heroicons/solid"
   import { TagUtils } from "../../../Logic/Tags/TagUtils"
   import OsmChangeAction from "../../../Logic/Osm/Actions/OsmChangeAction"
   import DeleteAction from "../../../Logic/Osm/Actions/DeleteAction"
@@ -66,7 +65,7 @@
           theme: state?.layout?.id ?? "unknown",
           specialMotivation: deleteReason,
         },
-        canBeDeleted.data
+        canBeDeleted.data,
       )
     } else {
       // no _delete_reason is given, which implies that this is _not_ a deletion but merely a retagging via a nonDeleteMapping

src/UI/Popup/HistogramViz.ts

@@ -2,7 +2,6 @@ import { Store, UIEventSource } from "../../Logic/UIEventSource"
 import { SpecialVisualization, SpecialVisualizationState } from "../SpecialVisualization"
 import Histogram from "../BigComponents/Histogram"
 import { Feature } from "geojson"
-import Constants from "../../Models/Constants"
 
 export class HistogramViz implements SpecialVisualization {
     funcName = "histogram"

src/UI/Popup/ImportButtons/ImportFlow.ts

@@ -6,7 +6,6 @@ import TagApplyButton from "../TagApplyButton"
 import { PointImportFlowArguments } from "./PointImportFlowState"
 import { Translation } from "../../i18n/Translation"
 import Translations from "../../i18n/Translations"
-import { OsmConnection } from "../../../Logic/Osm/OsmConnection"
 import FilteredLayer from "../../../Models/FilteredLayer"
 import LayerConfig from "../../../Models/ThemeConfig/LayerConfig"
 import { LayerConfigJson } from "../../../Models/ThemeConfig/Json/LayerConfigJson"

src/UI/Popup/MinimapViz.ts

@@ -6,7 +6,6 @@ import { MapLibreAdaptor } from "../Map/MapLibreAdaptor"
 import SvelteUIElement from "../Base/SvelteUIElement"
 import MaplibreMap from "../Map/MaplibreMap.svelte"
 import ShowDataLayer from "../Map/ShowDataLayer"
-import LayerConfig from "../../Models/ThemeConfig/LayerConfig"
 import { GeoOperations } from "../../Logic/GeoOperations"
 import { BBox } from "../../Logic/BBox"
 
@@ -32,7 +31,7 @@ export class MinimapViz implements SpecialVisualization {
         state: SpecialVisualizationState,
         tagSource: UIEventSource<Record<string, string>>,
         args: string[],
-        feature: Feature,
+        feature: Feature
     ) {
         if (state === undefined || feature === undefined) {
             return undefined

src/UI/Popup/MoveWizardState.ts

@@ -10,7 +10,6 @@ import { Tag } from "../../Logic/Tags/Tag"
 import { SpecialVisualizationState } from "../SpecialVisualization"
 import { Feature, Point } from "geojson"
 import SvelteUIElement from "../Base/SvelteUIElement"
-import Confirm from "../../assets/svg/Confirm.svelte"
 import Relocation from "../../assets/svg/Relocation.svelte"
 import Location from "../../assets/svg/Location.svelte"
 

src/UI/Popup/Notes/CloseNoteButton.ts

@@ -1,7 +1,6 @@
 import BaseUIElement from "../../BaseUIElement"
 import Translations from "../../i18n/Translations"
 import { Utils } from "../../../Utils"
-import Svg from "../../../Svg"
 import Img from "../../Base/Img"
 import { SubtleButton } from "../../Base/SubtleButton"
 import Toggle from "../../Input/Toggle"