elgaard/MapComplete
1
0
Fork 0
forked from MapComplete/MapComplete
Code Pull requests Activity

Themes(school): add invalidValues for conflicting uniform values

Browse source
This commit is contained in:
Pieter Vander Vennet 2025-03-01 03:33:57 +01:00
parent a42e1f8161
commit 31312c2dc6
4 changed files with 17 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/Models/ThemeConfig/Json/QuestionableTagRenderingConfigJson.ts
View file

@ -268,7 +268,7 @@ export interface QuestionableTagRenderingConfigJson extends TagRenderingConfigJs
*/
default?: string
/**
* question: What values of the freeform key should be interpreted as 'unknown'?
* question: What tag combintations key should be interpreted as 'unknown'?
* For example, if a feature has `shop=yes`, the question 'what type of shop is this?' should still asked
* ifunset: The question will be considered answered if any value is set for the key
* group: expert

4
src/Models/ThemeConfig/TagRenderingConfig.ts
View file

@ -812,6 +812,10 @@ export default class TagRenderingConfig {
if (and.and.length === 0) {
return undefined
}
console.log(">>> New properties", TagUtils.asProperties(and, currentProperties), this.invalidValues)
if (this.invalidValues?.matchesProperties(TagUtils.asProperties(and, currentProperties))) {
return undefined
}
return and
}