contrapunctus/MapComplete
1
0
Fork 0
forked from MapComplete/MapComplete
Code Pull requests Activity

Hotkeys: translations, fix location lock on mobile

Browse source
This commit is contained in:
Pieter Vander Vennet 2022-12-28 00:37:48 +01:00
parent ae8e46f7a6
commit 65bb91b97a
7 changed files with 40 additions and 27 deletions
Download patch file Download diff file Expand all files Collapse all files

31
UI/Base/Hotkeys.ts
View file

@ -5,18 +5,19 @@ import Title from "./Title"
import Table from "./Table"
import { UIEventSource } from "../../Logic/UIEventSource"
import { VariableUiElement } from "./VariableUIElement"
import doc = Mocha.reporters.doc
import { Translation } from "../i18n/Translation"
import { FixedUiElement } from "./FixedUiElement"
export default class Hotkeys {
private static readonly _docs: UIEventSource<
{
key: { ctrl?: string; shift?: string; alt?: string; nomod?: string; onUp?: boolean }
documentation: string
documentation: string | Translation
}[]
> = new UIEventSource<
{
key: { ctrl?: string; shift?: string; alt?: string; nomod?: string; onUp?: boolean }
documentation: string
documentation: string | Translation
}[]
>([])
@ -41,7 +42,7 @@ export default class Hotkeys {
) & {
onUp?: boolean
},
documentation: string,
documentation: string | Translation,
action: () => void
) {
const type = key["onUp"] ? "keyup" : "keypress"
@ -98,22 +99,22 @@ export default class Hotkeys {
}
static generateDocumentation(): BaseUIElement {
const byKey: [string, string | Translation][] = Hotkeys._docs.data
.map(({ key, documentation }) => {
const modifiers = Object.keys(key).filter((k) => k !== "nomod" && k !== "onUp")
const keycode: string = key["ctrl"] ?? key["shift"] ?? key["alt"] ?? key["nomod"]
modifiers.push(keycode)
return <[string, string | Translation]>[modifiers.join("+"), documentation]
})
.sort()
return new Combine([
new Title("Hotkeys", 1),
"MapComplete supports the following keys:",
new Table(
["Key combination", "Action"],
Hotkeys._docs.data
.map(({ key, documentation }) => {
const modifiers = Object.keys(key).filter(
(k) => k !== "nomod" && k !== "onUp"
)
const keycode: string =
key["ctrl"] ?? key["shift"] ?? key["alt"] ?? key["nomod"]
modifiers.push(keycode)
return [modifiers.join("+"), documentation]
})
.sort()
byKey.map(([key, doc]) => {
return [new FixedUiElement(key).SetClass("code"), doc]
})
),
])
}

3
UI/Base/ScrollableFullScreen.ts
View file

@ -6,6 +6,7 @@ import Hash from "../../Logic/Web/Hash"
import BaseUIElement from "../BaseUIElement"
import Title from "./Title"
import Hotkeys from "./Hotkeys"
import Translations from "../i18n/Translations";
/**
*
@ -85,7 +86,7 @@ export default class ScrollableFullScreen {
private static initEmpty(): FixedUiElement {
Hotkeys.RegisterHotkey(
{ nomod: "Escape", onUp: true },
"Close the sidebar",
Translations.t.hotkeyDocumentation.closeSidebar,
ScrollableFullScreen.collapse
)

3
UI/BigComponents/BackgroundMapSwitch.ts
View file

@ -8,6 +8,7 @@ import AvailableBaseLayers from "../../Logic/Actors/AvailableBaseLayers"
import BaseUIElement from "../BaseUIElement"
import { GeoOperations } from "../../Logic/GeoOperations"
import Hotkeys from "../Base/Hotkeys"
import Translations from "../i18n/Translations";
class SingleLayerSelectionButton extends Toggle {
public readonly activate: () => void
@ -204,7 +205,7 @@ export default class BackgroundMapSwitch extends Combine {
if (options?.enableHotkeys) {
Hotkeys.RegisterHotkey(
{ nomod: category.charAt(0).toUpperCase() },
"Switch to a background layer of category " + category,
Translations.t.hotkeyDocumentation.selectBackground.Subs({category}),
() => {
button.activate()
}

15
UI/BigComponents/GeolocationControl.ts
View file

@ -5,6 +5,7 @@ import GeoLocationHandler from "../../Logic/Actors/GeoLocationHandler"
import { BBox } from "../../Logic/BBox"
import Loc from "../../Models/Loc"
import Hotkeys from "../Base/Hotkeys"
import Translations from "../i18n/Translations"
/**
* Displays an icon depending on the state of the geolocation.
@ -52,10 +53,7 @@ export class GeolocationControl extends VariableUiElement {
// We have a location, so we show a dot in the center
if (
lastClickWithinThreeSecs.data &&
geolocationState.permission.data === "granted"
) {
if (lastClickWithinThreeSecs.data) {
return Svg.location_unlocked_svg()
}
@ -72,7 +70,10 @@ export class GeolocationControl extends VariableUiElement {
)
async function handleClick() {
if (geolocationState.permission.data !== "granted") {
if (
geolocationState.permission.data !== "granted" &&
geolocationState.currentGPSLocation.data === undefined
) {
await geolocationState.requestPermission()
}
@ -102,7 +103,7 @@ export class GeolocationControl extends VariableUiElement {
})
}
if (lastClickWithinThreeSecs.data && geolocationState.permission.data === "granted") {
if (lastClickWithinThreeSecs.data) {
geolocationState.isLocked.setData(true)
lastClick.setData(undefined)
return
@ -114,7 +115,7 @@ export class GeolocationControl extends VariableUiElement {
this.onClick(handleClick)
Hotkeys.RegisterHotkey(
{ nomod: "L" },
"Pan the map to the current location or zoom the map to the current location. Requests geopermission",
Translations.t.hotkeyDocumentation.geolocate,
handleClick
)

2
UI/BigComponents/LeftControls.ts
View file

@ -97,7 +97,7 @@ export default class LeftControls extends Combine {
state.featureSwitchFilter.addCallbackAndRun((f) => {
Hotkeys.RegisterHotkey(
{ nomod: "B" },
"Opens the Background, layers and filters panel",
Translations.t.hotkeyDocumentation.openLayersPanel,
() => {
guiState.filterViewIsOpened.setData(!guiState.filterViewIsOpened.data)
}

5
UI/DefaultGUI.ts
View file

@ -33,6 +33,7 @@ import GeoLocationHandler from "../Logic/Actors/GeoLocationHandler"
import { GeoLocationState } from "../Logic/State/GeoLocationState"
import Hotkeys from "./Base/Hotkeys"
import AvailableBaseLayers from "../Logic/Actors/AvailableBaseLayers"
import { Translation } from "./i18n/Translation"
/**
* The default MapComplete GUI initializer
@ -65,7 +66,7 @@ export default class DefaultGUI {
Hotkeys.RegisterHotkey(
{ shift: "O" },
"Switch to default Mapnik-OpenStreetMap background",
Translations.t.hotkeyDocumentation.selectMapnik,
() => {
this.state.backgroundLayer.setData(AvailableBaseLayers.osmCarto)
}
@ -257,7 +258,7 @@ export default class DefaultGUI {
)
Hotkeys.RegisterHotkey(
{ ctrl: "F" },
"Select the search bar to search locations",
Translations.t.hotkeyDocumentation.selectSearch,
() => {
search.focus()
}

8
langs/en.json
View file

@ -351,6 +351,14 @@
"wikipediaboxTitle": "Wikipedia"
}
},
"hotkeyDocumentation": {
"closeSidebar": "Close the sidebar",
"geolocate": "Pan the map to the current location or zoom the map to the current location. Requests geopermission",
"openLayersPanel": "Opens the Background, layers and filters panel",
"selectBackground": "Select a background layer of category {category}",
"selectMapnik": "Sets the background layer to OpenStreetMap-carto",
"selectSearch": "Select the search bar to search locations"
},
"image": {
"addPicture": "Add picture",
"ccb": "under the CC-BY-license",