Robin-van-der-Linde/MapComplete
1
0
Fork 0
forked from MapComplete/MapComplete
Code Pull requests Activity

Performance: only ping 'allPreferences' when all preferences are set, not on every preference added (which causes a O(n²) in some cases)

Browse source
This commit is contained in:
Pieter Vander Vennet 2025-01-02 04:30:18 +01:00
parent 335906b481
commit 312a32e7b5
1 changed files with 17 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
src/Logic/Osm/OsmPreferences.ts
View file

@ -38,14 +38,23 @@ export class OsmPreferences {
}) })
} }
private setPreferencesAll(key: string, value: string) { /**
* Sets a new preferenceValue in 'allPreferences'
* @param key
* @param value
* @param deferping: the end user will ping '_allPreferences'
* @private
*/
private setPreferencesAll(key: string, value: string, deferping = false) {
if (this._allPreferences.data[key] !== value) { if (this._allPreferences.data[key] !== value) {
this._allPreferences.data[key] = value this._allPreferences.data[key] = value
this._allPreferences.ping() if(!deferping){
this._allPreferences.ping()
}
} }
} }
private initPreference(key: string, value: string = undefined): UIEventSource<string> { private initPreference(key: string, value: string = undefined, deferPing = false): UIEventSource<string> {
if (this.preferences[key] !== undefined) { if (this.preferences[key] !== undefined) {
if (value !== undefined) { if (value !== undefined) {
this.preferences[key].set(value) this.preferences[key].set(value)
@ -54,12 +63,12 @@ export class OsmPreferences {
} }
const pref = (this.preferences[key] = new UIEventSource(value, "preference: " + key)) const pref = (this.preferences[key] = new UIEventSource(value, "preference: " + key))
if (value) { if (value) {
this.setPreferencesAll(key, value) this.setPreferencesAll(key, value, deferPing)
} }
pref.addCallback((v) => { pref.addCallback((v) => {
console.log("Got an update:", key, "--->", v) console.log("Got an update:", key, "--->", v)
this.uploadKvSplit(key, v) this.uploadKvSplit(key, v)
this.setPreferencesAll(key, v) this.setPreferencesAll(key, v, deferPing)
}) })
return pref return pref
} }
@ -73,11 +82,12 @@ export class OsmPreferences {
await this.removeLegacy(legacy) await this.removeLegacy(legacy)
} }
for (const key in merged) { for (const key in merged) {
this.initPreference(key, prefs[key]) this.initPreference(key, prefs[key], true)
} }
for (const key in legacy) { for (const key in legacy) {
this.initPreference(key, legacy[key]) this.initPreference(key, legacy[key], true)
} }
this._allPreferences.ping()
} }
public getPreference(key: string, defaultValue: string = undefined, prefix?: string) { public getPreference(key: string, defaultValue: string = undefined, prefix?: string) {