Osmwithspace/MapComplete
1
0
Fork 0
forked from MapComplete/MapComplete
Code Pull requests Activity

Fix: fix small typing issues

Browse source
This commit is contained in:
Pieter Vander Vennet 2025-09-01 01:09:07 +02:00
parent 5a0866ff08
commit fd5e39065d
1 changed files with 5 additions and 21 deletions
Download patch file Download diff file Expand all files Collapse all files

26
src/Models/Denomination.ts
View file

@ -64,7 +64,7 @@ export class Denomination {
throw `${context} uses the old 'default'-key. Use "useIfNoUnitGiven" or "useAsDefaultInput" instead` throw `${context} uses the old 'default'-key. Use "useIfNoUnitGiven" or "useAsDefaultInput" instead`
} }
const humanTexts = typeof json.human === "string" ? Translations.T(json.human) : new Translation(json.human) const humanTexts: TypedTranslation<{ quantity: string }> = Translations.T(json.human)
humanTexts.OnEveryLanguage((text, language) => { humanTexts.OnEveryLanguage((text, language) => {
if (text.indexOf("{quantity}") < 0) { if (text.indexOf("{quantity}") < 0) {
throw `In denomination: a human text should contain {quantity} (at ${context}.human.${language}). The offending text is: ${text}` throw `In denomination: a human text should contain {quantity} (at ${context}.human.${language}). The offending text is: ${text}`
@ -85,21 +85,6 @@ export class Denomination {
) )
} }
public clone() {
return new Denomination(
this.canonical,
this._canonicalSingular,
this.useIfNoUnitGiven,
this.prefix,
this.addSpace,
this.alternativeDenominations,
this.human,
this.humanSingular,
this.validator,
this.factorToCanonical
)
}
public withBlankCanonical() { public withBlankCanonical() {
return new Denomination( return new Denomination(
"", "",
@ -181,18 +166,17 @@ export class Denomination {
} }
value = value.toLowerCase() value = value.toLowerCase()
const self = this
function startsWith(key) { const startsWith = (key) => {
if (self.prefix) { if (this.prefix) {
return value.startsWith(key) return value.startsWith(key)
} else { } else {
return value.endsWith(key) return value.endsWith(key)
} }
} }
function substr(key) { const substr = (key) => {
if (self.prefix) { if (this.prefix) {
return value.substring(key.length).trim() return value.substring(key.length).trim()
} }
let trimmed = value.substring(0, value.length - key.length).trim() let trimmed = value.substring(0, value.length - key.length).trim()