Osmwithspace/MapComplete
1
0
Fork 0
forked from MapComplete/MapComplete
Code Pull requests Activity

Fix duplicate building upload in GRB theme (hopefully), remove type from method name, improve typing and error messages

Browse source
This commit is contained in:
Pieter Vander Vennet 2024-01-04 23:42:47 +01:00
parent fc483ed547
commit b8a631f368
11 changed files with 49 additions and 26 deletions
Download patch file Download diff file Expand all files Collapse all files

6
src/Logic/FeatureSource/Sources/FeatureSourceMerger.ts
View file

@ -39,8 +39,8 @@ export default class FeatureSourceMerger implements IndexedFeatureSource {
})
}
protected addData(featuress: Feature[][]) {
featuress = Utils.NoNull(featuress)
protected addData(sources: Feature[][]) {
sources = Utils.NoNull(sources)
let somethingChanged = false
const all: Map<string, Feature> = new Map()
const unseen = new Set<string>()
@ -51,7 +51,7 @@ export default class FeatureSourceMerger implements IndexedFeatureSource {
unseen.add(oldValue.properties.id)
}
for (const features of featuress) {
for (const features of sources) {
for (const f of features) {
const id = f.properties.id
unseen.delete(id)

2
src/Logic/FeatureSource/TiledFeatureSource/DynamicTileSource.ts
View file

@ -6,7 +6,7 @@ import FeatureSourceMerger from "../Sources/FeatureSourceMerger"
/***
* A tiled source which dynamically loads the required tiles at a fixed zoom level.
* A single featureSource will be initiliased for every tile in view; which will alter be merged into this featureSource
* A single featureSource will be initialized for every tile in view; which will later be merged into this featureSource
*/
export default class DynamicTileSource extends FeatureSourceMerger {
constructor(