Osmwithspace/MapComplete
1
0
Fork 0
forked from MapComplete/MapComplete
Code Pull requests Activity

Feature(reviews): add loading screen

Browse source
This commit is contained in:
Pieter Vander Vennet 2025-07-24 19:46:39 +02:00
parent feb0d47aec
commit 4c0c8ae9ea
2 changed files with 21 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

21
src/Logic/Web/MangroveReviews.ts
View file

@ -149,7 +149,7 @@ export default class FeatureReviews {
public readonly average: Store<number | null>
private readonly _reviews: UIEventSource<
(Review & { kid: string; signature: string; madeByLoggedInUser: Store<boolean> })[]
> = new UIEventSource([])
> = new UIEventSource(undefined)
public readonly reviews: Store<(Review & { signature: string, madeByLoggedInUser: Store<boolean> })[]> =
this._reviews
private readonly _lat: number
@ -159,11 +159,6 @@ export default class FeatureReviews {
private readonly _identity: MangroveIdentity
private readonly _testmode: Store<boolean>
public readonly loadingAllowed: UIEventSource<boolean | null>
private readonly _options: Readonly<{
nameKey?: "name" | string
fallbackName?: string
uncertaintyRadius?: number
}>
private readonly _reportError: (msg: string, extra: string) => Promise<void>
private constructor(
@ -186,7 +181,6 @@ export default class FeatureReviews {
this._identity = mangroveIdentity
this._testmode = testmode ?? new ImmutableStore(false)
const nameKey = options?.nameKey ?? "name"
this._options = options
if (options.uncertaintyRadius) {
this._uncertainty = options.uncertaintyRadius
} else if (feature.geometry.type === "Point") {
@ -383,11 +377,18 @@ export default class FeatureReviews {
signature: "",
madeByLoggedInUser: new ImmutableStore(true),
}
this.initReviews()
this._reviews.data.push(reviewWithKid)
this._reviews.ping()
this._identity.addReview(reviewWithKid)
}
private initReviews(){
if(this._reviews.data === undefined){
this._reviews.set([])
}
}
/**
* Adds given reviews to the 'reviews'-UI-eventsource, if they match close enough.
* We assume only geo-reviews are passed in (as they should be queried using the 'geo'-part)
@ -398,9 +399,11 @@ export default class FeatureReviews {
reviews: { payload: Review; kid: string; signature: string }[],
expectedName: string
) {
const alreadyKnown = new Set(this._reviews.data.map((r) => r.rating + " " + r.opinion))
const alreadyKnown = new Set(this._reviews.data?.map((r) => r.rating + " " + r.opinion))
let hasNew = false
this.initReviews()
for (const reviewData of reviews) {
const review = reviewData.payload
@ -457,7 +460,7 @@ export default class FeatureReviews {
public removeReviewLocally(review: Review){
this._reviews.set(
this._reviews.data.filter(r => r !== review)
this._reviews.data?.filter(r => r !== review)
)
}