Osmwithspace/MapComplete
1
0
Fork 0
forked from MapComplete/MapComplete
Code Pull requests Activity

Fix: regenerate NSI-logos, should fix regression reported in #2300

Browse source
This commit is contained in:
Pieter Vander Vennet 2025-06-03 23:47:29 +02:00
parent a858a85879
commit 4744471495
7 changed files with 50745 additions and 50156 deletions
Download patch file Download diff file Expand all files Collapse all files

8
src/Models/ThemeConfig/Conversion/ValidateTheme.ts
View file

@ -6,6 +6,7 @@ import { ConversionContext } from "./ConversionContext"
import ThemeConfig from "../ThemeConfig"
import { Utils } from "../../../Utils"
import { DetectDuplicatePresets, DoesImageExist, ValidateLanguageCompleteness } from "./Validation"
import Constants from "../../Constants"
export class ValidateTheme extends DesugaringStep<ThemeConfigJson> {
/**
@ -64,6 +65,7 @@ export class ValidateTheme extends DesugaringStep<ThemeConfigJson> {
// Check images: are they local, are the licenses there, is the theme icon square, ...
const images = this._extractImages.convert(json, context.inOperation("ValidateTheme"))
const remoteImages = images.filter((img) => img.path.indexOf("http") == 0)
.filter(img => !img.path.startsWith(Constants.nsiLogosEndpoint))
for (const remoteImage of remoteImages) {
context.err(
"Found a remote image: " +
@ -110,7 +112,7 @@ export class ValidateTheme extends DesugaringStep<ThemeConfigJson> {
if (json["mustHaveLanguage"] !== undefined) {
new ValidateLanguageCompleteness(...json["mustHaveLanguage"]).convert(
theme,
context
context.inOperation("ValidateLanguageCompleteness")
)
}
if (!json.hideFromOverview && theme.id !== "personal" && this._isBuiltin) {
@ -123,7 +125,7 @@ export class ValidateTheme extends DesugaringStep<ThemeConfigJson> {
}
// Official, public themes must have a full english translation
new ValidateLanguageCompleteness("en").convert(theme, context)
new ValidateLanguageCompleteness("en").convert(theme, context.inOperation("ValidateLanguageCompleteness"))
}
} catch (e) {
console.error(e)
@ -131,7 +133,7 @@ export class ValidateTheme extends DesugaringStep<ThemeConfigJson> {
}
if (theme.id !== "personal") {
new DetectDuplicatePresets().convert(theme, context)
new DetectDuplicatePresets().convert(theme, context.inOperation("DectectDuplicatePrsets"))
}
if (!theme.title) {