Osmwithspace/MapComplete
1
0
Fork 0
forked from MapComplete/MapComplete
Code Pull requests Activity

Fix: remove NSI-renderings which actually don't have a logo, fix MapComplete/MapComplete#2300

Browse source
This commit is contained in:
Pieter Vander Vennet 2025-01-26 22:05:44 +01:00
parent a10d04d913
commit 3e3b4b9420
4 changed files with 18 additions and 211606 deletions
Download patch file Download diff file Expand all files Collapse all files

10
src/Logic/Web/NameSuggestionIndex.ts
View file

@ -216,7 +216,7 @@ export default class NameSuggestionIndex {
const frequency = frequencies[nsiItem.displayName]
const iconUrl = this.getIconExternalUrl(nsiItem, type)
const hasIcon = iconUrl !== undefined
const icon = hasIcon ? this.getIconUrl(nsiItem, type) : undefined
const icon = hasIcon ? this.getIconUrl(nsiItem) : undefined
mappings.push({
if: new Tag(type, tags[type]),
addExtraTags: Object.keys(tags)
@ -399,9 +399,15 @@ export default class NameSuggestionIndex {
return logos?.facebook ?? logos?.wikidata
}
public getIconUrl(nsiItem: NSIItem, type: string) {
public getIconUrl(nsiItem: NSIItem): string | undefined {
if (!nsiItem.ext) {
// No extension -> there is no logo
return undefined
}
return "./assets/data/nsi/logos/" + nsiItem.id + "." + nsiItem.ext
}
private static readonly brandPrefix = ["name", "alt_name", "operator", "brand"] as const
/**