Bastian-Greshake-Tzovaras/MapComplete
1
0
Fork 0
forked from MapComplete/MapComplete
Code Pull requests Activity

Fix public holiday picker, add some tests, see #902

Browse source
This commit is contained in:
Pieter Vander Vennet 2022-06-29 16:57:29 +02:00
parent 1773f851d1
commit f99685c47d
2 changed files with 29 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

17
UI/OpeningHours/PublicHolidayInput.ts
View file

@ -26,6 +26,20 @@ export default class PublicHolidayInput extends InputElement<string> {
return true;
}
/**
*
* // should construct an element
* const html = new PublicHolidayInput().InnerConstructElement()
* html !== undefined // => true
*
* // should construct an element despite having an invalid input
* const html = new PublicHolidayInput(new UIEventSource("invalid")).InnerConstructElement()
* html !== undefined // => true
*
* // should construct an element despite having null as input
* const html = new PublicHolidayInput(new UIEventSource(null)).InnerConstructElement()
* html !== undefined // => true
*/
protected InnerConstructElement(): HTMLElement {
const dropdown = new DropDown(
Translations.t.general.opening_hours.open_during_ph.Clone(),
@ -75,6 +89,9 @@ export default class PublicHolidayInput extends InputElement<string> {
const value = this._value;
value.map(ph => OH.ParsePHRule(ph))
.addCallbackAndRunD(parsed => {
if(parsed === null){
return
}
mode.setData(parsed.mode)
startTime.setData(parsed.start)
endTime.setData(parsed.end)