Bastian-Greshake-Tzovaras/MapComplete
1
0
Fork 0
forked from MapComplete/MapComplete
Code Pull requests Activity

Reorder questions order; add condition to not ask for properties of the tree that can be read from wikidata

Browse source
This commit is contained in:
Pieter Vander Vennet 2022-08-17 02:42:16 +02:00
parent 34799f161d
commit 89eecdb38a
1 changed files with 119 additions and 111 deletions
Download patch file Download diff file Expand all files Collapse all files

230
assets/layers/tree_node/tree_node.json
View file

@ -105,80 +105,44 @@
] ]
}, },
{ {
"id": "tree-leaf_type", "id": "tree-species-wikidata",
"question": { "question": {
"nl": "Is dit een naald- of loofboom?", "en": "What species is this tree?",
"en": "Is this a broadleaved or needleleaved tree?", "de": "Um welche Baumart handelt es sich?",
"it": "Si tratta di un albero latifoglia o aghifoglia?", "id": "Spesies pohon apa ini?",
"fr": "Cet arbre est-il un feuillu ou un résineux ?", "es": "¿De qué especie es este árbol?",
"de": "Ist dies ein Laub- oder Nadelbaum?", "nl": "Wat is de boomsoort?",
"es": "¿Es un árbol de hoja ancha o de hoja aguja?" "fr": "Quelle est l'espèce de cet arbre ?"
}, },
"mappings": [ "render": {
{ "*": "{wikipedia(species:wikidata):max-height: 25rem}"
"if": { },
"and": [ "freeform": {
"leaf_type=broadleaved" "key": "species:wikidata",
"type": "wikidata",
"helperArgs": [
"species",
{
"instanceOf": [
10884,
16521
] ]
},
"then": {
"nl": "Loofboom",
"en": "Broadleaved",
"it": "Latifoglia",
"fr": "Feuillu",
"de": "Laubbaum",
"ca": "De fulla ampla",
"es": "Latifoliada",
"id": "Berdaun lebar"
},
"icon": {
"path": "./assets/layers/tree_node/broadleaved.svg",
"class": "small"
} }
}, ]
{ }
"if": { },
"and": [ {
"leaf_type=needleleaved" "id": "tree-wikipedia",
] "#": "If this tree has a wikipedia article, show it. People can _only_ set the species though!",
}, "render": {
"then": { "*": "{wikipedia()}"
"nl": "Naaldboom", },
"en": "Needleleaved", "condition": {
"it": "Aghifoglia", "or": [
"fr": "Résineux", "wikipedia~*",
"de": "Nadelbaum", "wikidata~*"
"ca": "Amb fulles d'agulla", ]
"es": "Hoja aguja", }
"id": "Berdaun jarum"
},
"icon": {
"path": "./assets/layers/tree_node/needleleaved.svg",
"class": "small"
}
},
{
"if": {
"and": [
"leaf_type=leafless"
]
},
"then": {
"nl": "Permanent bladloos",
"en": "Permanently leafless",
"it": "Privo di foglie (permanente)",
"fr": "Sans feuilles (Permanent)",
"de": "Dauerhaft blattlos",
"es": "Permanentemente sin hojas",
"id": "Tanpa daun permanen"
},
"hideInAnswer": true,
"icon": {
"path": "./assets/layers/tree_node/leafless.svg",
"class": "small"
}
}
]
}, },
{ {
"id": "tree-denotation", "id": "tree-denotation",
@ -313,6 +277,88 @@
} }
] ]
}, },
{
"id": "tree-leaf_type",
"question": {
"nl": "Is dit een naald- of loofboom?",
"en": "Is this a broadleaved or needleleaved tree?",
"it": "Si tratta di un albero latifoglia o aghifoglia?",
"fr": "Cet arbre est-il un feuillu ou un résineux ?",
"de": "Ist dies ein Laub- oder Nadelbaum?",
"es": "¿Es un árbol de hoja ancha o de hoja aguja?"
},
"mappings": [
{
"if": {
"and": [
"leaf_type=broadleaved"
]
},
"then": {
"nl": "Loofboom",
"en": "Broadleaved",
"it": "Latifoglia",
"fr": "Feuillu",
"de": "Laubbaum",
"ca": "De fulla ampla",
"es": "Latifoliada",
"id": "Berdaun lebar"
},
"icon": {
"path": "./assets/layers/tree_node/broadleaved.svg",
"class": "small"
}
},
{
"if": {
"and": [
"leaf_type=needleleaved"
]
},
"then": {
"nl": "Naaldboom",
"en": "Needleleaved",
"it": "Aghifoglia",
"fr": "Résineux",
"de": "Nadelbaum",
"ca": "Amb fulles d'agulla",
"es": "Hoja aguja",
"id": "Berdaun jarum"
},
"icon": {
"path": "./assets/layers/tree_node/needleleaved.svg",
"class": "small"
}
},
{
"if": {
"and": [
"leaf_type=leafless"
]
},
"then": {
"nl": "Permanent bladloos",
"en": "Permanently leafless",
"it": "Privo di foglie (permanente)",
"fr": "Sans feuilles (Permanent)",
"de": "Dauerhaft blattlos",
"es": "Permanentemente sin hojas",
"id": "Tanpa daun permanen"
},
"hideInAnswer": true,
"icon": {
"path": "./assets/layers/tree_node/leafless.svg",
"class": "small"
}
}
],
"condition": {
"#": "If the wikidata entry is known, no need to ask for redundant data such as leaf type",
"and": [
"species:wikidata="
]
}
},
{ {
"id": "tree-decidouous", "id": "tree-decidouous",
"question": { "question": {
@ -360,48 +406,10 @@
} }
], ],
"condition": { "condition": {
"#": "If the wikidata entry is known, no need to ask for redundant data such as leaf type",
"and": [ "and": [
"leaf_type!~^leafless$" "leaf_type!~^leafless$",
] "species:wikidata="
}
},
{
"id": "tree-species-wikidata",
"question": {
"en": "What species is this tree?",
"de": "Um welche Baumart handelt es sich?",
"id": "Spesies pohon apa ini?",
"es": "¿De qué especie es este árbol?",
"nl": "Wat is de boomsoort?",
"fr": "Quelle est l'espèce de cet arbre ?"
},
"render": {
"*": "{wikipedia(species:wikidata):max-height: 25rem}"
},
"freeform": {
"key": "species:wikidata",
"type": "wikidata",
"helperArgs": [
"species",
{
"instanceOf": [
10884,
16521
]
}
]
}
},
{
"id": "tree-wikipedia",
"#": "If this tree has a wikipedia article, show it. People can _only_ set the species though!",
"render": {
"*": "{wikipedia()}"
},
"condition": {
"or": [
"wikipedia~*",
"wikidata~*"
] ]
} }
}, },