New graphs; add missing_editor list

Docs/Tools/GenerateSeries.ts

@@ -707,16 +707,25 @@ async function main(): Promise<void>{
         mkdirSync("graphs")
     }
     
-    await new StatsDownloader("stats").DownloadStats()
+    if(process.argv.indexOf("--no-download") < 0){
+        await new StatsDownloader("stats").DownloadStats()
+    }
     const allPaths = readdirSync("stats")
         .filter(p => p.startsWith("stats.") && p.endsWith(".json"));
     let allFeatures: ChangeSetData[] = [].concat(...allPaths
-        .map(path => JSON.parse(readFileSync("stats/" + path, "utf-8")).features
+                .map(path => JSON.parse(readFileSync("stats/" + path, "utf-8")).features
             .map(cs => ChangesetDataTools.cleanChangesetData(cs))));
+    allFeatures = allFeatures.filter(f => f.properties.editor === null || f.properties.editor.toLowerCase().startsWith("mapcomplete"))
 
     const emptyCS = allFeatures.filter(f => f.properties.metadata.theme === "EMPTY CS")
     allFeatures = allFeatures.filter(f => f.properties.metadata.theme !== "EMPTY CS")
+    
+    const noEditor = allFeatures.filter(f => f.properties.editor === null).map(f =>"https://www.osm.org/changeset/"+ f.id)
+    writeFileSync("missing_editor.json", JSON.stringify(noEditor, null, "  "));
 
+    if(process.argv.indexOf("--no-graphs") >= 0){
+       return
+    }
     createMiscGraphs(allFeatures, emptyCS)
     createGraphs(allFeatures, "")
     // createGraphs(allFeatures.filter(f => f.properties.date.startsWith("2020")), " in 2020")

Docs/Tools/missing_editor.json

@@ -0,0 +1,12 @@
+[
+  "https://www.osm.org/changeset/117826283",
+  "https://www.osm.org/changeset/117742017",
+  "https://www.osm.org/changeset/117522028",
+  "https://www.osm.org/changeset/117244083",
+  "https://www.osm.org/changeset/117010979",
+  "https://www.osm.org/changeset/118422299",
+  "https://www.osm.org/changeset/118344062",
+  "https://www.osm.org/changeset/118281107",
+  "https://www.osm.org/changeset/118228793",
+  "https://www.osm.org/changeset/118092916"
+]

Docs/Tools/stats/stats.2022-1.json

@@ -1633,9 +1633,24 @@
       },
       "properties": {
         "check_user": null,
-        "reasons": [],
+        "reasons": [
+          {
+            "id": 489,
+            "name": "Mapbox: Spam text"
+          }
+        ],
         "tags": [],
-        "features": [],
+        "features": [
+          {
+            "url": "node-9461327137",
+            "note": "Spam text reported in [\"name\"] tags in the feature",
+            "osm_id": 9461327137,
+            "reasons": [
+              489
+            ],
+            "version": 1
+          }
+        ],
         "user": "nickinparadise",
         "uid": "2049708",
         "editor": "MapComplete 0.15.1",
@@ -1649,7 +1664,7 @@
         "modify": 0,
         "delete": 0,
         "area": 0,
-        "is_suspect": false,
+        "is_suspect": true,
         "harmful": null,
         "checked": false,
         "check_date": null,
@@ -8554,7 +8569,7 @@
         "uid": "12128135",
         "editor": "MapComplete 0.14.1",
         "comment": "Adding data with #MapComplete for theme #toerisme_vlaanderen",
-        "comments_count": 0,
+        "comments_count": 1,
         "source": "survey",
         "imagery_used": "Not reported",
         "date": "2022-01-23T14:25:12Z",
@@ -8563,7 +8578,7 @@
         "modify": 7,
         "delete": 1,
         "area": 0.00000264645007000264,
-        "is_suspect": true,
+        "is_suspect": false,
         "harmful": null,
         "checked": false,
         "check_date": null,
@@ -18493,10 +18508,27 @@
           {
             "id": 4,
             "name": "mass modification"
+          },
+          {
+            "id": 91,
+            "name": "Motorway/trunk geometry modified"
           }
         ],
         "tags": [],
-        "features": [],
+        "features": [
+          {
+            "url": "way-196714838",
+            "name": "Boulevard Louis Pasteur",
+            "osm_id": 196714838,
+            "reasons": [
+              91
+            ],
+            "version": 6,
+            "primary_tags": {
+              "highway": "trunk"
+            }
+          }
+        ],
         "user": "whatismoss",
         "uid": "8427311",
         "editor": "MapComplete 0.13.1",

Docs/Tools/stats/stats.2022-2.json

@@ -6069,6 +6069,72 @@
         "id": 117827426
       }
     },
+    {
+      "id": 117826283,
+      "type": "Feature",
+      "geometry": {
+        "type": "Polygon",
+        "coordinates": [
+          [
+            [
+              5.637074,
+              51.0559106
+            ],
+            [
+              5.637074,
+              51.0559106
+            ],
+            [
+              5.637074,
+              51.0559106
+            ],
+            [
+              5.637074,
+              51.0559106
+            ],
+            [
+              5.637074,
+              51.0559106
+            ]
+          ]
+        ]
+      },
+      "properties": {
+        "check_user": null,
+        "reasons": [
+          {
+            "id": 41,
+            "name": "Software editor was not declared"
+          }
+        ],
+        "tags": [],
+        "features": [],
+        "user": "kersentaart",
+        "uid": "9812520",
+        "editor": null,
+        "comment": "Adding data with #MapComplete for theme #toerisme_vlaanderen",
+        "comments_count": 0,
+        "source": "Not reported",
+        "imagery_used": "Not reported",
+        "date": "2022-02-24T20:11:06Z",
+        "reviewed_features": [],
+        "create": 1,
+        "modify": 1,
+        "delete": 0,
+        "area": 0,
+        "is_suspect": true,
+        "harmful": null,
+        "checked": false,
+        "check_date": null,
+        "metadata": {
+          "theme": "toerisme_vlaanderen",
+          "answer": 5,
+          "import": 1,
+          "import:node/9533221527": "source: https://osm.org/note/3044350"
+        },
+        "id": 117826283
+      }
+    },
     {
       "id": 117821852,
       "type": "Feature",
@@ -8559,6 +8625,77 @@
         "id": 117743877
       }
     },
+    {
+      "id": 117742017,
+      "type": "Feature",
+      "geometry": {
+        "type": "Polygon",
+        "coordinates": [
+          [
+            [
+              5.5572219,
+              51.1897337
+            ],
+            [
+              5.5625289,
+              51.1897337
+            ],
+            [
+              5.5625289,
+              51.1989127
+            ],
+            [
+              5.5572219,
+              51.1989127
+            ],
+            [
+              5.5572219,
+              51.1897337
+            ]
+          ]
+        ]
+      },
+      "properties": {
+        "check_user": null,
+        "reasons": [
+          {
+            "id": 40,
+            "name": "New mapper"
+          },
+          {
+            "id": 41,
+            "name": "Software editor was not declared"
+          }
+        ],
+        "tags": [],
+        "features": [],
+        "user": "RobbieRob F",
+        "uid": "14946603",
+        "editor": null,
+        "comment": "Adding data with #MapComplete for theme #toerisme_vlaanderen",
+        "comments_count": 0,
+        "source": "Not reported",
+        "imagery_used": "Not reported",
+        "date": "2022-02-22T19:44:51Z",
+        "reviewed_features": [],
+        "create": 3,
+        "modify": 0,
+        "delete": 0,
+        "area": 0.0000487129530000183,
+        "is_suspect": true,
+        "harmful": null,
+        "checked": false,
+        "check_date": null,
+        "metadata": {
+          "theme": "toerisme_vlaanderen",
+          "import": 3,
+          "import:node/9528129922": "source: https://osm.org/note/3044427",
+          "import:node/9528149205": "source: https://osm.org/note/3044255",
+          "import:node/9528150239": "source: https://osm.org/note/3044228"
+        },
+        "id": 117742017
+      }
+    },
     {
       "id": 117740296,
       "type": "Feature",
@@ -17741,6 +17878,74 @@
         "id": 117522251
       }
     },
+    {
+      "id": 117522028,
+      "type": "Feature",
+      "geometry": {
+        "type": "Polygon",
+        "coordinates": [
+          [
+            [
+              4.2323273,
+              51.1000423
+            ],
+            [
+              4.2323273,
+              51.1000423
+            ],
+            [
+              4.2323273,
+              51.1000423
+            ],
+            [
+              4.2323273,
+              51.1000423
+            ],
+            [
+              4.2323273,
+              51.1000423
+            ]
+          ]
+        ]
+      },
+      "properties": {
+        "check_user": null,
+        "reasons": [
+          {
+            "id": 41,
+            "name": "Software editor was not declared"
+          }
+        ],
+        "tags": [],
+        "features": [],
+        "user": "Pieter Vander Vennet",
+        "uid": "3818858",
+        "editor": null,
+        "comment": "Adding data with #MapComplete for theme #toerisme_vlaanderen",
+        "comments_count": 0,
+        "source": "Not reported",
+        "imagery_used": "Not reported",
+        "date": "2022-02-17T13:36:16Z",
+        "reviewed_features": [],
+        "create": 1,
+        "modify": 0,
+        "delete": 1,
+        "area": 0,
+        "is_suspect": true,
+        "harmful": null,
+        "checked": false,
+        "check_date": null,
+        "metadata": {
+          "theme": "toerisme_vlaanderen",
+          "import": 1,
+          "deletion": 1,
+          "change_over_5000m": 2,
+          "import:node/9513916030": "source: https://osm.org/note/3023056",
+          "deletion:node/9513916030": "testing point"
+        },
+        "id": 117522028
+      }
+    },
     {
       "id": 117521968,
       "type": "Feature",
@@ -29352,6 +29557,72 @@
         "id": 117288194
       }
     },
+    {
+      "id": 117287043,
+      "type": "Feature",
+      "geometry": {
+        "type": "Polygon",
+        "coordinates": [
+          [
+            [
+              1.6461941,
+              42.9169099
+            ],
+            [
+              1.646608,
+              42.9169099
+            ],
+            [
+              1.646608,
+              42.9171661
+            ],
+            [
+              1.6461941,
+              42.9171661
+            ],
+            [
+              1.6461941,
+              42.9169099
+            ]
+          ]
+        ]
+      },
+      "properties": {
+        "check_user": null,
+        "reasons": [
+          {
+            "id": 40,
+            "name": "New mapper"
+          }
+        ],
+        "tags": [],
+        "features": [],
+        "user": "rejbzh",
+        "uid": "15051154",
+        "editor": "iD 2.20.4",
+        "comment": "Adding data with #MapComplete for theme #surveillance",
+        "comments_count": 0,
+        "source": "Not reported",
+        "imagery_used": "BDOrtho IGN",
+        "date": "2022-02-11T12:54:27Z",
+        "reviewed_features": [],
+        "create": 1,
+        "modify": 1,
+        "delete": 0,
+        "area": 1.06041180001093e-7,
+        "is_suspect": true,
+        "harmful": null,
+        "checked": false,
+        "check_date": null,
+        "metadata": {
+          "host": "https://www.openstreetmap.org/edit",
+          "locale": "fr",
+          "hashtags": "#MapComplete;#surveillance",
+          "changesets_count": 7
+        },
+        "id": 117287043
+      }
+    },
     {
       "id": 117286674,
       "type": "Feature",
@@ -30620,6 +30891,72 @@
         "id": 117256167
       }
     },
+    {
+      "id": 117256030,
+      "type": "Feature",
+      "geometry": {
+        "type": "Polygon",
+        "coordinates": [
+          [
+            [
+              1.6573136,
+              42.9146837
+            ],
+            [
+              1.6716781,
+              42.9146837
+            ],
+            [
+              1.6716781,
+              42.917024
+            ],
+            [
+              1.6573136,
+              42.917024
+            ],
+            [
+              1.6573136,
+              42.9146837
+            ]
+          ]
+        ]
+      },
+      "properties": {
+        "check_user": null,
+        "reasons": [
+          {
+            "id": 40,
+            "name": "New mapper"
+          }
+        ],
+        "tags": [],
+        "features": [],
+        "user": "rejbzh",
+        "uid": "15051154",
+        "editor": "iD 2.20.4",
+        "comment": "Adding data with #MapComplete for theme #surveillance",
+        "comments_count": 0,
+        "source": "Not reported",
+        "imagery_used": "BDOrtho IGN",
+        "date": "2022-02-10T17:42:34Z",
+        "reviewed_features": [],
+        "create": 0,
+        "modify": 2,
+        "delete": 0,
+        "area": 0.0000336172393500029,
+        "is_suspect": true,
+        "harmful": null,
+        "checked": false,
+        "check_date": null,
+        "metadata": {
+          "host": "https://www.openstreetmap.org/edit",
+          "locale": "fr",
+          "hashtags": "#MapComplete;#surveillance",
+          "changesets_count": 6
+        },
+        "id": 117256030
+      }
+    },
     {
       "id": 117254536,
       "type": "Feature",
@@ -30682,6 +31019,72 @@
         "id": 117254536
       }
     },
+    {
+      "id": 117253731,
+      "type": "Feature",
+      "geometry": {
+        "type": "Polygon",
+        "coordinates": [
+          [
+            [
+              1.6402526,
+              42.9134642
+            ],
+            [
+              1.6656386,
+              42.9134642
+            ],
+            [
+              1.6656386,
+              42.9188424
+            ],
+            [
+              1.6402526,
+              42.9188424
+            ],
+            [
+              1.6402526,
+              42.9134642
+            ]
+          ]
+        ]
+      },
+      "properties": {
+        "check_user": null,
+        "reasons": [
+          {
+            "id": 40,
+            "name": "New mapper"
+          }
+        ],
+        "tags": [],
+        "features": [],
+        "user": "rejbzh",
+        "uid": "15051154",
+        "editor": "iD 2.20.4",
+        "comment": "Adding data with #MapComplete for theme #surveillance",
+        "comments_count": 0,
+        "source": "Not reported",
+        "imagery_used": "BDOrtho IGN",
+        "date": "2022-02-10T16:38:38Z",
+        "reviewed_features": [],
+        "create": 8,
+        "modify": 4,
+        "delete": 3,
+        "area": 0.000136530985200068,
+        "is_suspect": true,
+        "harmful": null,
+        "checked": false,
+        "check_date": null,
+        "metadata": {
+          "host": "https://www.openstreetmap.org/edit",
+          "locale": "fr",
+          "hashtags": "#MapComplete;#surveillance",
+          "changesets_count": 5
+        },
+        "id": 117253731
+      }
+    },
     {
       "id": 117252707,
       "type": "Feature",
@@ -31126,6 +31529,77 @@
         "id": 117244900
       }
     },
+    {
+      "id": 117244083,
+      "type": "Feature",
+      "geometry": {
+        "type": "Polygon",
+        "coordinates": [
+          [
+            [
+              5.1852899,
+              50.9119365
+            ],
+            [
+              5.2098409,
+              50.9119365
+            ],
+            [
+              5.2098409,
+              50.9361395
+            ],
+            [
+              5.1852899,
+              50.9361395
+            ],
+            [
+              5.1852899,
+              50.9119365
+            ]
+          ]
+        ]
+      },
+      "properties": {
+        "check_user": null,
+        "reasons": [
+          {
+            "id": 40,
+            "name": "New mapper"
+          },
+          {
+            "id": 41,
+            "name": "Software editor was not declared"
+          }
+        ],
+        "tags": [],
+        "features": [],
+        "user": "jospyck",
+        "uid": "12128135",
+        "editor": null,
+        "comment": "Adding data with #MapComplete for theme #toerisme_vlaanderen",
+        "comments_count": 0,
+        "source": "Not reported",
+        "imagery_used": "Not reported",
+        "date": "2022-02-10T12:27:22Z",
+        "reviewed_features": [],
+        "create": 2,
+        "modify": 5,
+        "delete": 0,
+        "area": 0.000594207852999994,
+        "is_suspect": true,
+        "harmful": null,
+        "checked": false,
+        "check_date": null,
+        "metadata": {
+          "theme": "toerisme_vlaanderen",
+          "answer": 12,
+          "import": 2,
+          "import:node/9495257973": "source: https://osm.org/note/3044279",
+          "import:node/9495282428": "source: https://osm.org/note/3044139"
+        },
+        "id": 117244083
+      }
+    },
     {
       "id": 117238352,
       "type": "Feature",
@@ -39732,6 +40206,76 @@
         "id": 117011189
       }
     },
+    {
+      "id": 117010979,
+      "type": "Feature",
+      "geometry": {
+        "type": "Polygon",
+        "coordinates": [
+          [
+            [
+              4.4794074,
+              51.0276134
+            ],
+            [
+              4.4794074,
+              51.0276134
+            ],
+            [
+              4.4794074,
+              51.0276134
+            ],
+            [
+              4.4794074,
+              51.0276134
+            ],
+            [
+              4.4794074,
+              51.0276134
+            ]
+          ]
+        ]
+      },
+      "properties": {
+        "check_user": null,
+        "reasons": [
+          {
+            "id": 40,
+            "name": "New mapper"
+          },
+          {
+            "id": 41,
+            "name": "Software editor was not declared"
+          }
+        ],
+        "tags": [],
+        "features": [],
+        "user": "jospyck",
+        "uid": "12128135",
+        "editor": null,
+        "comment": "Adding data with #MapComplete for theme #toerisme_vlaanderen",
+        "comments_count": 3,
+        "source": "Not reported",
+        "imagery_used": "Not reported",
+        "date": "2022-02-04T15:22:45Z",
+        "reviewed_features": [],
+        "create": 1,
+        "modify": 1,
+        "delete": 0,
+        "area": 0,
+        "is_suspect": true,
+        "harmful": null,
+        "checked": false,
+        "check_date": null,
+        "metadata": {
+          "theme": "toerisme_vlaanderen",
+          "answer": 3,
+          "import": 1,
+          "import:node/9476264469": "source: https://osm.org/note/3023001"
+        },
+        "id": 117010979
+      }
+    },
     {
       "id": 117009200,
       "type": "Feature",