Bastian-Greshake-Tzovaras/MapComplete
1
0
Fork 0
forked from MapComplete/MapComplete
Code Pull requests Activity

Add check to NSI-logos: validate output from Facebook

Browse source
This commit is contained in:
Pieter Vander Vennet 2024-07-29 03:16:35 +02:00
parent 3c3db7f933
commit 2af6448156
1 changed files with 9 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

11
scripts/downloadNsiLogos.ts
View file

@ -1,7 +1,7 @@
import Script from "./Script"
import NameSuggestionIndex, { NSIItem } from "../src/Logic/Web/NameSuggestionIndex"
import * as nsiWD from "../node_modules/name-suggestion-index/dist/wikidata.min.json"
import { existsSync, writeFileSync } from "fs"
import { existsSync, readFileSync, unlinkSync, writeFileSync } from "fs"
import ScriptUtils from "./ScriptUtils"
import { Utils } from "../src/Utils"
@ -41,7 +41,14 @@ class DownloadNsiLogos extends Script {
if (logos.facebook) {
// Facebook's logos are generally better and square
await ScriptUtils.DownloadFileTo(logos.facebook, path)
return true
// Validate
const content = readFileSync(path, "utf8")
if(content.startsWith('{"error"')){
unlinkSync(path)
console.error("Attempted to fetch",logos.facebook," but this gave an error")
}else{
return true
}
}
if (logos.wikidata) {
let url: string = logos.wikidata