Better social images

This commit is contained in:
Pieter Vander Vennet 2022-03-08 04:09:03 +01:00
parent 54158767d2
commit 135d8644da
25 changed files with 6032 additions and 668 deletions

View file

@ -8,6 +8,7 @@ import {LayoutConfigJson} from "../Models/ThemeConfig/Json/LayoutConfigJson";
import LayoutConfig from "../Models/ThemeConfig/LayoutConfig";
import xml2js from 'xml2js';
import ScriptUtils from "./ScriptUtils";
import {Utils} from "../Utils";
const sharp = require('sharp');
const template = readFileSync("theme.html", "utf8");
@ -19,72 +20,126 @@ function enc(str: string): string {
}
async function createIcon(iconPath: string, size: number, alreadyWritten: string[]) {
let name = iconPath.split(".").slice(0, -1).join(".");
let name = iconPath.split(".").slice(0, -1).join("."); // drop svg suffix
if (name.startsWith("./")) {
name = name.substr(2)
}
const newname = `${name}${size}.png`
.replace(/\//g, "_")
.replace("assets_", "assets/generated/");
const newname = `assets/generated/images${name.substring(name.lastIndexOf("/"))}${size}.png`;
if (alreadyWritten.indexOf(newname) >= 0) {
return newname;
}
alreadyWritten.push(newname);
try {
readFileSync(newname);
return newname; // File already exists - nothing to do
} catch (e) {
// Errors are normal here if this file does not exists
if (existsSync(newname)) {
return newname
}
if (!existsSync(iconPath)) {
throw "No file at " + iconPath
}
try {
// We already read to file, in order to crash here if the file is not found
readFileSync(iconPath);
let img = await sharp(iconPath)
let resized = await img.resize(size)
await resized.toFile(newname)
console.log("Written", newname)
} catch (e) {
console.error("Could not read icon", iconPath, "due to", e)
console.error("Could not read icon", iconPath, " to create a PNG due to", e)
}
return newname;
}
async function createManifest(layout: LayoutConfig, alreadyWritten: string[]) {
async function createSocialImage(layout: LayoutConfig, template: "" | "Wide"): Promise<string> {
if (!layout.icon.endsWith(".svg")) {
console.warn("Not creating a social image for " + layout.id + " as it is _not_ a .svg: " + layout.icon)
return undefined
}
const path = `./assets/generated/images/social_image_${layout.id}_${template}.svg`
if(existsSync(path)){
// return path;
}
const svg = await ScriptUtils.ReadSvg(layout.icon)
let width: string = svg.$.width;
if (width === undefined) {
throw "The logo at " + layout.icon + " does not have a defined width"
}
if (width?.endsWith("px")) {
width = width.substring(0, width.length - 2)
}
if (width?.endsWith("%")) {
throw "The logo at " + layout.icon + " has a relative width; this is not supported"
}
delete svg["defs"]
delete svg["$"]
let templateSvg = await ScriptUtils.ReadSvg("./assets/SocialImageTemplate" + template + ".svg")
templateSvg = Utils.WalkJson(templateSvg,
(leaf) => {
const {cx, cy, r} = leaf["circle"][0].$
return {
$: {
id: "icon",
transform: `translate(${cx - r},${cy - r}) scale(${(r * 2) / Number(width)}) `
},
g: [svg]
}
},
(mightBeTokenToReplace) => {
if (mightBeTokenToReplace?.circle === undefined) {
return false
}
return mightBeTokenToReplace.circle[0]?.$?.style?.indexOf("fill:#ff00ff") >= 0
}
)
const builder = new xml2js.Builder();
const xml = builder.buildObject({svg: templateSvg});
writeFileSync(path, xml)
console.log("Written", path)
return path
}
async function createManifest(layout: LayoutConfig, alreadyWritten: string[]): Promise<{
manifest: any,
whiteIcons: string[]
}> {
const name = layout.id;
Translation.forcedLanguage = "en"
const icons = [];
const whiteIcons: string[] = []
let icon = layout.icon;
if (icon.endsWith(".svg") || icon.startsWith("<svg") || icon.startsWith("<?xml")) {
// This is an svg. Lets create the needed pngs and do some checkes!
const whiteBackgroundPath = "./assets/generated/theme_"+layout.id+"_white_background.svg"
const whiteBackgroundPath = "./assets/generated/images/theme_" + layout.id + "_white_background.svg"
{
const svg = await ScriptUtils.ReadSvg(icon)
const width: string = svg.$.width;
const height: string = svg.$.height;
const builder = new xml2js.Builder();
const withRect = {rect: {"$":{width, height, style: "fill:#ffffff;"}}, ...svg}
const withRect = {rect: {"$": {width, height, style: "fill:#ffffff;"}}, ...svg}
const xml = builder.buildObject({svg: withRect});
writeFileSync(whiteBackgroundPath, xml)
}
let path = layout.icon;
if (layout.icon.startsWith("<")) {
// THis is already the svg
path = "./assets/generated/" + layout.id + "_logo.svg"
path = "./assets/generated/images/" + layout.id + "_logo.svg"
writeFileSync(path, layout.icon)
}
const sizes = [72, 96, 120, 128, 144, 152, 180, 192, 384, 512];
for (const size of sizes) {
const name = await createIcon(path, size, alreadyWritten);
await createIcon(whiteBackgroundPath, size, alreadyWritten)
const whiteIcon = await createIcon(whiteBackgroundPath, size, alreadyWritten)
whiteIcons.push(whiteIcon)
icons.push({
src: name,
sizes: size + "x" + size,
@ -109,7 +164,7 @@ async function createManifest(layout: LayoutConfig, alreadyWritten: string[]) {
const ogTitle = Translations.WT(layout.title).txt;
const ogDescr = Translations.WT(layout.description ?? "").txt;
return {
const manifest = {
name: name,
short_name: ogTitle,
start_url: `${layout.id.toLowerCase()}.html`,
@ -121,15 +176,32 @@ async function createManifest(layout: LayoutConfig, alreadyWritten: string[]) {
icons: icons,
categories: ["map", "navigation"]
};
return {
manifest,
whiteIcons
}
}
async function createLandingPage(layout: LayoutConfig, manifest) {
async function createLandingPage(layout: LayoutConfig, manifest, whiteIcons, alreadyWritten) {
Locale.language.setData(layout.language[0]);
const targetLanguage = layout.language[0]
const ogTitle = Translations.WT(layout.title).textFor(targetLanguage).replace(/"/g, '\\"');
const ogDescr = Translations.WT(layout.shortDescription ?? "Easily add and edit geodata with OpenStreetMap").textFor(targetLanguage).replace(/"/g, '\\"');
const ogImage = layout.socialImage;
let ogImage = layout.socialImage;
let twitterImage = ogImage
if (ogImage === LayoutConfig.defaultSocialImage && layout.official) {
ogImage = await createSocialImage(layout, "") ?? layout.socialImage
twitterImage = await createSocialImage(layout, "Wide") ?? layout.socialImage
}
if (twitterImage.endsWith(".svg")) {
// svgs are badly supported as social image, we use a generated svg instead
twitterImage = await createIcon(twitterImage, 512, alreadyWritten);
}
if(ogImage.endsWith(".svg")){
ogImage = await createIcon(ogImage, 512, alreadyWritten)
}
let customCss = "";
if (layout.customCss !== undefined && layout.customCss !== "") {
@ -147,29 +219,26 @@ async function createLandingPage(layout: LayoutConfig, manifest) {
<meta property="og:title" content="${ogTitle}">
<meta property="og:description" content="${ogDescr}">
<meta name="twitter:card" content="summary_large_image">
<meta name="twitter:site" content="@mapcomplete.osm;be">
<meta name="twitter:site" content="@mapcomplete.osm.be">
<meta name="twitter:creator" content="@pietervdvn">
<meta name="twitter:title" content="${ogTitle}">
<meta name="twitter:description" content="${ogDescr}">
<meta name="twitter:image" content="${ogImage}">`
<meta name="twitter:image" content="${twitterImage}">`
let icon = layout.icon;
if (icon.startsWith("<?xml") || icon.startsWith("<svg")) {
// This already is an svg
icon = `./assets/generated/${layout.id}_icon.svg`
icon = `./assets/generated/images/${layout.id}_icon.svg`
writeFileSync(icon, layout.icon);
}
const apple_icons = []
for (const icon of manifest.icons) {
if (icon.type !== "image/png") {
continue;
}
const whiteBgPath = `./assets/generated/generated_theme_${layout.id}_white_background${icon.sizes.substr(icon.sizes.indexOf("x")+ 1)}.png`
if(!existsSync(whiteBgPath)){
for (const icon of whiteIcons) {
if (!existsSync(icon)) {
continue
}
apple_icons.push(`<link rel="apple-touch-icon" sizes="${icon.sizes}" href="${whiteBgPath}">`)
const size = icon.replace(/[^0-9]/g, "")
apple_icons.push(`<link rel="apple-touch-icon" sizes="${size}x${size}" href="${icon}">`)
}
let themeSpecific = [
@ -206,31 +275,32 @@ async function createIndexFor(theme: LayoutConfig) {
appendFileSync(filename, codeTemplate)
}
function createDir(path){
function createDir(path) {
if (!existsSync(path)) {
mkdirSync(path)
}
}
async function main(): Promise<void>{
async function main(): Promise<void> {
const alreadyWritten = []
createDir("./assets/generated")
createDir("./assets/generated/layers")
createDir("./assets/generated/themes")
createDir("./assets/generated/images")
const blacklist = ["", "test", ".", "..", "manifest", "index", "land", "preferences", "account", "openstreetmap", "custom", "theme"]
// @ts-ignore
const all: LayoutConfigJson[] = all_known_layouts.themes;
const args = process.argv
const theme = args[2]
if(theme !== undefined){
console.warn("Only generating layout "+theme)
if (theme !== undefined) {
console.warn("Only generating layout " + theme)
}
for (const i in all) {
const layoutConfigJson: LayoutConfigJson = all[i]
if(theme !== undefined && layoutConfigJson.id !== theme){
if (theme !== undefined && layoutConfigJson.id !== theme) {
continue
}
const layout = new LayoutConfig(layoutConfigJson, true, "generating layouts")
@ -244,21 +314,20 @@ async function main(): Promise<void>{
console.log("Could not write manifest for ", layoutName, " because ", err)
}
};
await createManifest(layout, alreadyWritten).then(manifObj => {
const manif = JSON.stringify(manifObj, undefined, 2);
const manifestLocation = encodeURIComponent(layout.id.toLowerCase()) + ".webmanifest";
writeFile(manifestLocation, manif, err);
// Create a landing page for the given theme
createLandingPage(layout, manifObj).then(landing => {
writeFile(enc(layout.id) + ".html", landing, err)
});
createIndexFor(layout)
}).catch(e => console.log("Could not generate the manifest: ", e))
const {manifest, whiteIcons} = await createManifest(layout, alreadyWritten)
const manif = JSON.stringify(manifest, undefined, 2);
const manifestLocation = encodeURIComponent(layout.id.toLowerCase()) + ".webmanifest";
writeFile(manifestLocation, manif, err);
// Create a landing page for the given theme
createLandingPage(layout, manifest, whiteIcons, alreadyWritten).then(landing => {
writeFile(enc(layout.id) + ".html", landing, err)
});
createIndexFor(layout)
}
await createManifest(new LayoutConfig({
const {manifest, whiteIcons} = await createManifest(new LayoutConfig({
icon: "./assets/svg/mapcomplete_logo.svg",
id: "index",
layers: [],
@ -270,10 +339,10 @@ async function main(): Promise<void>{
title: {en: "MapComplete"},
version: Constants.vNumber,
description: {en: "A thematic map viewer and editor based on OpenStreetMap"}
}), alreadyWritten).then(manifObj => {
const manif = JSON.stringify(manifObj, undefined, 2);
writeFileSync("index.manifest", manif)
})
}), alreadyWritten);
const manif = JSON.stringify(manifest, undefined, 2);
writeFileSync("index.manifest", manif)
}
main().then(() => {