diff --git a/2_obtain_atp_data.py b/2_obtain_atp_data.py index 811a044..b42bb5f 100644 --- a/2_obtain_atp_data.py +++ b/2_obtain_atp_data.py @@ -183,12 +183,11 @@ def do_not_remind_that_this_tagging_may_be_worth_supporting(): notified_about_tag['shop'].append('truck_parts') # seems to be from NSI? https://wiki.openstreetmap.org/wiki/Tag:shop%3Dtruck_parts has no page # kind also shoplike? I want to support them - notified_about_tag['man_made'].append('charge_point') - notified_about_tag['amenity'].append('music_venue') - notified_about_tag['amenity'].append('prep_school') - notified_about_tag['amenity'].append('conference_centre') - # shoplike in sense you can get food there I guess? - notified_about_tag['amenity'].append('food_sharing') + # requires change to osm_bot_abstraction_layer.tag_knowledge.is_shoplike + # should be done before planet file is processed + # to avoid situation where OSM-processing skipped such POI + # and ATP processing included them + pass # not shoplike but having it would be nice notified_about_tag['amenity'].append('community_centre') diff --git a/test_detecting_elements_as_in_scope_as_shops_and_similar.py b/test_detecting_elements_as_in_scope_as_shops_and_similar.py new file mode 100644 index 0000000..08dcfc1 --- /dev/null +++ b/test_detecting_elements_as_in_scope_as_shops_and_similar.py @@ -0,0 +1,8 @@ +import unittest +import qa +import osm_bot_abstraction_layer.tag_knowledge as tag_knowledge + + +class ShoplikeTests(unittest.TestCase): + def test_basic_passing_shoplike(self): + self.assertEqual(tag_knowledge.is_shoplike({"shop": "supermarket"}), True)