diff --git a/Models/ThemeConfig/Conversion/Validation.ts b/Models/ThemeConfig/Conversion/Validation.ts index bcc24c6b79..df2b80e224 100644 --- a/Models/ThemeConfig/Conversion/Validation.ts +++ b/Models/ThemeConfig/Conversion/Validation.ts @@ -520,6 +520,10 @@ export class ValidateLayer extends DesugaringStep { errors } } + + if(json.title === undefined && json.tagRenderings !== undefined){ + warnings.push(context + ": this layer does not have a title defined but it does have tagRenderings. Not having a title will disable the popups, resulting in an unclickable element.") + } if (json["builtin"] !== undefined) { errors.push(context + ": This layer hasn't been expanded: " + json) diff --git a/assets/layers/elevator/elevator.json b/assets/layers/elevator/elevator.json index 2db635ffdb..e979a4a8fb 100644 --- a/assets/layers/elevator/elevator.json +++ b/assets/layers/elevator/elevator.json @@ -7,12 +7,39 @@ "osmTags": "highway=elevator" }, "minzoom": 13, + "title": { + "en": "Elevator" + }, "tagRenderings": [ "images", + { + "id": "operational_status", + "mappings": [ + { + "if": "operational_status=broken", + "then": { + "en": "This elevator is broken" + } + }, + { + "if": "operational_status=ok", + "then": { + "en": "This elevator works" + } + }, + { + "if": "operational_status=", + "then": { + "en": "This elevator works" + }, + "hideInAnswer": true + } + ] + }, { "id": "door-width", "render": { - "en": "This elevator's doors have a width of {canonical(door:width) }" + "en": "This elevator's doors have a width of {canonical(door:width)}" }, "question": { "en": "What is the width of this elevator's entrance?" @@ -25,7 +52,7 @@ { "id": "elevator-width", "render": { - "en": "This elevator has a width of {canonical(elevator:width) }" + "en": "This elevator has a width of {canonical(elevator:width)}" }, "question": { "en": "What is the width of this elevator?" @@ -38,7 +65,7 @@ { "id": "elevator-depth", "render": { - "en": "This elevator has a depth of {canonical(elevator:depth) }" + "en": "This elevator has a depth of {canonical(elevator:depth)}" }, "question": { "en": "What is the depth of this elevator?" @@ -47,12 +74,13 @@ "key": "elevator:depth", "type": "pfloat" } - } + }, + "induction-loop" ], "mapRendering": [ { "icon": { - "render": "./assets/layers/elevator/elevator_wheelchair.svg" + "render": "circle:white;./assets/layers/elevator/elevator_wheelchair.svg" }, "iconSize": "40,40,bottom", "location": [ diff --git a/assets/layers/elevator/elevator_wheelchair.svg b/assets/layers/elevator/elevator_wheelchair.svg index 35b934aeef..5ad6ee402d 100644 --- a/assets/layers/elevator/elevator_wheelchair.svg +++ b/assets/layers/elevator/elevator_wheelchair.svg @@ -1 +1,55 @@ - \ No newline at end of file + + + + + + + + + + + + + + + diff --git a/assets/layers/entrance/entrance.json b/assets/layers/entrance/entrance.json index 0533936342..9bd4476a4a 100644 --- a/assets/layers/entrance/entrance.json +++ b/assets/layers/entrance/entrance.json @@ -358,7 +358,7 @@ }, "mappings": [ { - "if": "kerb-height=", + "if": "kerb:height=0", "then": { "en": "This door does not have a kerb", "nl": "Deze deur heeft geen drempel" diff --git a/assets/layers/toilet/toilet.json b/assets/layers/toilet/toilet.json index 5dfeb438d4..794824f3f0 100644 --- a/assets/layers/toilet/toilet.json +++ b/assets/layers/toilet/toilet.json @@ -277,6 +277,21 @@ } ] }, + { + "id": "wheelchair-door-width", + "question": { + "en": "What is the width of the door to the wheelchair accessible toilet?", + "nl": "Hoe breed is de deur van de rolstoeltoegankelijke toilet?" + }, + "render": { + "en": "The door to the wheelchair-accessible toilet is {canonical(door:width)} wide", + "nl": "De deur naar de rolstoeltoegankelijke toilet is {canonical(door:width)} wide" + }, + "freeform": { + "key": "door:width", + "type": "pfloat" + } + }, { "id": "toilets-type", "question": { @@ -625,5 +640,35 @@ "nl": "Een laag die publieke toiletten toont", "de": "Eine Ebene mit (öffentlichen) Toiletten", "es": "Una capa que muestra baños (públicos)" - } + }, + "units": [ + { + "appliesToKey": [ + "door:width" + ], + "applicableUnits": [ + { + "canonicalDenomination": "m", + "alternativeDenomination": [ + "meter" + ], + "human": { + "en": "meter", + "nl": "meter" + } + }, + { + "canonicalDenomination": "cm", + "alternativeDenomination": [ + "centimeter", + "cms" + ], + "human": { + "en": "centimeter", + "nl": "centimeter" + } + } + ] + } + ] } \ No newline at end of file