From dfce217288957be2b27c198d640fd2dd5d53c9fb Mon Sep 17 00:00:00 2001 From: Pieter Vander Vennet Date: Tue, 24 Sep 2024 16:39:45 +0200 Subject: [PATCH 1/2] Themes(vending_machine): add better 'fixme' if freeform for 'vending' is used --- assets/layers/vending_machine/vending_machine.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/assets/layers/vending_machine/vending_machine.json b/assets/layers/vending_machine/vending_machine.json index 779b92bd91..d148f7c3a5 100644 --- a/assets/layers/vending_machine/vending_machine.json +++ b/assets/layers/vending_machine/vending_machine.json @@ -372,7 +372,7 @@ "freeform": { "key": "vending", "addExtraTags": [ - "fixme=Freeform input used, value may need to be checked" + "fixme=A mapcomplete user used the text field to set the 'vending'-tag, which is probably incorrect (e.g. might be in the local language, use upercase, ...)" ] }, "render": { From 7a892480ccf1dc18e658243674aa98c71eda234f Mon Sep 17 00:00:00 2001 From: Pieter Vander Vennet Date: Tue, 24 Sep 2024 16:39:58 +0200 Subject: [PATCH 2/2] Chore: add sanity check on tag length --- src/Logic/Tags/Tag.ts | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/Logic/Tags/Tag.ts b/src/Logic/Tags/Tag.ts index a941ab427e..40bb10c1cd 100644 --- a/src/Logic/Tags/Tag.ts +++ b/src/Logic/Tags/Tag.ts @@ -19,6 +19,9 @@ export class Tag extends TagsFilter { if (value === undefined) { throw `Invalid value while constructing a Tag with key '${key}': value is undefined` } + if(value.length > 255 || key.length > 255){ + throw "Invalid tag: length is over 255" + } if (value === "*") { console.warn(`Got suspicious tag ${key}=* ; did you mean ${key}~* ?`) }