From 300df3fb414a05e0d9481768590a7d2198db385c Mon Sep 17 00:00:00 2001
From: Pieter Vander Vennet <pietervdvn@posteo.net>
Date: Sat, 13 Jan 2024 03:42:07 +0100
Subject: [PATCH] More tests for OpeningHours.ts for edge cases

---
 src/UI/OpeningHours/OpeningHours.ts | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/src/UI/OpeningHours/OpeningHours.ts b/src/UI/OpeningHours/OpeningHours.ts
index 36abe120b9..25edb475eb 100644
--- a/src/UI/OpeningHours/OpeningHours.ts
+++ b/src/UI/OpeningHours/OpeningHours.ts
@@ -127,6 +127,11 @@ export class OH {
      * const oh1: OpeningHour = { weekday: 0, startHour: 10, startMinutes: 0, endHour: 11, endMinutes: 0 };
      * const oh0: OpeningHour = { weekday: 0, startHour: 11, startMinutes: 0, endHour: 12, endMinutes: 0 };
      * OH.MergeTimes([oh0, oh1]) // => [{ weekday: 0, startHour: 10, startMinutes: 0, endHour: 12, endMinutes: 0 }]
+     *
+     * // should merge touching opening hours spanning days
+     * const oh0: OpeningHour = { weekday: 0, startHour: 10, startMinutes: 0, endHour: 24, endMinutes: 0 };
+     * const oh1: OpeningHour = { weekday: 1, startHour: 0, startMinutes: 0, endHour: 12, endMinutes: 0 };
+     * OH.MergeTimes([oh0, oh1]) // => [{ weekday: 0, startHour: 10, startMinutes: 0, endHour: 24, endMinutes: 0 }, { weekday: 1, startHour: 0, startMinutes: 0, endHour: 12, endMinutes: 0 }]
      */
     public static MergeTimes(ohs: OpeningHour[]): OpeningHour[] {
         const queue = ohs.map((oh) => {
@@ -216,6 +221,7 @@ export class OH {
         // This means that the list is changed only if the lengths are different.
         // If the lengths are the same, we might just as well return the old list and be a bit more stable
         if (newList.length !== ohs.length) {
+            newList.sort((a, b) => b.weekday - a.weekday)
             return newList
         } else {
             return ohs
@@ -308,6 +314,12 @@ export class OH {
      * rules[1].weekday // => 1
      * rules[1].startHour // => 0
      * rules[1].endHour // => 2
+     *
+     * const rules = OH.ParseRule("Mo 00:00-24:00")
+     * rules.length // => 1
+     * rules[0].weekday // => 0
+     * rules[0].startHour // => 0
+     * rules[0].endHour // => 24
      */
     public static ParseRule(rule: string): OpeningHour[] {
         try {
@@ -781,6 +793,7 @@ This list will be sorted
     /**
      * OH.ParseHhmmRanges("20:00-22:15") // => [{startHour: 20, startMinutes: 0, endHour: 22, endMinutes: 15}]
      * OH.ParseHhmmRanges("20:00-02:15") // => [{startHour: 20, startMinutes: 0, endHour: 2, endMinutes: 15}]
+     * OH.ParseHhmmRanges("00:00-24:00") // => [{startHour: 0, startMinutes: 0, endHour: 24, endMinutes: 0}]
      */
     private static ParseHhmmRanges(hhmms: string): {
         startHour: number