From 028767afe6b04849d98292aa87516fccb0568a72 Mon Sep 17 00:00:00 2001 From: pietervdvn Date: Mon, 18 Oct 2021 22:34:52 +0200 Subject: [PATCH] Small cleanups --- Logic/ImageProviders/ImageProvider.ts | 2 -- UI/Wikipedia/WikidataPreviewBox.ts | 5 ++--- UI/i18n/Translation.ts | 5 +++++ 3 files changed, 7 insertions(+), 5 deletions(-) diff --git a/Logic/ImageProviders/ImageProvider.ts b/Logic/ImageProviders/ImageProvider.ts index cdf7a8e73b..592f9a1f0c 100644 --- a/Logic/ImageProviders/ImageProvider.ts +++ b/Logic/ImageProviders/ImageProvider.ts @@ -43,9 +43,7 @@ export default abstract class ImageProvider { const seenValues = new Set() allTags.addCallbackAndRunD(tags => { for (const key in tags) { - console.log("Does ", key,"have images?") if (!prefixes.some(prefix => key.startsWith(prefix))) { - console.log(key,": NO", this.constructor.name, "prefixes are", prefixes) continue } const values = Utils.NoEmpty(tags[key]?.split(";")?.map(v => v.trim()) ?? []) diff --git a/UI/Wikipedia/WikidataPreviewBox.ts b/UI/Wikipedia/WikidataPreviewBox.ts index bc70f2fefe..9358f3a830 100644 --- a/UI/Wikipedia/WikidataPreviewBox.ts +++ b/UI/Wikipedia/WikidataPreviewBox.ts @@ -52,11 +52,11 @@ export default class WikidataPreviewBox extends VariableUiElement { wikidata.id, Svg.wikidata_ui().SetStyle("width: 2.5rem").SetClass("block") ]).SetClass("flex"), - Wikidata.IdToArticle(wikidata.id), true).SetClass("must-link") + Wikidata.IdToArticle(wikidata.id), true)?.SetClass("must-link") let info = new Combine([ new Combine( - [Translation.fromMap(wikidata.labels).SetClass("font-bold"), + [Translation.fromMap(wikidata.labels)?.SetClass("font-bold"), link]).SetClass("flex justify-between"), Translation.fromMap(wikidata.descriptions), WikidataPreviewBox.QuickFacts(wikidata) @@ -147,7 +147,6 @@ export default class WikidataPreviewBox extends VariableUiElement { els.push(display.Subs({value: value.join(", ")}).SetClass("m-2")) continue } - console.log("Display:", display, "key:",key) const constructors = Utils.NoNull(value.map(property => display.get(property))) const elems = constructors.map(v => { if(typeof v === "string"){ diff --git a/UI/i18n/Translation.ts b/UI/i18n/Translation.ts index a4260a772f..87dddde40d 100644 --- a/UI/i18n/Translation.ts +++ b/UI/i18n/Translation.ts @@ -217,9 +217,14 @@ export class Translation extends BaseUIElement { static fromMap(transl: Map) { const translations = {} + let hasTranslation = false; transl?.forEach((value, key) => { translations[key] = value + hasTranslation = true }) + if(!hasTranslation){ + return undefined + } return new Translation(translations); } } \ No newline at end of file