From 87ab165e58472c4c88cf44c45f823706f1969c93 Mon Sep 17 00:00:00 2001 From: Pieter Vander Vennet Date: Sun, 26 Jan 2025 03:32:03 +0100 Subject: [PATCH] Fix: actually don't show grey loading placeholder for wikidata/wikipedia, add tests --- src/Logic/ImageProviders/AllImageProviders.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Logic/ImageProviders/AllImageProviders.ts b/src/Logic/ImageProviders/AllImageProviders.ts index 76f96737c9..a9a5d416b1 100644 --- a/src/Logic/ImageProviders/AllImageProviders.ts +++ b/src/Logic/ImageProviders/AllImageProviders.ts @@ -73,6 +73,8 @@ export default class AllImageProviders { * Will simply count all image tags * * AllImageProviders.estimateNumberOfImages({image:"abc", "mapillary": "123", "panoramax:0": "xyz"}) // => 3 + * AllImageProviders.estimateNumberOfImages({wikidata:"Q123", "wikipedia": "nl:xyz"}) // => 0 + * * */ public static estimateNumberOfImages(tags: Record, prefixes: string[] = undefined): number { @@ -80,8 +82,6 @@ export default class AllImageProviders { const sources = [Imgur.singleton, Mapillary.singleton, - WikidataImageProvider.singleton, - WikimediaImageProvider.singleton, Panoramax.singleton, AllImageProviders.genericImageProvider] const allPrefixes = Utils.Dedup(prefixes ?? [].concat(...sources.map(s => s.defaultKeyPrefixes)))