From 821ddcfaca11ca194b319bfa09f8b0a9fea01a41 Mon Sep 17 00:00:00 2001
From: Pieter Vander Vennet <pietervdvn@posteo.net>
Date: Mon, 2 Sep 2024 15:01:03 +0200
Subject: [PATCH] Themes: don't inline text fields if they don't have text
 around them

---
 src/Models/ThemeConfig/Conversion/PrepareLayer.ts | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/src/Models/ThemeConfig/Conversion/PrepareLayer.ts b/src/Models/ThemeConfig/Conversion/PrepareLayer.ts
index 1dbe005934..a206f653a1 100644
--- a/src/Models/ThemeConfig/Conversion/PrepareLayer.ts
+++ b/src/Models/ThemeConfig/Conversion/PrepareLayer.ts
@@ -541,6 +541,13 @@ class DetectInline extends DesugaringStep<QuestionableTagRenderingConfigJson> {
             context.err("'freeform' is a string, but should be an object")
             return json
         }
+
+        if(!Object.values(json.render).some(render => render !== "{"+json.freeform.key+"}")){
+            // We only render the current value, without anything more. Not worth inlining
+            return json
+        }
+
+
         json.freeform.inline ??= true
         return json
     }