From 79e40d0fee2e40b32babc218a374095f6ca520a5 Mon Sep 17 00:00:00 2001 From: Pieter Vander Vennet Date: Sun, 19 Nov 2023 18:08:57 +0100 Subject: [PATCH] Themes: add warning if a tagRendering can be replaced by a direct value --- src/Models/ThemeConfig/Conversion/Validation.ts | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/Models/ThemeConfig/Conversion/Validation.ts b/src/Models/ThemeConfig/Conversion/Validation.ts index 9002c3a9aa..59130c1e9e 100644 --- a/src/Models/ThemeConfig/Conversion/Validation.ts +++ b/src/Models/ThemeConfig/Conversion/Validation.ts @@ -813,6 +813,12 @@ class MiscTagRenderingChecks extends DesugaringStep { ) } + if (Object.keys(json).length === 1 && typeof json["render"] === "string") { + context.warn( + `use the content directly instead of {render: ${JSON.stringify(json["render"])}}` + ) + } + { for (const key of ["question", "questionHint", "render"]) { CheckTranslation.allowUndefined.convert(json[key], context.enter(key))