From 7234b339812d480eca0a940c1bcebede8397f896 Mon Sep 17 00:00:00 2001 From: Pieter Vander Vennet Date: Thu, 18 Jul 2024 20:53:15 +0200 Subject: [PATCH 1/5] Add firepit and bbq on nature theme --- assets/themes/nature/nature.json | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/assets/themes/nature/nature.json b/assets/themes/nature/nature.json index c92b0a0e1..b0475d90e 100644 --- a/assets/themes/nature/nature.json +++ b/assets/themes/nature/nature.json @@ -53,7 +53,9 @@ "picnic_table", "toilet", "guidepost", - "shelter" + "shelter", + "bbq", + "firepit" ], "override": { "minzoom": 16 @@ -61,4 +63,4 @@ } ], "widenFactor": 2 -} \ No newline at end of file +} From a4c429fafab314f63afec5b7e1565e4800577d06 Mon Sep 17 00:00:00 2001 From: Pieter Vander Vennet Date: Fri, 19 Jul 2024 11:23:05 +0200 Subject: [PATCH 2/5] Move glutenfree question to the top --- assets/themes/glutenfree/glutenfree.json | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/assets/themes/glutenfree/glutenfree.json b/assets/themes/glutenfree/glutenfree.json index 16732f48b..bb2fa2550 100644 --- a/assets/themes/glutenfree/glutenfree.json +++ b/assets/themes/glutenfree/glutenfree.json @@ -10,6 +10,7 @@ "layers": [ { "builtin": "food", + "hideTagRenderingsWithLabels": ["gluten_free","images","reviews"], "override": { "source": { "osmTags": { @@ -26,9 +27,11 @@ }, { "builtin": "food", + "hideTagRenderingsWithLabels": ["gluten_free","images","reviews"], "override": { "name": null, "minzoom": 17, + "isCounted": false, "filter": { "sameAs": "food_glutenfree" @@ -37,6 +40,7 @@ }, { "builtin": "ice_cream", + "hideTagRenderingsWithLabels": ["gluten_free","images","reviews"], "override": { "source": { "osmTags": { @@ -53,6 +57,7 @@ }, { "builtin": "ice_cream", + "hideTagRenderingsWithLabels": ["gluten_free","images","reviews"], "override": { "name": null, "minzoom": 17, @@ -64,6 +69,7 @@ }, { "builtin": "shops", + "hideTagRenderingsWithLabels": ["gluten_free","images","reviews"], "override": { "source": { "osmTags": { @@ -80,6 +86,7 @@ }, { "builtin": "shops", + "hideTagRenderingsWithLabels": ["gluten_free","images","reviews"], "override": { "name": null, "minzoom": 17, @@ -89,5 +96,12 @@ } } } - ] + ], + "overrideAll": { + "+tagRenderings": [ + "images", + "reviews", + "gluten_free" + ] + } } From c2bbae98e1cd18800341fd24d8640a510edd2cd8 Mon Sep 17 00:00:00 2001 From: Pieter Vander Vennet Date: Fri, 19 Jul 2024 16:14:48 +0200 Subject: [PATCH 3/5] Add lactose free map, add icons to questions and titles, version bump --- assets/layers/icons/icons.json | 31 +++++ .../questions}/glutenfree.svg | 0 .../layers/questions/glutenfree.svg.license | 2 + assets/layers/questions/lactose_free.svg | 70 ++++++++++++ .../layers/questions/lactose_free.svg.license | 2 + assets/layers/questions/license_info.json | 20 ++++ assets/layers/questions/questions.json | 14 ++- assets/themes/glutenfree/glutenfree.json | 2 +- assets/themes/glutenfree/license_info.json | 12 -- assets/themes/lactosefree/lactosefree.json | 107 ++++++++++++++++++ .../mapcomplete-changes.json | 10 +- package.json | 2 +- 12 files changed, 249 insertions(+), 23 deletions(-) rename assets/{themes/glutenfree => layers/questions}/glutenfree.svg (100%) create mode 100644 assets/layers/questions/glutenfree.svg.license create mode 100644 assets/layers/questions/lactose_free.svg create mode 100644 assets/layers/questions/lactose_free.svg.license delete mode 100644 assets/themes/glutenfree/license_info.json create mode 100644 assets/themes/lactosefree/lactosefree.json diff --git a/assets/layers/icons/icons.json b/assets/layers/icons/icons.json index 83f0075bb..900c7c40b 100644 --- a/assets/layers/icons/icons.json +++ b/assets/layers/icons/icons.json @@ -256,6 +256,37 @@ } ] }, + {"id": "lactosefree", + "labels": [ + "defaults", + "in_favourite" + ], + "mappings": [ + { + "if": { + "or":["diet:lactose_free=only","diet:lactose_free=yes","diet:lactose_free=limited"] + }, + "#": "ignore-image-in-then", + "then": "lactose free" + } + ] + }, + {"id": "glutenfree", + "labels": [ + "defaults", + "in_favourite" + ], + "mappings": [ + { + "if": { + "or":["diet:gluten_free=only","diet:gluten_free=yes","diet:gluten_free=limited"] + }, + "#": "ignore-image-in-then", + "then": "gluten free" + } + ] + }, + { "id": "sharelink", "labels": [ diff --git a/assets/themes/glutenfree/glutenfree.svg b/assets/layers/questions/glutenfree.svg similarity index 100% rename from assets/themes/glutenfree/glutenfree.svg rename to assets/layers/questions/glutenfree.svg diff --git a/assets/layers/questions/glutenfree.svg.license b/assets/layers/questions/glutenfree.svg.license new file mode 100644 index 000000000..858e45e6b --- /dev/null +++ b/assets/layers/questions/glutenfree.svg.license @@ -0,0 +1,2 @@ +SPDX-FileCopyrightText: vladi1081384728 +SPDX-License-Identifier: CC-BY-SA-4.0 \ No newline at end of file diff --git a/assets/layers/questions/lactose_free.svg b/assets/layers/questions/lactose_free.svg new file mode 100644 index 000000000..3693bdf39 --- /dev/null +++ b/assets/layers/questions/lactose_free.svg @@ -0,0 +1,70 @@ + + + + + + + + + + + + + + + + diff --git a/assets/layers/questions/lactose_free.svg.license b/assets/layers/questions/lactose_free.svg.license new file mode 100644 index 000000000..305d4e513 --- /dev/null +++ b/assets/layers/questions/lactose_free.svg.license @@ -0,0 +1,2 @@ +SPDX-FileCopyrightText: rihlsul +SPDX-License-Identifier: CC-BY 3.0 \ No newline at end of file diff --git a/assets/layers/questions/license_info.json b/assets/layers/questions/license_info.json index 88c1bec03..c36d3502c 100644 --- a/assets/layers/questions/license_info.json +++ b/assets/layers/questions/license_info.json @@ -71,6 +71,26 @@ "https://github.com/pietervdvn/MapComplete/pull/1948" ] }, + { + "path": "glutenfree.svg", + "license": "CC-BY-SA-4.0", + "authors": [ + "vladi1081384728" + ], + "sources": [ + "https://www.vecteezy.com/vector-art/7225296-gluten-free-vector-label" + ] + }, + { + "path": "lactose_free.svg", + "license": "CC-BY 3.0", + "authors": [ + "rihlsul" + ], + "sources": [ + "https://game-icons.net/1x1/rihlsul/milk-carton.html" + ] + }, { "path": "nfc_card.svg", "license": "CC0-1.0", diff --git a/assets/layers/questions/questions.json b/assets/layers/questions/questions.json index 38dfa9b3a..dacaf02d8 100644 --- a/assets/layers/questions/questions.json +++ b/assets/layers/questions/questions.json @@ -2475,7 +2475,9 @@ "en": "Only sells lactose free products", "de": "Ausschließlich laktosefreie Produkte", "cs": "Prodává pouze výrobky bez laktózy" - } + }, + "icon": "./assets/layers/questions/lactose_free.svg" + }, { "if": "diet:lactose_free=yes", @@ -2483,7 +2485,9 @@ "en": "Big lactose free offering", "de": "Viele laktosefreie Produkte", "cs": "Velká nabídka bez laktózy" - } + }, + "icon": "./assets/layers/questions/lactose_free.svg" + }, { "if": "diet:lactose_free=limited", @@ -2522,7 +2526,8 @@ "en": "This shop only sells gluten free products", "de": "Das Geschäft verkauft ausschließlich glutenfreie Produkte", "cs": "Tento obchod prodává pouze bezlepkové produkty" - } + }, + "icon": "./assets/layers/questions/glutenfree.svg" }, { "if": "diet:gluten_free=yes", @@ -2530,7 +2535,8 @@ "en": "This shop has a big gluten free offering", "de": "Das Geschäft verkauft viele glutenfreie Produkte", "cs": "Tento obchod má velkou bezlepkovou nabídku" - } + }, + "icon": "./assets/layers/questions/glutenfree.svg" }, { "if": "diet:gluten_free=limited", diff --git a/assets/themes/glutenfree/glutenfree.json b/assets/themes/glutenfree/glutenfree.json index bb2fa2550..a4ddf92d3 100644 --- a/assets/themes/glutenfree/glutenfree.json +++ b/assets/themes/glutenfree/glutenfree.json @@ -6,7 +6,7 @@ "description": { "en": "A crowdsourced map with glutenfree items" }, - "icon": "./assets/themes/glutenfree/glutenfree.svg", + "icon": "./assets/layers/questions/glutenfree.svg", "layers": [ { "builtin": "food", diff --git a/assets/themes/glutenfree/license_info.json b/assets/themes/glutenfree/license_info.json deleted file mode 100644 index 000deb31b..000000000 --- a/assets/themes/glutenfree/license_info.json +++ /dev/null @@ -1,12 +0,0 @@ -[ - { - "path": "glutenfree.svg", - "license": "CC-BY-SA-4.0", - "authors": [ - "vladi1081384728" - ], - "sources": [ - "https://www.vecteezy.com/vector-art/7225296-gluten-free-vector-label" - ] - } -] \ No newline at end of file diff --git a/assets/themes/lactosefree/lactosefree.json b/assets/themes/lactosefree/lactosefree.json new file mode 100644 index 000000000..8b77065c9 --- /dev/null +++ b/assets/themes/lactosefree/lactosefree.json @@ -0,0 +1,107 @@ +{ + "id": "lactosefree", + "title": { + "en": "Lactose free shops and restaurants" + }, + "description": { + "en": "A crowdsourced map with lactose free shops and restaurants" + }, + "icon": "./assets/layers/questions/lactose_free.svg", + "layers": [ + { + "builtin": "food", + "hideTagRenderingsWithLabels": ["lactose_free","images","reviews"], + "override": { + "source": { + "osmTags": { + "and+": [ + "diet:lactose_free!=", + "diet:lactose_free!~no" + ] + } + }, + "id": "food_lactosefree", + "minzoom": 4, + "presets": null + } + }, + { + "builtin": "food", + "hideTagRenderingsWithLabels": ["lactose_free","images","reviews"], + "override": { + "name": null, + "minzoom": 17, + + "isCounted": false, + "filter": { + "sameAs": "food_lactosefree" + } + } + }, + { + "builtin": "ice_cream", + "hideTagRenderingsWithLabels": ["lactose_free","images","reviews"], + "override": { + "source": { + "osmTags": { + "and+": [ + "diet:lactose_free!=", + "diet:lactose_free!~no" + ] + } + }, + "id": "icecream_lactosefree", + "minzoom": 4, + "presets": null + } + }, + { + "builtin": "ice_cream", + "hideTagRenderingsWithLabels": ["lactose_free","images","reviews"], + "override": { + "name": null, + "minzoom": 17, + "isCounted": false, + "filter": { + "sameAs": "icecream_lactosefree" + } + } + }, + { + "builtin": "shops", + "hideTagRenderingsWithLabels": ["lactose_free","images","reviews"], + "override": { + "source": { + "osmTags": { + "and+": [ + "diet:lactose_free!=", + "diet:lactose_free!~no" + ] + } + }, + "id": "shops_lactosefree", + "minzoom": 4, + "presets": null + } + }, + { + "builtin": "shops", + "hideTagRenderingsWithLabels": ["lactose_free","images","reviews"], + "override": { + "name": null, + "minzoom": 17, + "isCounted": false, + "filter": { + "sameAs": "shops_lactosefree" + } + } + } + ], + "overrideAll": { + "+tagRenderings": [ + "images", + "reviews", + "lactose_free" + ] + } +} diff --git a/assets/themes/mapcomplete-changes/mapcomplete-changes.json b/assets/themes/mapcomplete-changes/mapcomplete-changes.json index fe87d0a9e..2518682c9 100644 --- a/assets/themes/mapcomplete-changes/mapcomplete-changes.json +++ b/assets/themes/mapcomplete-changes/mapcomplete-changes.json @@ -263,7 +263,7 @@ }, { "if": "theme=glutenfree", - "then": "./assets/themes/glutenfree/glutenfree.svg" + "then": "./assets/layers/questions/glutenfree.svg" }, { "if": "theme=grb", @@ -306,12 +306,12 @@ "then": "./assets/layers/kerbs/KerbIcon.svg" }, { - "if": "theme=lighthouses", - "then": "./assets/themes/lighthouses/lighthouse.svg" + "if": "theme=lactosefree", + "then": "./assets/layers/questions/lactose_free.svg" }, { - "if": "theme=mapcomplete-changes", - "then": "./assets/svg/logo.svg" + "if": "theme=lighthouses", + "then": "./assets/themes/lighthouses/lighthouse.svg" }, { "if": "theme=maproulette", diff --git a/package.json b/package.json index 12f573727..9f5d0e7ab 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "mapcomplete", - "version": "0.44.9", + "version": "0.44.10", "repository": "https://github.com/pietervdvn/MapComplete", "description": "A small website to edit OSM easily", "bugs": "https://github.com/pietervdvn/MapComplete/issues", From c8c0a28340aa127d3e0e1d608edadf278f74e43d Mon Sep 17 00:00:00 2001 From: Pieter Vander Vennet Date: Fri, 19 Jul 2024 16:19:46 +0200 Subject: [PATCH 4/5] Optimize svg --- assets/layers/questions/glutenfree.svg | 39 +++++++++---------- .../mapcomplete-changes.json | 4 ++ 2 files changed, 22 insertions(+), 21 deletions(-) diff --git a/assets/layers/questions/glutenfree.svg b/assets/layers/questions/glutenfree.svg index f4d4c8cc4..ffaa7e3a8 100644 --- a/assets/layers/questions/glutenfree.svg +++ b/assets/layers/questions/glutenfree.svg @@ -1,19 +1,19 @@ - - + + + inkscape:current-layer="svg1" /> + + diff --git a/assets/themes/mapcomplete-changes/mapcomplete-changes.json b/assets/themes/mapcomplete-changes/mapcomplete-changes.json index 2518682c9..1054fd6f4 100644 --- a/assets/themes/mapcomplete-changes/mapcomplete-changes.json +++ b/assets/themes/mapcomplete-changes/mapcomplete-changes.json @@ -313,6 +313,10 @@ "if": "theme=lighthouses", "then": "./assets/themes/lighthouses/lighthouse.svg" }, + { + "if": "theme=mapcomplete-changes", + "then": "./assets/svg/logo.svg" + }, { "if": "theme=maproulette", "then": "./assets/layers/maproulette/logomark.svg" From ed256c264bb425486191f6ab26916ed30b3a9c14 Mon Sep 17 00:00:00 2001 From: Pieter Vander Vennet Date: Fri, 19 Jul 2024 17:00:24 +0200 Subject: [PATCH 5/5] Fix broken build --- assets/layers/questions/lactose_free.svg | 2 ++ 1 file changed, 2 insertions(+) diff --git a/assets/layers/questions/lactose_free.svg b/assets/layers/questions/lactose_free.svg index 3693bdf39..fd85f8296 100644 --- a/assets/layers/questions/lactose_free.svg +++ b/assets/layers/questions/lactose_free.svg @@ -1,6 +1,8 @@