From 083d588361766d3ac9f77e408df725a78b3f9b4f Mon Sep 17 00:00:00 2001 From: Pieter Vander Vennet Date: Thu, 20 Feb 2025 11:13:41 +0100 Subject: [PATCH] Themes(cyclofix): don't handle bicycle repair stations in shops, even if they have service:bicycle-tags, fix https://source.mapcomplete.org/MapComplete/MapComplete/issues/2318 --- assets/layers/bike_shop/bike_shop.json | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/assets/layers/bike_shop/bike_shop.json b/assets/layers/bike_shop/bike_shop.json index 5ac2d7433..e07e17375 100644 --- a/assets/layers/bike_shop/bike_shop.json +++ b/assets/layers/bike_shop/bike_shop.json @@ -35,9 +35,18 @@ "#": "We select all bicycle shops, sports shops (but we try to weed out non-bicycle related shops), and any shop with a bicycle related tag", "or": [ "shop=bicycle", - "service:bicycle:retail=yes", - "service:bicycle:repair=yes", - "service:bicycle:second_hand=yes", + { + "and": [ + "amenity!=bicycle_repair_station", + { + "or": [ + "service:bicycle:retail=yes", + "service:bicycle:repair=yes", + "service:bicycle:second_hand=yes" + ] + } + ] + }, { "#": "if sport is defined and is not bicycle, it is not matched; if bicycle retail/repair is marked as 'no', it is not shown to too.", "##": "There will be a few false-positives with this. They will get filtered out by people marking both 'not selling bikes' and 'not repairing bikes'. Furthermore, the OSMers will add a sports-subcategory on it",