From 2843b01586fd40a2e0d4dc92861b9d001d1684d3 Mon Sep 17 00:00:00 2001
From: Pieter Vander Vennet <pietervdvn@posteo.net>
Date: Thu, 5 Oct 2023 16:05:57 +0200
Subject: [PATCH] Fix: add check that no changeset is opened without actually
 having changes

---
 src/Logic/Osm/Changes.ts | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/src/Logic/Osm/Changes.ts b/src/Logic/Osm/Changes.ts
index d6e9c642fc..0d59a84cc3 100644
--- a/src/Logic/Osm/Changes.ts
+++ b/src/Logic/Osm/Changes.ts
@@ -517,6 +517,17 @@ export class Changes {
             ...motivations,
             ...perBinMessage,
         ]
+        {
+            const changes: {
+                newObjects: OsmObject[]
+                modifiedObjects: OsmObject[]
+                deletedObjects: OsmObject[]
+            } = self.CreateChangesetObjects(pending, objects);
+            if(changes.newObjects.length + changes.modifiedObjects.length + changes.deletedObjects.length === 0){
+                console.log("Not opening/uploading a changeset; seems like all changes are already applied")
+                return true
+            }
+        }
 
         await this._changesetHandler.UploadChangeset(
             (csId, remappings) => {
@@ -525,11 +536,14 @@ export class Changes {
                     pending = pending.map((ch) => ChangeDescriptionTools.rewriteIds(ch, remappings))
                     console.log("Result is", pending)
                 }
+
                 const changes: {
                     newObjects: OsmObject[]
                     modifiedObjects: OsmObject[]
                     deletedObjects: OsmObject[]
                 } = self.CreateChangesetObjects(pending, objects)
+
+
                 return Changes.createChangesetFor("" + csId, changes)
             },
             metatags,