From 4b1fdc0e2fa91b70d1f5c53f30f0445d25a58e09 Mon Sep 17 00:00:00 2001 From: RobJN Date: Sat, 4 Feb 2023 20:52:41 +0000 Subject: [PATCH] Update SimpleMetaTagger.ts objectMetaInfo should return false if it does not change anything (e.g. if run on a non-OSM layer). Returning true causes MetaTagging to execute state?.allElements?.getEventSourceById(feature.properties.id)?.ping() with is slow and makes MapComplete unresponsive in some themes. Helps with #1094 --- Logic/SimpleMetaTagger.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Logic/SimpleMetaTagger.ts b/Logic/SimpleMetaTagger.ts index 589678ad20..004b83dc91 100644 --- a/Logic/SimpleMetaTagger.ts +++ b/Logic/SimpleMetaTagger.ts @@ -118,6 +118,7 @@ export default class SimpleMetaTaggers { /*Note: also called by 'UpdateTagsFromOsmAPI'*/ const tgs = feature.properties + let movedSomething = false; function move(src: string, target: string) { if (tgs[src] === undefined) { @@ -125,6 +126,7 @@ export default class SimpleMetaTaggers { } tgs[target] = tgs[src] delete tgs[src] + movedSomething = true } move("user", "_last_edit:contributor") @@ -132,7 +134,7 @@ export default class SimpleMetaTaggers { move("changeset", "_last_edit:changeset") move("timestamp", "_last_edit:timestamp") move("version", "_version_number") - return true + return movedSomething } ) public static country = new CountryTagger()