diff --git a/scripts/Script.ts b/scripts/Script.ts index b8fb4f400d..65b2fcfa39 100644 --- a/scripts/Script.ts +++ b/scripts/Script.ts @@ -24,7 +24,7 @@ export default abstract class Script { }) .catch((e) => { console.log(`ERROR in script ${process.argv[1]}:`, e) - // process.exit(1) + process.exit(1) }) } diff --git a/scripts/generateLayerOverview.ts b/scripts/generateLayerOverview.ts index 51b2edab3f..1ad9c5e2b3 100644 --- a/scripts/generateLayerOverview.ts +++ b/scripts/generateLayerOverview.ts @@ -9,16 +9,12 @@ import { DoesImageExist, PrevalidateTheme, ValidateLayer, - ValidateThemeEnsemble, + ValidateThemeEnsemble } from "../src/Models/ThemeConfig/Conversion/Validation" import { Translation } from "../src/UI/i18n/Translation" import { PrepareLayer } from "../src/Models/ThemeConfig/Conversion/PrepareLayer" import { PrepareTheme } from "../src/Models/ThemeConfig/Conversion/PrepareTheme" -import { - Conversion, - DesugaringContext, - DesugaringStep, -} from "../src/Models/ThemeConfig/Conversion/Conversion" +import { Conversion, DesugaringContext, DesugaringStep } from "../src/Models/ThemeConfig/Conversion/Conversion" import { Utils } from "../src/Utils" import Script from "./Script" import { AllSharedLayers } from "../src/Customizations/AllSharedLayers" @@ -654,6 +650,9 @@ class LayerOverviewUtils extends Script { if (sharedLayers.has(fixed.id)) { throw "There are multiple layers with the id " + fixed.id + ", " + sharedLayerPath } + if (parsed.context.hasErrors()) { + throw "Some layers contain errors" + } sharedLayers.set(fixed.id, fixed) recompiledLayers.push(fixed.id) diff --git a/scripts/prepare-build.sh b/scripts/prepare-build.sh index d5fdd54311..88bb11ee78 100755 --- a/scripts/prepare-build.sh +++ b/scripts/prepare-build.sh @@ -22,7 +22,6 @@ npm run generate && # includes a single "refresh:layeroverview". Resetting the f npm run generate:mapcomplete-changes-theme && npm run refresh:layeroverview && # a second time to propagate all calls npm run refresh:layeroverview && # a third time to fix some issues with the favourite layer all calls - npm run generate:layouts if [ $? -ne 0 ]; then