From 8dd7f34ad733080e9e5e648a91942528d96857ed Mon Sep 17 00:00:00 2001
From: Pieter Vander Vennet <pietervdvn@posteo.net>
Date: Mon, 2 Sep 2024 03:38:37 +0200
Subject: [PATCH] Fix: hash would not clear because the update method
 unregistered itself

---
 src/Logic/Web/ThemeViewStateHashActor.ts | 12 +++++-------
 1 file changed, 5 insertions(+), 7 deletions(-)

diff --git a/src/Logic/Web/ThemeViewStateHashActor.ts b/src/Logic/Web/ThemeViewStateHashActor.ts
index de208c8084..acded8c92b 100644
--- a/src/Logic/Web/ThemeViewStateHashActor.ts
+++ b/src/Logic/Web/ThemeViewStateHashActor.ts
@@ -27,7 +27,6 @@ export default class ThemeViewStateHashActor {
      * Note that there is no "real" way to intercept the back button, we can only detect the removal of the hash.
      * As such, we use a change in the hash to close the appropriate windows
      *
-     * @param state
      */
     constructor(state: ThemeViewState) {
         this._state = state
@@ -120,26 +119,25 @@ export default class ThemeViewStateHashActor {
      * 1. Selected element ID
      * 2. A selected 'page' from the menu
      *
-     * returns 'true' if a hash was set
      */
-    private setHash(): boolean {
+    private setHash(): void {
+        // Important ! This function is called by 'addCallback' and might thus never return 'true' or it will be unregistered
         this.isUpdatingHash = true
         try {
-
             const selectedElement = this._state.selectedElement.data
             if (selectedElement) {
                 Hash.hash.set(selectedElement.properties.id)
-                return true
+                return
             }
             for (const page in this._state.guistate.pageStates) {
                 const toggle = this._state.guistate.pageStates[page]
                 if (toggle.data) {
                     Hash.hash.set(page)
-                    return true
+                    return
                 }
             }
             Hash.hash.set(undefined)
-            return false
+            return
         } finally {
             this.isUpdatingHash = false
         }